Re: [PATCH 1/4] btrfs: avoid double clean up when submit_one_bio() failed

[Qu Wenruo <wqu@suse.com>]

On 2022/4/11 15:19, Christoph Hellwig wrote:
> On Mon, Apr 11, 2022 at 03:15:23PM +0800, Qu Wenruo wrote:
>> This patch itself is for backport, thus I didn't change the return type
>> to make backport easier.
> 
> Umm, if you don't remove all that buggy error handling code in a
> backport you'll have to fix it.  So do the right thing here and just
> get rid of it ASAP including for the backport.
> 

I don't think there is much difference by making submit_one_bio() to 
always return 0, and backporting the full type change.

For btrfs development, no one will base their code on stable, thus what 
they see is the one returning void.

For vendor backports, I have left a comment on why we return 0 manually, 
it should be clear enough to solve any future conflicts.

I'll let David to determine the correct way, as small backport + proper 
cleanup policy for bug fixes is pretty common here AFAIK.

Thanks,
Qu