Re: [PATCH 4/4] btrfs: make submit_one_bio() to return void

[Qu Wenruo <wqu@suse.com>]

On 2022/4/11 15:18, Christoph Hellwig wrote:
> On Mon, Apr 11, 2022 at 02:12:52PM +0800, Qu Wenruo wrote:
>> Since commit "btrfs: avoid double clean up when submit_one_bio()
>> failed", submit_one_bio() will never return any error, as if we hit any
>> error, endio function will be responsible to cleanup the mess.
>>
>> So here we're completely fine to make submit_one_bio() to return void.
>>
>> NOTE: not all bio submission hooks should return void.
>>
>> Hooks for async submission, like btrfs_submit_bio_start_direct_io() or
>> btrfs_submit_bio_start(), they should still return error, so
>> run_one_async_done() can detect the error properly.
> 
> This really should go into patch 1.
> 
Stable tree won't be happy about the size.

Thanks,
Qu