From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/4] btrfs: fix the error handling for submit_extent_page() for btrfs_do_readpage()
Date: Mon, 11 Apr 2022 00:18:33 -0700 [thread overview]
Message-ID: <YlPWSTqn5z19Jtzk@infradead.org> (raw)
In-Reply-To: <2ce5b91dba107bba1ff56c9ebbadcd70e6d333e5.1649657016.git.wqu@suse.com>
On Mon, Apr 11, 2022 at 02:12:50PM +0800, Qu Wenruo wrote:
> [BUG]
> Test case generic/475 have a very high chance (almost 100%) to hit a fs
> hang, where a data page will never be unlocked and hang all later
> operations.
Question: how can we even get an error? The submission already stopped
return errors with patch 1. btrfs_get_chunk_map called from
btrfs_zoned_get_device and calc_bio_boundaries really just has sanity
checks that should be fatal if not met, same for btrfs_get_io_geometry.
So yes, we could fix the nasty error handling here. Or just remove it
entirely, which would reduce the possibility of bugs even more.
next prev parent reply other threads:[~2022-04-11 7:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 6:12 [PATCH 0/4] btrfs: vairous bug fixes related to generic/475 failure with subpage cases Qu Wenruo
2022-04-11 6:12 ` [PATCH 1/4] btrfs: avoid double clean up when submit_one_bio() failed Qu Wenruo
2022-04-11 7:14 ` Christoph Hellwig
2022-04-11 7:15 ` Qu Wenruo
2022-04-11 7:19 ` Christoph Hellwig
2022-04-11 7:35 ` Qu Wenruo
2022-04-11 6:12 ` [PATCH 2/4] btrfs: fix the error handling for submit_extent_page() for btrfs_do_readpage() Qu Wenruo
2022-04-11 7:18 ` Christoph Hellwig [this message]
2022-04-11 7:31 ` Qu Wenruo
2022-04-11 6:12 ` [PATCH 3/4] btrfs: return correct error number for __extent_writepage_io() Qu Wenruo
2022-04-11 6:12 ` [PATCH 4/4] btrfs: make submit_one_bio() to return void Qu Wenruo
2022-04-11 7:18 ` Christoph Hellwig
2022-04-11 7:20 ` Qu Wenruo
2022-04-11 12:15 ` Christoph Hellwig
2022-04-11 12:23 ` Greg KH
2022-04-11 12:29 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlPWSTqn5z19Jtzk@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox