public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: add verbose option to btrfs device scan
Date: Tue, 16 Jul 2019 10:50:52 +0800	[thread overview]
Message-ID: <34F9F895-BFE6-4C99-9458-221D7555FECC@oracle.com> (raw)
In-Reply-To: <e8aaa2cf-3e10-4ff9-dabe-c6192583e93c@gmx.com>



> On 16 Jul 2019, at 9:26 AM, Qu Wenruo <quwenruo.btrfs@gmx.com> wrote:
> 
> 
> 
> On 2019/7/15 下午11:09, Nikolay Borisov wrote:
>> 
>> 
>> On 15.07.19 г. 17:42 ч., Anand Jain wrote:
>>> To help debug device scan issues, add verbose option to btrfs device scan.
>>> 
>>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> 
>> I fail to see what this patch helps for. We get the path in case of
>> errors, in case of success what good could the path be ?
> 
> AFAIK it would provide an easy way to debug blkid related bug.
> 
> E.g. scan only works on some devices and misses some devices.
> 
> So it makes sense to me, although "debug" would be more suitable in this
> case.

 As the objective is to show the devices scanned with
 its device path, so IMO verbose would be suitable?  Its a small change,
 can be modified at the time of integration. Will send V2 with a nit fix
 to use bool instead of int.

Thanks, Anand

  reply	other threads:[~2019-07-16  2:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15 14:42 [PATCH] btrfs-progs: add verbose option to btrfs device scan Anand Jain
2019-07-15 15:09 ` Nikolay Borisov
2019-07-16  0:36   ` Anand Jain
2019-07-16  1:26   ` Qu Wenruo
2019-07-16  2:50     ` Anand Jain [this message]
2019-07-16  6:46     ` Nikolay Borisov
2019-07-16  8:59       ` Anand Jain
2019-07-16  3:05 ` [PATCH v2] " Anand Jain
2019-08-28  7:51   ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34F9F895-BFE6-4C99-9458-221D7555FECC@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox