From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>,
Anand Jain <anand.jain@oracle.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: add verbose option to btrfs device scan
Date: Tue, 16 Jul 2019 09:46:04 +0300 [thread overview]
Message-ID: <d40bf6e2-cf8f-d2af-a769-b217f97ab7dc@suse.com> (raw)
In-Reply-To: <e8aaa2cf-3e10-4ff9-dabe-c6192583e93c@gmx.com>
On 16.07.19 г. 4:26 ч., Qu Wenruo wrote:
>
>
> On 2019/7/15 下午11:09, Nikolay Borisov wrote:
>>
>>
>> On 15.07.19 г. 17:42 ч., Anand Jain wrote:
>>> To help debug device scan issues, add verbose option to btrfs device scan.
>>>
>>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>>
>> I fail to see what this patch helps for. We get the path in case of
>> errors, in case of success what good could the path be ?
>
> AFAIK it would provide an easy way to debug blkid related bug.
>
> E.g. scan only works on some devices and misses some devices.
In this case (and I already debugged one such case) it's invaluable to
use LIBBLKID_DEBUG environment variable, the debug string added in this
patch won't help in this particular case.
<snip>
next prev parent reply other threads:[~2019-07-16 6:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 14:42 [PATCH] btrfs-progs: add verbose option to btrfs device scan Anand Jain
2019-07-15 15:09 ` Nikolay Borisov
2019-07-16 0:36 ` Anand Jain
2019-07-16 1:26 ` Qu Wenruo
2019-07-16 2:50 ` Anand Jain
2019-07-16 6:46 ` Nikolay Borisov [this message]
2019-07-16 8:59 ` Anand Jain
2019-07-16 3:05 ` [PATCH v2] " Anand Jain
2019-08-28 7:51 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d40bf6e2-cf8f-d2af-a769-b217f97ab7dc@suse.com \
--to=nborisov@suse.com \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox