From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Qu Wenruo <wqu@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: replace a wrong memset() with memzero_page()
Date: Fri, 25 Mar 2022 18:49:20 +0800 [thread overview]
Message-ID: <3cf47cbf-ae0d-2942-d427-7b6cb9602d27@gmx.com> (raw)
In-Reply-To: <PH0PR04MB7416A2B700E658F640B7FEF39B1A9@PH0PR04MB7416.namprd04.prod.outlook.com>
On 2022/3/25 18:10, Johannes Thumshirn wrote:
> On 25/03/2022 10:38, Qu Wenruo wrote:
>> The original code is not really setting the memory to 0x00 but 0x01.
>>
>> To prevent such problem from happening, use memzero_page() instead.
>>
>> Since we're here, also make @len const since it's just sectorsize.
>
> Any idea why we're setting it to 1? It's been this way since 07157aacb1ec
> ("Btrfs: Add file data csums back in via hooks in the extent map code")
> which landed in v2.6.29. So basically since the dawn of time.
No idea at all, maybe just a typo.
Thanks,
Qu
>
>
>
>
next prev parent reply other threads:[~2022-03-25 10:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 9:37 [PATCH] btrfs: replace a wrong memset() with memzero_page() Qu Wenruo
2022-03-25 10:10 ` Johannes Thumshirn
2022-03-25 10:49 ` Qu Wenruo [this message]
2022-03-25 10:58 ` Johannes Thumshirn
2022-03-25 16:38 ` Christoph Hellwig
2022-03-26 1:15 ` Qu Wenruo
2022-04-05 4:58 ` Christoph Hellwig
2022-04-05 5:08 ` Qu Wenruo
2022-04-05 14:04 ` David Sterba
2022-04-05 13:59 ` David Sterba
2022-03-28 18:51 ` David Sterba
2022-03-28 18:58 ` David Sterba
2022-03-29 9:57 ` Filipe Manana
2022-03-29 10:49 ` Qu Wenruo
2022-03-29 11:39 ` Filipe Manana
2022-03-29 23:52 ` Qu Wenruo
2022-03-30 9:27 ` Filipe Manana
2022-03-30 10:34 ` Filipe Manana
2022-03-30 10:42 ` Qu Wenruo
2022-03-30 11:02 ` Filipe Manana
2022-03-30 11:03 ` Graham Cobb
2022-03-30 21:34 ` Filipe Manana
2022-03-30 22:29 ` Graham Cobb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cf47cbf-ae0d-2942-d427-7b6cb9602d27@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox