From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: replace a wrong memset() with memzero_page()
Date: Fri, 25 Mar 2022 09:38:16 -0700 [thread overview]
Message-ID: <Yj3v+MnFOXeeAU9d@infradead.org> (raw)
In-Reply-To: <8d6f911a0282eba76f9e05d6f1e7c6f091d4870b.1648199349.git.wqu@suse.com>
On Fri, Mar 25, 2022 at 05:37:59PM +0800, Qu Wenruo wrote:
> - u32 len = fs_info->sectorsize;
> + const u32 len = fs_info->sectorsize;
Why the spurious and rather pointless const annotation that is unrelated
to the rest of the patch?
> BTRFS_DEV_STAT_CORRUPTION_ERRS);
> - memset(kaddr + pgoff, 1, len);
> + memzero_page(page, pgoff, len);
> flush_dcache_page(page);
memzero_page already takes care of the flush_dcache_page.
next prev parent reply other threads:[~2022-03-25 16:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 9:37 [PATCH] btrfs: replace a wrong memset() with memzero_page() Qu Wenruo
2022-03-25 10:10 ` Johannes Thumshirn
2022-03-25 10:49 ` Qu Wenruo
2022-03-25 10:58 ` Johannes Thumshirn
2022-03-25 16:38 ` Christoph Hellwig [this message]
2022-03-26 1:15 ` Qu Wenruo
2022-04-05 4:58 ` Christoph Hellwig
2022-04-05 5:08 ` Qu Wenruo
2022-04-05 14:04 ` David Sterba
2022-04-05 13:59 ` David Sterba
2022-03-28 18:51 ` David Sterba
2022-03-28 18:58 ` David Sterba
2022-03-29 9:57 ` Filipe Manana
2022-03-29 10:49 ` Qu Wenruo
2022-03-29 11:39 ` Filipe Manana
2022-03-29 23:52 ` Qu Wenruo
2022-03-30 9:27 ` Filipe Manana
2022-03-30 10:34 ` Filipe Manana
2022-03-30 10:42 ` Qu Wenruo
2022-03-30 11:02 ` Filipe Manana
2022-03-30 11:03 ` Graham Cobb
2022-03-30 21:34 ` Filipe Manana
2022-03-30 22:29 ` Graham Cobb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yj3v+MnFOXeeAU9d@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox