* [PATCH] btrfs: Remove impossible BUG_ON in get_tree_block_key @ 2020-03-04 15:04 Nikolay Borisov 2020-03-04 18:49 ` Josef Bacik 2020-03-04 19:25 ` David Sterba 0 siblings, 2 replies; 3+ messages in thread From: Nikolay Borisov @ 2020-03-04 15:04 UTC (permalink / raw) To: linux-btrfs; +Cc: Nikolay Borisov relocate_tree_blocks calls get_tree_block_key for a block iff that block has its ->key_ready equal false. Thus the BUG_ON in the latter function cannot ever be triggered so remove it. Signed-off-by: Nikolay Borisov <nborisov@suse.com> --- fs/btrfs/relocation.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index f6aa65d55273..7415cab677a4 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -3020,7 +3020,6 @@ static int get_tree_block_key(struct btrfs_fs_info *fs_info, { struct extent_buffer *eb; - BUG_ON(block->key_ready); eb = read_tree_block(fs_info, block->bytenr, block->key.offset, block->level, NULL); if (IS_ERR(eb)) { -- 2.17.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: Remove impossible BUG_ON in get_tree_block_key 2020-03-04 15:04 [PATCH] btrfs: Remove impossible BUG_ON in get_tree_block_key Nikolay Borisov @ 2020-03-04 18:49 ` Josef Bacik 2020-03-04 19:25 ` David Sterba 1 sibling, 0 replies; 3+ messages in thread From: Josef Bacik @ 2020-03-04 18:49 UTC (permalink / raw) To: Nikolay Borisov, linux-btrfs On 3/4/20 10:04 AM, Nikolay Borisov wrote: > relocate_tree_blocks calls get_tree_block_key for a block iff that block > has its ->key_ready equal false. Thus the BUG_ON in the latter function > cannot ever be triggered so remove it. > > Signed-off-by: Nikolay Borisov <nborisov@suse.com> Reviewed-by: Josef Bacik <josef@toxicpanda.com> Thanks, Josef ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: Remove impossible BUG_ON in get_tree_block_key 2020-03-04 15:04 [PATCH] btrfs: Remove impossible BUG_ON in get_tree_block_key Nikolay Borisov 2020-03-04 18:49 ` Josef Bacik @ 2020-03-04 19:25 ` David Sterba 1 sibling, 0 replies; 3+ messages in thread From: David Sterba @ 2020-03-04 19:25 UTC (permalink / raw) To: Nikolay Borisov; +Cc: linux-btrfs On Wed, Mar 04, 2020 at 05:04:47PM +0200, Nikolay Borisov wrote: > relocate_tree_blocks calls get_tree_block_key for a block iff that block > has its ->key_ready equal false. Thus the BUG_ON in the latter function > cannot ever be triggered so remove it. > > Signed-off-by: Nikolay Borisov <nborisov@suse.com> Added to misc-next, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-04 19:25 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-03-04 15:04 [PATCH] btrfs: Remove impossible BUG_ON in get_tree_block_key Nikolay Borisov 2020-03-04 18:49 ` Josef Bacik 2020-03-04 19:25 ` David Sterba
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox