Re: [PATCH 02/11, v2] btrfs-progs: no pending balance is not an error

[Anand Jain <Anand.Jain@oracle.com>]

Oh. this title prefix should be v2 not RESEND.

v1->v2
  Accepts David review comments

Thanks,  Anand

On 04/15/2013 02:38 PM, Anand Jain wrote:
> Having no balance running/ paused/completed is a normal
> situation, so the current output message should be positive
> with return val zero.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
>   cmds-balance.c | 16 +++++++++++++---
>   1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/cmds-balance.c b/cmds-balance.c
> index f5dc317..a968e0d 100644
> --- a/cmds-balance.c
> +++ b/cmds-balance.c
> @@ -616,6 +616,12 @@ static const char * const cmd_balance_status_usage[] = {
>   	NULL
>   };
>
> +/* Checks the status of the balance if any
> + * return codes:
> + *  -1 : Error failed to know if there is any pending balance
> + *   1 : Successful to know status of a pending balance
> + *   0 : When there is no pending balance or completed
> + */
>   static int cmd_balance_status(int argc, char **argv)
>   {
>   	struct btrfs_ioctl_balance_args args;
> @@ -662,9 +668,13 @@ static int cmd_balance_status(int argc, char **argv)
>   	close(fd);
>
>   	if (ret < 0) {
> +		if (e == ENOTCONN) {
> +			printf("No balance found on '%s'\n", path);
> +			return 0;
> +		}
>   		fprintf(stderr, "ERROR: balance status on '%s' failed - %s\n",
> -			path, (e == ENOTCONN) ? "Not in progress" : strerror(e));
> -		return 19;
> +			path, strerror(e));
> +		return -1;
>   	}
>
>   	if (args.state & BTRFS_BALANCE_STATE_RUNNING) {
> @@ -688,7 +698,7 @@ static int cmd_balance_status(int argc, char **argv)
>   	if (verbose)
>   		dump_ioctl_balance_args(&args);
>
> -	return 0;
> +	return 1;
>   }
>
>   const struct cmd_group balance_cmd_group = {
>