From: Anand Jain <Anand.Jain@oracle.com>
To: dsterba@suse.cz
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 02/11, RESEND] btrfs-progs: no pending balance is not an error
Date: Tue, 16 Apr 2013 13:02:03 +0800 [thread overview]
Message-ID: <516CDB4B.9080609@oracle.com> (raw)
In-Reply-To: <20130415162127.GE18193@twin.jikos.cz>
On 04/16/2013 12:21 AM, David Sterba wrote:
> On Mon, Apr 15, 2013 at 02:38:08PM +0800, Anand Jain wrote:
>> +/* Checks the status of the balance if any
>> + * return codes:
>> + * -1 : Error failed to know if there is any pending balance
>> + * 1 : Successful to know status of a pending balance
>> + * 0 : When there is no pending balance or completed
>
> The error code will become the return code of the 'btrfs balance status'
> command in the end:
>
> btrfs.c:main()
>
> 295 exit(cmd->fn(argc, argv));
>
> and that's why I've suggested to return 1 or 2, though -1 matches shell
> error code 255 but I'd rathe avoid using it.
makes sense. v3 is out.
next prev parent reply other threads:[~2013-04-16 5:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 5:54 [PATCH 0/9] a bunch of miscellaneous bug fixes Anand Jain
2013-04-05 5:54 ` [PATCH 1/9] [RESEND] btrfs-progs: root_item generation_v2 is out of sync after btrfsck Anand Jain
2013-04-05 5:54 ` [PATCH 2/9] btrfs-progs: no pending balance is not an error Anand Jain
2013-04-12 15:57 ` David Sterba
2013-04-15 2:22 ` Anand Jain
2013-04-05 5:54 ` [PATCH 3/9] btrfs-progs: mkfs should first check all disks before writing to a disk Anand Jain
2013-04-12 16:06 ` David Sterba
2013-04-15 6:47 ` Anand Jain
2013-04-05 5:54 ` [PATCH 4/9] btrfs-progs: check if btrfs kernel module is loaded Anand Jain
2013-04-10 8:23 ` [PATCH 4/9 v2] " Anand Jain
2013-04-12 16:23 ` David Sterba
2013-04-15 7:14 ` Anand Jain
2013-04-05 5:54 ` [PATCH 5/9] [RESEND] btrfs-progs: delete unused function get_mountpt Anand Jain
2013-04-05 5:55 ` [PATCH 6/9] btrfs-progs: mkfs stdout print to match chronology Anand Jain
2013-04-05 5:55 ` [PATCH 7/9] btrfs-progs: cmd replace should check target-dev fully Anand Jain
2013-04-05 5:55 ` [PATCH 8/9] btrfs-progs: btrfs-select-super output is confusing when it fails Anand Jain
2013-04-05 5:55 ` [PATCH 9/9] btrfs-progs: fix btrfs scrub start help Anand Jain
2013-04-05 9:05 ` Stefan Behrens
2013-04-08 2:09 ` [PATCH 9/9 v2] " Anand Jain
2013-04-08 2:20 ` [PATCH 9/9 v3] " Anand Jain
2013-04-11 9:58 ` [PATCH] btrfs-progs: avoid ioctl for multipath-dev with its non-multipath path Anand Jain
2013-04-15 6:38 ` [PATCH 00/11 v2] a bunch of miscellaneous bug fixes Anand Jain
2013-04-15 6:38 ` [PATCH 01/11, RESEND] btrfs-progs: root_item generation_v2 is out of sync after btrfsck Anand Jain
2013-04-21 23:09 ` Eric Sandeen
2013-04-15 6:38 ` [PATCH 02/11, RESEND] btrfs-progs: no pending balance is not an error Anand Jain
2013-04-15 6:44 ` [PATCH 02/11, v2] " Anand Jain
2013-04-16 4:58 ` [PATCH 02/11 v3] " Anand Jain
2013-04-15 16:21 ` [PATCH 02/11, RESEND] " David Sterba
2013-04-16 5:02 ` Anand Jain [this message]
2013-04-15 6:38 ` [PATCH 03/11 v2] btrfs-progs: mkfs should first check all disks before writing to a disk Anand Jain
2013-04-15 6:38 ` [PATCH 04/11 v2] btrfs-progs: cmd replace should check target-dev fully Anand Jain
2013-04-15 6:38 ` [PATCH 05/11, RESEND] btrfs-progs: mkfs stdout print to match chronology Anand Jain
2013-04-15 6:38 ` [PATCH 06/11, v2] btrfs-progs: check if btrfs kernel module is loaded Anand Jain
2013-04-15 7:11 ` [PATCH 06/11 v3] " Anand Jain
2013-04-15 6:38 ` [PATCH 07/11, RESEND] btrfs-progs: delete unused function get_mountpt Anand Jain
2013-04-15 6:38 ` [PATCH 08/11, RESEND] btrfs-progs: btrfs-select-super output is confusing when it fails Anand Jain
2013-04-15 6:38 ` [PATCH 09/11, RESEND] btrfs-progs: fix btrfs scrub start help Anand Jain
2013-04-15 6:38 ` [PATCH 10/11, RESEND] btrfs-progs: avoid ioctl for multipath-dev with its non-multipath path Anand Jain
2013-04-15 6:38 ` [PATCH 11/11, RESEND] btrfs-progs: a copy of superblock is zero may not mean btrfs is not there Anand Jain
2013-04-16 12:15 ` [PATCH 00/11 v2] a bunch of miscellaneous bug fixes David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516CDB4B.9080609@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox