Re: [PATCH 3/3] btrfs-progs: tests: add new mkfs test for zoned device

[Qu Wenruo <wqu@suse.com>]

在 2025/9/2 13:59, Naohiro Aota 写道:
> This new test is based on mkfs-tests/001-basic-profiles, and it goes
> through the profiles to mkfs and do some basic checks.
> 
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>

Despite the cond_wait_for_nullbdevs() usage, the test case itself looks 
good to me.

With the comment in patch 2 addressed, feel free to add:

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu
> ---
>   tests/mkfs-tests/039-zoned-profiles/test.sh | 98 +++++++++++++++++++++
>   1 file changed, 98 insertions(+)
>   create mode 100755 tests/mkfs-tests/039-zoned-profiles/test.sh
> 
> diff --git a/tests/mkfs-tests/039-zoned-profiles/test.sh b/tests/mkfs-tests/039-zoned-profiles/test.sh
> new file mode 100755
> index 000000000000..f40648cd06e1
> --- /dev/null
> +++ b/tests/mkfs-tests/039-zoned-profiles/test.sh
> @@ -0,0 +1,98 @@
> +#!/bin/bash
> +# test various blockgroup profile combinations, use nullb devices as block
> +# devices. This test is based on mkfs-tests/001-basic-profiles.
> +
> +source "$TEST_TOP/common" || exit
> +
> +check_prereq mkfs.btrfs
> +check_prereq btrfs
> +check_global_prereq blkzone
> +
> +setup_root_helper
> +# Create one 128M device with 4M zones, 32 of them
> +setup_nullbdevs 4 128 4
> +prepare_nullbdevs
> +dev1=${nullb_devs[1]}
> +
> +test_get_info()
> +{
> +	local tmp_out
> +
> +	tmp_out=$(_mktemp mkfs-get-info)
> +	run_check $SUDO_HELPER "$TOP/btrfs" inspect-internal dump-super "$dev1"
> +	run_check $SUDO_HELPER "$TOP/btrfs" check "$dev1"
> +
> +	# Work around for kernel bug that will treat SINGLE and single
> +	# device RAID0 as the same.
> +	# Thus kernel may create new SINGLE chunks, causing extra warning
> +	# when testing single device RAID0.
> +	cond_wait_for_nullbdevs
> +	run_check $SUDO_HELPER mount -o ro "$dev1" "$TEST_MNT"
> +	run_check_stdout "$TOP/btrfs" filesystem df "$TEST_MNT" > "$tmp_out"
> +	if grep -q "Multiple block group profiles detected" "$tmp_out"; then
> +		rm -- "$tmp_out"
> +		_fail "temporary chunks are not properly cleaned up"
> +	fi
> +	rm -- "$tmp_out"
> +	run_check $SUDO_HELPER "$TOP/btrfs" filesystem usage "$TEST_MNT"
> +	run_check $SUDO_HELPER "$TOP/btrfs" device usage "$TEST_MNT"
> +	run_check $SUDO_HELPER umount "$TEST_MNT"
> +}
> +
> +test_do_mkfs()
> +{
> +	run_check $SUDO_HELPER "$TOP/mkfs.btrfs" -f "$@"
> +	if run_check_stdout $SUDO_HELPER "$TOP/btrfs" check "$dev1" | grep -iq warning; then
> +		_fail "warnings found in check output"
> +	fi
> +}
> +
> +test_mkfs_single()
> +{
> +	test_do_mkfs "$@" "$dev1"
> +	test_get_info
> +}
> +test_mkfs_multi()
> +{
> +	test_do_mkfs "$@" ${nullb_devs[@]}
> +	test_get_info
> +}
> +
> +test_mkfs_single
> +test_mkfs_single  -d  single  -m  single
> +test_mkfs_single  -d  single  -m  dup
> +
> +test_mkfs_multi
> +test_mkfs_multi   -d  single  -m  single
> +
> +if [ -f "/sys/fs/btrfs/features/raid_stripe_tree" ]; then
> +	test_mkfs_single  -d  dup     -m  single
> +	test_mkfs_single  -d  dup     -m  dup
> +
> +	test_mkfs_multi   -d  raid0   -m  raid0
> +	test_mkfs_multi   -d  raid1   -m  raid1
> +	test_mkfs_multi   -d  raid10  -m  raid10
> +	# RAID5/6 are not yet supported.
> +	# test_mkfs_multi   -d  raid5   -m  raid5
> +	# test_mkfs_multi   -d  raid6   -m  raid6
> +	test_mkfs_multi   -d  dup     -m  dup
> +
> +	if [ -f "/sys/fs/btrfs/features/raid1c34" ]; then
> +		test_mkfs_multi   -d  raid1c3 -m  raid1c3
> +		test_mkfs_multi   -d  raid1c4 -m  raid1c4
> +	else
> +		_log "skip mount test, missing support for raid1c34"
> +		test_do_mkfs -d raid1c3 -m raid1c3 ${nullb_devs[@]}
> +		test_do_mkfs -d raid1c4 -m raid1c4 ${nullb_devs[@]}
> +	fi
> +
> +	# Non-standard profile/device combinations
> +
> +	# Single device raid0, two device raid10 (simple mount works on older kernels too)
> +	test_do_mkfs -d raid0 -m raid0 "$dev1"
> +	test_get_info
> +	test_do_mkfs -d raid10 -m raid10 "${nullb_devs[1]}" "${nullb_devs[2]}"
> +	test_get_info
> +fi
> +
> +cleanup_nullbdevs