Re: [PATCH 3/3] btrfs-progs: tests: add new mkfs test for zoned device

[Naohiro Aota <Naohiro.Aota@wdc.com>]

On Wed Sep 3, 2025 at 3:57 AM JST, David Sterba wrote:
> On Tue, Sep 02, 2025 at 09:59:20AM +0000, Johannes Thumshirn wrote:
>> On 9/2/25 6:30 AM, Naohiro Aota wrote:
>> > +if [ -f "/sys/fs/btrfs/features/raid_stripe_tree" ]; then
>> > +	test_mkfs_single  -d  dup     -m  single
>> > +	test_mkfs_single  -d  dup     -m  dup
>> > +
>> > +	test_mkfs_multi   -d  raid0   -m  raid0
>> > +	test_mkfs_multi   -d  raid1   -m  raid1
>> > +	test_mkfs_multi   -d  raid10  -m  raid10
>> > +	# RAID5/6 are not yet supported.
>> > +	# test_mkfs_multi   -d  raid5   -m  raid5
>> > +	# test_mkfs_multi   -d  raid6   -m  raid6
>> > +	test_mkfs_multi   -d  dup     -m  dup
>> > +
>> > +	if [ -f "/sys/fs/btrfs/features/raid1c34" ]; then
>> > +		test_mkfs_multi   -d  raid1c3 -m  raid1c3
>> > +		test_mkfs_multi   -d  raid1c4 -m  raid1c4
>> > +	else
>> > +		_log "skip mount test, missing support for raid1c34"
>> > +		test_do_mkfs -d raid1c3 -m raid1c3 ${nullb_devs[@]}
>> > +		test_do_mkfs -d raid1c4 -m raid1c4 ${nullb_devs[@]}
>> > +	fi
>> > +
>> > +	# Non-standard profile/device combinations
>> > +
>> > +	# Single device raid0, two device raid10 (simple mount works on older kernels too)
>> > +	test_do_mkfs -d raid0 -m raid0 "$dev1"
>> > +	test_get_info
>> > +	test_do_mkfs -d raid10 -m raid10 "${nullb_devs[1]}" "${nullb_devs[2]}"
>> > +	test_get_info
>> > +fi
>> Wouldn't this need to check if mkfs.btrfs supports "-O raid-stripe-tree" 
>> as well?
>
> The assumption of the environment is that kernel may not support all
> features so there are the sysfs checks. For progs this assumes that it's
> either a git version or the the testsuite version matches the installed
> progs version.
>
> We could possibly encode the assumptions simlar to what check_prereq()
> does but for version-dependent features. I'm not sure if it's worth, so
> far nobody else complained but it does make sense to make it more
> robust.

I remembered that raid-stripe-tree is still only available with the
EXPERIMENTAL config. I'll add "_test_config EXPERIMENTAL" for this part.