Re: [PATCH 2/3] btrfs-progs: tests: add {,cond_}wait_for_nullbdevs

[Naohiro Aota <Naohiro.Aota@wdc.com>]

On Tue Sep 2, 2025 at 6:15 PM JST, Qu Wenruo wrote:
>
>
> 在 2025/9/2 13:59, Naohiro Aota 写道:
>> It is a nullb version of {,cond_}wait_for_loopdevs. It waits for all the
>> nullb devices are ready to use.
>> 
>> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
>> ---
>>   tests/common | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>> 
>> diff --git a/tests/common b/tests/common
>> index 2c90acb90cfc..1df37c390bf6 100644
>> --- a/tests/common
>> +++ b/tests/common
>> @@ -984,6 +984,20 @@ cleanup_nullbdevs()
>>   		name=$(basename "$dev")
>>   		run_check $SUDO_HELPER "$nullb" rm "$name"
>>   	done
>> +	unset nullb_devs
>> +}
>> +
>> +wait_for_nullbdevs()
>> +{
>> +	for dev in ${nullb_devs[@]}; do
>> +		run_mayfail $SUDO_HELPER "$TOP/btrfs" device ready "$dev"
>> +	done
>> +}
>> +
>> +cond_wait_for_nullbdevs() {
>> +	if [ -n "${nullb_devs[1]}" ]; then
>> +		wait_for_nullbdevs
>> +	fi
>
> I guess we don't need cond_wait_for_nummbdevs()?
>
> As if nullb_devs array is not defined/empty, the for loop inside 
> wait_for_nullbdevs() will do nothing anyway.

Ah, yes, that's correct. I followed cond_wait_for_loopdevs here. Maybe,
we should drop wait_for_loopdevs and convert the callers as wel.

>
> Thanks,
> Qu
>
>>   }
>>   
>>   init_env()