From: Dave Chinner <david@fromorbit.com>
To: Filipe Manana <fdmanana@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Zorro Lang <zlang@redhat.com>, Anand Jain <anand.jain@oracle.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH] fstests: finish UMOUNT_PROG to _unmount conversion
Date: Thu, 27 Feb 2025 08:37:46 +1100 [thread overview]
Message-ID: <Z7-JqucPHv2E6ncE@dread.disaster.area> (raw)
In-Reply-To: <CAL3q7H41a=gzDtQDX8L4ep5PhD4ZpuSCUiNGzx5eK2h_N6bQXQ@mail.gmail.com>
On Wed, Feb 26, 2025 at 10:37:20AM +0000, Filipe Manana wrote:
> On Tue, Feb 25, 2025 at 10:19 PM Dave Chinner <david@fromorbit.com> wrote:
> > diff --git a/tests/btrfs/029 b/tests/btrfs/029
> > index c37ad63fb..1f8201af3 100755
> > --- a/tests/btrfs/029
> > +++ b/tests/btrfs/029
> > @@ -74,7 +74,7 @@ cp --reflink=always $orig_file $copy_file >> $seqres.full 2>&1 || echo "cp refli
> > md5sum $orig_file | _filter_testdir_and_scratch
> > md5sum $copy_file | _filter_testdir_and_scratch
> >
> > -$UMOUNT_PROG $reflink_test_dir
> > +_unmount $reflink_test_dir
>
> This isn't equivalent to directly calling UMOUNT_PROG since the
> _unmount helper always redirects stdout and stderr to $seqres.full.
Please update your tree to the latest for-next. _unmount does,
indeed, return stdout/stderr to the caller, and so as the commit
message says, it is a drop-in replacement for UMOUNT_PROG.
I wouldn't have sent the patch in this form if that hadn't been
fixed.
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2025-02-26 21:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 18:19 [PATCH 0/2] fstests: a couple fixes for btrfs/254 fdmanana
2025-02-19 18:19 ` [PATCH 1/2] btrfs/254: don't leave mount on test fs in case of failure/interruption fdmanana
2025-02-20 5:27 ` Anand Jain
2025-02-20 17:03 ` Darrick J. Wong
2025-02-20 18:22 ` Filipe Manana
2025-02-21 1:48 ` Anand Jain
2025-02-21 6:09 ` Zorro Lang
2025-02-21 4:18 ` Darrick J. Wong
2025-02-21 6:02 ` Zorro Lang
2025-02-21 20:22 ` Darrick J. Wong
2025-02-25 22:19 ` [PATCH] fstests: finish UMOUNT_PROG to _unmount conversion Dave Chinner
2025-02-26 10:37 ` Filipe Manana
2025-02-26 16:16 ` Darrick J. Wong
2025-02-26 21:37 ` Dave Chinner [this message]
2025-02-19 18:19 ` [PATCH 2/2] btrfs/254: fix test failure in case scratch devices are larger than 50G fdmanana
2025-02-20 6:45 ` Anand Jain
2025-02-19 22:13 ` [PATCH 0/2] fstests: a couple fixes for btrfs/254 David Sterba
2025-02-20 6:42 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7-JqucPHv2E6ncE@dread.disaster.area \
--to=david@fromorbit.com \
--cc=anand.jain@oracle.com \
--cc=djwong@kernel.org \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox