From: Christoph Hellwig <hch@infradead.org>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
ritesh.list@gmail.com, ojaswin@linux.ibm.com, djwong@kernel.org,
zlang@kernel.org, fdmanana@kernel.org
Subject: Re: [PATCH 5/7] generic/563: Increase the write tolerance to 6% for larger nodesize
Date: Tue, 29 Jul 2025 00:45:57 -0700 [thread overview]
Message-ID: <aIh8NT2DhablZp5G@infradead.org> (raw)
In-Reply-To: <f48538de3ce4a98a2128f48aa0f005f51eb552ee.1753769382.git.nirjhar.roy.lists@gmail.com>
On Tue, Jul 29, 2025 at 06:21:48AM +0000, Nirjhar Roy (IBM) wrote:
> +# writes, due to increased metadata sizes.
> +# Hence have a higher write tolerance for btrfs and when
> +# node size is greater than 4k.
> +if [[ "$FSTYP" == "btrfs" ]]; then
> + nodesz=$(_get_btrfs_node_size "$SCRATCH_DEV")
> + if [[ "$nodesz" -gt 4096 ]]; then
> + check_cg $cgdir/$seq-cg $iosize $iosize 5% 6%
> + else
> + check_cg $cgdir/$seq-cg $iosize $iosize 5% 5%
> + fi
> +else
> + check_cg $cgdir/$seq-cg $iosize $iosize 5% 5%
> +fi
Everyone please stop hacking file system specific things into generic
tests. Add proper core helpers for this instead.
next prev parent reply other threads:[~2025-07-29 7:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 6:21 [PATCH 0/7] btrfs: Misc test fixes for large block/node sizes Nirjhar Roy (IBM)
2025-07-29 6:21 ` [PATCH 1/7] common/filter: Add a helper function to filter offsets and sizes Nirjhar Roy (IBM)
2025-07-29 6:21 ` [PATCH 2/7] common/btrfs: Add a helper function to get the nodesize Nirjhar Roy (IBM)
2025-07-29 6:21 ` [PATCH 3/7] btrfs/137: Make this compatible with all block sizes Nirjhar Roy (IBM)
2025-08-04 3:58 ` Qu Wenruo
2025-08-05 9:41 ` Ojaswin Mujoo
2025-08-05 9:44 ` Qu Wenruo
2025-08-05 12:39 ` Ojaswin Mujoo
2025-08-05 10:47 ` Filipe Manana
2025-08-12 6:23 ` Nirjhar Roy (IBM)
2025-08-12 6:22 ` Nirjhar Roy (IBM)
2025-07-29 6:21 ` [PATCH 4/7] btrfs/200: Make this test scale with the block size Nirjhar Roy (IBM)
2025-07-29 6:53 ` Filipe Manana
2025-08-12 6:26 ` Nirjhar Roy (IBM)
2025-08-04 4:19 ` Qu Wenruo
2025-07-29 6:21 ` [PATCH 5/7] generic/563: Increase the write tolerance to 6% for larger nodesize Nirjhar Roy (IBM)
2025-07-29 7:45 ` Christoph Hellwig [this message]
2025-08-04 7:18 ` Nirjhar Roy (IBM)
2025-07-30 15:06 ` Filipe Manana
2025-08-04 7:18 ` Nirjhar Roy (IBM)
2025-08-04 4:28 ` Qu Wenruo
2025-08-12 6:27 ` Nirjhar Roy (IBM)
2025-07-29 6:21 ` [PATCH 6/7] btrfs/301: Make this test compatible with all block sizes Nirjhar Roy (IBM)
2025-08-04 4:32 ` Qu Wenruo
2025-08-12 6:30 ` Nirjhar Roy (IBM)
2025-07-29 6:21 ` [PATCH 7/7] generic/274: Make the test compatible with all blocksizes Nirjhar Roy (IBM)
2025-08-04 4:35 ` Qu Wenruo
2025-08-12 6:30 ` Nirjhar Roy (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIh8NT2DhablZp5G@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=fdmanana@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=nirjhar.roy.lists@gmail.com \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox