From: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>
To: fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org, ritesh.list@gmail.com,
ojaswin@linux.ibm.com, djwong@kernel.org, zlang@kernel.org,
fdmanana@kernel.org, nirjhar.roy.lists@gmail.com
Subject: [PATCH 5/7] generic/563: Increase the write tolerance to 6% for larger nodesize
Date: Tue, 29 Jul 2025 06:21:48 +0000 [thread overview]
Message-ID: <f48538de3ce4a98a2128f48aa0f005f51eb552ee.1753769382.git.nirjhar.roy.lists@gmail.com> (raw)
In-Reply-To: <cover.1753769382.git.nirjhar.roy.lists@gmail.com>
When tested with blocksize/nodesize 64K on powerpc
with 64k pagesize on btrfs, then the test fails
with the folllowing error:
QA output created by 563
read/write
read is in range
-write is in range
+write has value of 8855552
+write is NOT in range 7969177.6 .. 8808038.4
write -> read/write
...
The slight increase in the amount of bytes that
are written is because of the increase in the
the nodesize(metadata) and hence it exceeds the tolerance limit slightly.
Fix this by increasing the write tolerance limit from 5% from 6%
for 64k blocksize btrfs.
Reported-by: Disha Goel <disgoel@linux.ibm.com>
Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
---
tests/generic/563 | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/tests/generic/563 b/tests/generic/563
index 89a71aa4..efcac1ec 100755
--- a/tests/generic/563
+++ b/tests/generic/563
@@ -119,7 +119,22 @@ $XFS_IO_PROG -c "pread 0 $iosize" -c "pwrite -b $blksize 0 $iosize" -c fsync \
$SCRATCH_MNT/file >> $seqres.full 2>&1
switch_cg $cgdir
$XFS_IO_PROG -c fsync $SCRATCH_MNT/file
-check_cg $cgdir/$seq-cg $iosize $iosize 5% 5%
+blksz=`_get_block_size $SCRATCH_MNT`
+
+# On higher node sizes on btrfs, we observed slightly more
+# writes, due to increased metadata sizes.
+# Hence have a higher write tolerance for btrfs and when
+# node size is greater than 4k.
+if [[ "$FSTYP" == "btrfs" ]]; then
+ nodesz=$(_get_btrfs_node_size "$SCRATCH_DEV")
+ if [[ "$nodesz" -gt 4096 ]]; then
+ check_cg $cgdir/$seq-cg $iosize $iosize 5% 6%
+ else
+ check_cg $cgdir/$seq-cg $iosize $iosize 5% 5%
+ fi
+else
+ check_cg $cgdir/$seq-cg $iosize $iosize 5% 5%
+fi
# Write from one cgroup then read and write from a second. Writes are charged to
# the first group and nothing to the second.
--
2.34.1
next prev parent reply other threads:[~2025-07-29 6:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 6:21 [PATCH 0/7] btrfs: Misc test fixes for large block/node sizes Nirjhar Roy (IBM)
2025-07-29 6:21 ` [PATCH 1/7] common/filter: Add a helper function to filter offsets and sizes Nirjhar Roy (IBM)
2025-07-29 6:21 ` [PATCH 2/7] common/btrfs: Add a helper function to get the nodesize Nirjhar Roy (IBM)
2025-07-29 6:21 ` [PATCH 3/7] btrfs/137: Make this compatible with all block sizes Nirjhar Roy (IBM)
2025-08-04 3:58 ` Qu Wenruo
2025-08-05 9:41 ` Ojaswin Mujoo
2025-08-05 9:44 ` Qu Wenruo
2025-08-05 12:39 ` Ojaswin Mujoo
2025-08-05 10:47 ` Filipe Manana
2025-08-12 6:23 ` Nirjhar Roy (IBM)
2025-08-12 6:22 ` Nirjhar Roy (IBM)
2025-07-29 6:21 ` [PATCH 4/7] btrfs/200: Make this test scale with the block size Nirjhar Roy (IBM)
2025-07-29 6:53 ` Filipe Manana
2025-08-12 6:26 ` Nirjhar Roy (IBM)
2025-08-04 4:19 ` Qu Wenruo
2025-07-29 6:21 ` Nirjhar Roy (IBM) [this message]
2025-07-29 7:45 ` [PATCH 5/7] generic/563: Increase the write tolerance to 6% for larger nodesize Christoph Hellwig
2025-08-04 7:18 ` Nirjhar Roy (IBM)
2025-07-30 15:06 ` Filipe Manana
2025-08-04 7:18 ` Nirjhar Roy (IBM)
2025-08-04 4:28 ` Qu Wenruo
2025-08-12 6:27 ` Nirjhar Roy (IBM)
2025-07-29 6:21 ` [PATCH 6/7] btrfs/301: Make this test compatible with all block sizes Nirjhar Roy (IBM)
2025-08-04 4:32 ` Qu Wenruo
2025-08-12 6:30 ` Nirjhar Roy (IBM)
2025-07-29 6:21 ` [PATCH 7/7] generic/274: Make the test compatible with all blocksizes Nirjhar Roy (IBM)
2025-08-04 4:35 ` Qu Wenruo
2025-08-12 6:30 ` Nirjhar Roy (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f48538de3ce4a98a2128f48aa0f005f51eb552ee.1753769382.git.nirjhar.roy.lists@gmail.com \
--to=nirjhar.roy.lists@gmail.com \
--cc=djwong@kernel.org \
--cc=fdmanana@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox