From: Torin Cooper-Bennun <torin@maxiluxsystems.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH can-next 2/5] can: m_can: m_can_isr(): handle device-specific interrupts
Date: Tue, 1 Jun 2021 08:22:17 +0100 [thread overview]
Message-ID: <20210601072217.kazos5xe7iqcqkmd@bigthink> (raw)
In-Reply-To: <20210526150705.s4ms7jhowsuts3yf@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
On Wed, May 26, 2021 at 05:07:05PM +0200, Marc Kleine-Budde wrote:
> > diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> > index fa853201d2c4..3bc957da06f7 100644
> > --- a/drivers/net/can/m_can/m_can.c
> > +++ b/drivers/net/can/m_can/m_can.c
> > @@ -1033,17 +1033,24 @@ static irqreturn_t m_can_isr(int irq, void *dev_id)
> > struct net_device *dev = (struct net_device *)dev_id;
> > struct m_can_classdev *cdev = netdev_priv(dev);
> > u32 ir;
> > + irqreturn_t irq_ret = IRQ_NONE;
>
> nitpick: please move before the "u32 ir;"
ACK
--
Regards,
Torin Cooper-Bennun
Software Engineer | maxiluxsystems.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-06-01 7:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 12:47 [PATCH can-next 0/5] m_can, tcan4x5x: device-specific interrupt handling Torin Cooper-Bennun
2021-05-26 12:47 ` [PATCH can-next 1/5] can: m_can: ops: clear_interrupts -> handle_dev_interrupts Torin Cooper-Bennun
2021-05-26 12:47 ` [PATCH can-next 2/5] can: m_can: m_can_isr(): handle device-specific interrupts Torin Cooper-Bennun
2021-05-26 15:07 ` Marc Kleine-Budde
2021-05-26 15:18 ` Marc Kleine-Budde
2021-06-01 8:23 ` Torin Cooper-Bennun
2021-06-01 10:25 ` Marc Kleine-Budde
2021-06-01 7:22 ` Torin Cooper-Bennun [this message]
2021-05-26 12:47 ` [PATCH can-next 3/5] can: tcan4x5x: tcan4x5x_clear_interrupts(): rm unnecessary reg clears Torin Cooper-Bennun
2021-05-26 12:47 ` [PATCH can-next 4/5] can: tcan4x5x: only enable useful device interrupts Torin Cooper-Bennun
2021-05-26 12:47 ` [PATCH can-next 5/5] can: tcan4x5x: implement handling of " Torin Cooper-Bennun
2021-05-26 15:15 ` Marc Kleine-Budde
2021-06-01 7:50 ` Torin Cooper-Bennun
2021-06-01 8:19 ` Marc Kleine-Budde
2021-05-26 15:20 ` [PATCH can-next 0/5] m_can, tcan4x5x: device-specific interrupt handling Marc Kleine-Budde
2021-06-01 8:21 ` Torin Cooper-Bennun
2021-06-01 9:18 ` Marc Kleine-Budde
2021-06-01 10:56 ` Torin Cooper-Bennun
2021-07-02 7:33 ` Torin Cooper-Bennun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601072217.kazos5xe7iqcqkmd@bigthink \
--to=torin@maxiluxsystems.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox