From: Torin Cooper-Bennun <torin@maxiluxsystems.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH can-next 0/5] m_can, tcan4x5x: device-specific interrupt handling
Date: Tue, 1 Jun 2021 09:21:07 +0100 [thread overview]
Message-ID: <20210601082107.g6rfrtfpfnjfe43s@bigthink> (raw)
In-Reply-To: <20210526152045.j3efhxqpytixa7tt@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
On Wed, May 26, 2021 at 05:20:45PM +0200, Marc Kleine-Budde wrote:
> On 26.05.2021 13:47:42, Torin Cooper-Bennun wrote:
> > TCAN4550 shutdown is attempted by setting the device into standby mode.
> > There is probably a better way, but I understand we are limited by being
> > in the ISR context.
>
> Not exactly. The tcan's ISR runs in a threaded context, so you can
> basically do normal SPI or regmap transactions, shut down clocks and
> regulators, etc...
Got you. I keep forgetting that detail!
Would it be sufficient to change the CAN state as follows?
| if (handled == IRQ_HANDLED) {
| netdev_err(cdev->net,
| "Device is disabled by driver.\n");
|
| cdev->can.state = CAN_STATE_STOPPED;
|
| err = regmap_update_bits(priv->regmap, TCAN4X5X_CONFIG,
| TCAN4X5X_MODE_SEL_MASK,
| TCAN4X5X_MODE_STANDBY);
| if (err)
| goto exit_regmap_failure;
| }
--
Regards,
Torin Cooper-Bennun
Software Engineer | maxiluxsystems.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-06-01 8:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 12:47 [PATCH can-next 0/5] m_can, tcan4x5x: device-specific interrupt handling Torin Cooper-Bennun
2021-05-26 12:47 ` [PATCH can-next 1/5] can: m_can: ops: clear_interrupts -> handle_dev_interrupts Torin Cooper-Bennun
2021-05-26 12:47 ` [PATCH can-next 2/5] can: m_can: m_can_isr(): handle device-specific interrupts Torin Cooper-Bennun
2021-05-26 15:07 ` Marc Kleine-Budde
2021-05-26 15:18 ` Marc Kleine-Budde
2021-06-01 8:23 ` Torin Cooper-Bennun
2021-06-01 10:25 ` Marc Kleine-Budde
2021-06-01 7:22 ` Torin Cooper-Bennun
2021-05-26 12:47 ` [PATCH can-next 3/5] can: tcan4x5x: tcan4x5x_clear_interrupts(): rm unnecessary reg clears Torin Cooper-Bennun
2021-05-26 12:47 ` [PATCH can-next 4/5] can: tcan4x5x: only enable useful device interrupts Torin Cooper-Bennun
2021-05-26 12:47 ` [PATCH can-next 5/5] can: tcan4x5x: implement handling of " Torin Cooper-Bennun
2021-05-26 15:15 ` Marc Kleine-Budde
2021-06-01 7:50 ` Torin Cooper-Bennun
2021-06-01 8:19 ` Marc Kleine-Budde
2021-05-26 15:20 ` [PATCH can-next 0/5] m_can, tcan4x5x: device-specific interrupt handling Marc Kleine-Budde
2021-06-01 8:21 ` Torin Cooper-Bennun [this message]
2021-06-01 9:18 ` Marc Kleine-Budde
2021-06-01 10:56 ` Torin Cooper-Bennun
2021-07-02 7:33 ` Torin Cooper-Bennun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601082107.g6rfrtfpfnjfe43s@bigthink \
--to=torin@maxiluxsystems.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox