[PATCH net-next] can: sja1000: Fix comment

[PATCH net-next] can: sja1000: Fix comment

[Miquel Raynal]

There is likely a copy-paste error here, as the exact same comment
appears below in this function, one time calling set_reset_mode(), the
other set_normal_mode().

Fixes: 429da1cc841b ("can: Driver for the SJA1000 CAN controller")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 drivers/net/can/sja1000/sja1000.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/sja1000/sja1000.c b/drivers/net/can/sja1000/sja1000.c
index 158a17c9d46b..ae47fc72aa96 100644
--- a/drivers/net/can/sja1000/sja1000.c
+++ b/drivers/net/can/sja1000/sja1000.c
@@ -207,7 +207,7 @@ static void sja1000_start(struct net_device *dev)
 {
 	struct sja1000_priv *priv = netdev_priv(dev);
 
-	/* leave reset mode */
+	/* enter reset mode */
 	if (priv->can.state != CAN_STATE_STOPPED)
 		set_reset_mode(dev);
 
-- 
2.34.1

Re: [PATCH net-next] can: sja1000: Fix comment

[Simon Horman]

On Fri, Sep 22, 2023 at 05:51:30PM +0200, Miquel Raynal wrote:
> There is likely a copy-paste error here, as the exact same comment
> appears below in this function, one time calling set_reset_mode(), the
> other set_normal_mode().
> 
> Fixes: 429da1cc841b ("can: Driver for the SJA1000 CAN controller")

I'm not sure this warrants a fixes tag, which implies backporting,
but in any case the tag is correct.

> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

The above comment notwithstanding, this seems correct to me.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next] can: sja1000: Fix comment

[Miquel Raynal]

Hi Simon,

horms@kernel.org wrote on Thu, 28 Sep 2023 14:35:56 +0200:

> On Fri, Sep 22, 2023 at 05:51:30PM +0200, Miquel Raynal wrote:
> > There is likely a copy-paste error here, as the exact same comment
> > appears below in this function, one time calling set_reset_mode(), the
> > other set_normal_mode().
> > 
> > Fixes: 429da1cc841b ("can: Driver for the SJA1000 CAN controller")  
> 
> I'm not sure this warrants a fixes tag, which implies backporting,
> but in any case the tag is correct.

My understanding is that "Fixes" does not imply backporting, whereas
"Cc: stable@vger.kernel.org" actually does. In practice, stable
maintainers are using magic scripts which, it's true, often select
patches which contain a Fixes tag, but that's more a consequence of
people not Cc'ing stable when it's relevant :)

> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>  
> 
> The above comment notwithstanding, this seems correct to me.
> 
> Reviewed-by: Simon Horman <horms@kernel.org>

Thanks for the review,
Miquèl

Re: [PATCH net-next] can: sja1000: Fix comment

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

On 22.09.2023 17:51:30, Miquel Raynal wrote:
> There is likely a copy-paste error here, as the exact same comment
> appears below in this function, one time calling set_reset_mode(), the
> other set_normal_mode().
> 
> Fixes: 429da1cc841b ("can: Driver for the SJA1000 CAN controller")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Applied to linux-can-next/testing.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]