From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org
Subject: re: cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts
Date: Fri, 20 Jan 2012 11:21:32 +0300 [thread overview]
Message-ID: <20120120082132.GA21512@elgon.mountain> (raw)
Hi Jeff,
The patch 8a8798a5ff90: "cifs: fetch credentials out of keyring for
non-krb5 auth multiuser mounts" from Jan 17, 2012, has a problem here:
+ upayload = key->payload.data;
+ if (IS_ERR_OR_NULL(upayload)) {
+ rc = PTR_ERR(key);
^^^
"key" is a valid pointer not an ERR_PTR. Also "upayload" can be NULL
and PTR_ERR(NULL) is success.
+ goto out_key_put;
+ }
regards,
dan carpenter
next reply other threads:[~2012-01-20 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 8:21 Dan Carpenter [this message]
[not found] ` <20120120082132.GA21512-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2012-01-20 12:23 ` cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120120082132.GA21512@elgon.mountain \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox