re: cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts

re: cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts

[Dan Carpenter]

Hi Jeff,

The patch 8a8798a5ff90: "cifs: fetch credentials out of keyring for 
non-krb5 auth multiuser mounts" from Jan 17, 2012, has a problem here:

+       upayload = key->payload.data;
+       if (IS_ERR_OR_NULL(upayload)) {
+               rc = PTR_ERR(key);
                             ^^^
"key" is a valid pointer not an ERR_PTR.  Also "upayload" can be NULL
and PTR_ERR(NULL) is success.

+               goto out_key_put;
+       }

regards,
dan carpenter

Re: cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts

[Jeff Layton]

On Fri, 20 Jan 2012 11:21:32 +0300
Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:

> Hi Jeff,
> 
> The patch 8a8798a5ff90: "cifs: fetch credentials out of keyring for 
> non-krb5 auth multiuser mounts" from Jan 17, 2012, has a problem here:
> 
> +       upayload = key->payload.data;
> +       if (IS_ERR_OR_NULL(upayload)) {
> +               rc = PTR_ERR(key);
>                              ^^^
> "key" is a valid pointer not an ERR_PTR.  Also "upayload" can be NULL
> and PTR_ERR(NULL) is success.
> 
> +               goto out_key_put;
> +       }
> 
> regards,
> dan carpenter
> 

Doh! Good catch. Steve has already queued this patch for inclusion, but
I'll spin up a patch to fix it.

Thanks,
-- 
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>