* re: cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts
@ 2012-01-20 8:21 Dan Carpenter
[not found] ` <20120120082132.GA21512-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-01-20 8:21 UTC (permalink / raw)
To: jlayton-H+wXaHxf7aLQT0dZR+AlfA
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ
Hi Jeff,
The patch 8a8798a5ff90: "cifs: fetch credentials out of keyring for
non-krb5 auth multiuser mounts" from Jan 17, 2012, has a problem here:
+ upayload = key->payload.data;
+ if (IS_ERR_OR_NULL(upayload)) {
+ rc = PTR_ERR(key);
^^^
"key" is a valid pointer not an ERR_PTR. Also "upayload" can be NULL
and PTR_ERR(NULL) is success.
+ goto out_key_put;
+ }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts
[not found] ` <20120120082132.GA21512-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
@ 2012-01-20 12:23 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2012-01-20 12:23 UTC (permalink / raw)
To: Dan Carpenter
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ
On Fri, 20 Jan 2012 11:21:32 +0300
Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> Hi Jeff,
>
> The patch 8a8798a5ff90: "cifs: fetch credentials out of keyring for
> non-krb5 auth multiuser mounts" from Jan 17, 2012, has a problem here:
>
> + upayload = key->payload.data;
> + if (IS_ERR_OR_NULL(upayload)) {
> + rc = PTR_ERR(key);
> ^^^
> "key" is a valid pointer not an ERR_PTR. Also "upayload" can be NULL
> and PTR_ERR(NULL) is success.
>
> + goto out_key_put;
> + }
>
> regards,
> dan carpenter
>
Doh! Good catch. Steve has already queued this patch for inclusion, but
I'll spin up a patch to fix it.
Thanks,
--
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-20 12:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-20 8:21 cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts Dan Carpenter
[not found] ` <20120120082132.GA21512-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2012-01-20 12:23 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox