* [PATCH] cifs: show 'soft' in the mount options for !hard mounts
@ 2017-09-20 3:09 Ronnie Sahlberg
[not found] ` <CAH2r5msLbzwzFvwosLpLJLeLNu4+3EEs=UTxZoOzyXeOWX6mjQ@mail.gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Ronnie Sahlberg @ 2017-09-20 3:09 UTC (permalink / raw)
To: linux-cifs; +Cc: Steve French
Signed-off-by: Ronnie Sahlberg <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
fs/cifs/cifsfs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index 180b3356ff86..a864e6575309 100644
--- a/fs/cifs/cifsfs.c
+++ b/fs/cifs/cifsfs.c
@@ -461,6 +461,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
seq_puts(s, ",nocase");
if (tcon->retry)
seq_puts(s, ",hard");
+ else
+ seq_puts(s, ",soft");
if (tcon->use_persistent)
seq_puts(s, ",persistenthandles");
else if (tcon->use_resilient)
--
2.13.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cifs: show 'soft' in the mount options for !hard mounts
[not found] ` <CAH2r5msLbzwzFvwosLpLJLeLNu4+3EEs=UTxZoOzyXeOWX6mjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2017-09-20 3:24 ` Leif Sahlberg
2017-09-20 3:25 ` Steve French
1 sibling, 0 replies; 4+ messages in thread
From: Leif Sahlberg @ 2017-09-20 3:24 UTC (permalink / raw)
To: Steve French; +Cc: linux-cifs
No option on stable.
It is a trivial but purely cosmetic patch. Probably not worth the effort to post to stable.
----- Original Message -----
From: "Steve French" <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Ronnie Sahlberg" <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "linux-cifs" <linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Sent: Wednesday, 20 September, 2017 1:22:11 PM
Subject: Re: [PATCH] cifs: show 'soft' in the mount options for !hard mounts
Opinions on stable?
On Sep 19, 2017 8:09 PM, "Ronnie Sahlberg" <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Signed-off-by: Ronnie Sahlberg <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> fs/cifs/cifsfs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
> index 180b3356ff86..a864e6575309 100644
> --- a/fs/cifs/cifsfs.c
> +++ b/fs/cifs/cifsfs.c
> @@ -461,6 +461,8 @@ cifs_show_options(struct seq_file *s, struct dentry
> *root)
> seq_puts(s, ",nocase");
> if (tcon->retry)
> seq_puts(s, ",hard");
> + else
> + seq_puts(s, ",soft");
> if (tcon->use_persistent)
> seq_puts(s, ",persistenthandles");
> else if (tcon->use_resilient)
> --
> 2.13.3
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cifs: show 'soft' in the mount options for !hard mounts
[not found] ` <CAH2r5msLbzwzFvwosLpLJLeLNu4+3EEs=UTxZoOzyXeOWX6mjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-20 3:24 ` Leif Sahlberg
@ 2017-09-20 3:25 ` Steve French
[not found] ` <CAH2r5mtW38uGGO5LPKyy=O8mzctgq0kLAWbBadzk+0ztvF6Org-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
1 sibling, 1 reply; 4+ messages in thread
From: Steve French @ 2017-09-20 3:25 UTC (permalink / raw)
To: Ronnie Sahlberg; +Cc: linux-cifs
What does NFS do - does it show both "soft" and "hard"?
On Tue, Sep 19, 2017 at 10:22 PM, Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Opinions on stable?
>
> On Sep 19, 2017 8:09 PM, "Ronnie Sahlberg" <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>>
>> Signed-off-by: Ronnie Sahlberg <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>> fs/cifs/cifsfs.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
>> index 180b3356ff86..a864e6575309 100644
>> --- a/fs/cifs/cifsfs.c
>> +++ b/fs/cifs/cifsfs.c
>> @@ -461,6 +461,8 @@ cifs_show_options(struct seq_file *s, struct dentry
>> *root)
>> seq_puts(s, ",nocase");
>> if (tcon->retry)
>> seq_puts(s, ",hard");
>> + else
>> + seq_puts(s, ",soft");
>> if (tcon->use_persistent)
>> seq_puts(s, ",persistenthandles");
>> else if (tcon->use_resilient)
>> --
>> 2.13.3
>>
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cifs: show 'soft' in the mount options for !hard mounts
[not found] ` <CAH2r5mtW38uGGO5LPKyy=O8mzctgq0kLAWbBadzk+0ztvF6Org-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2017-09-20 3:31 ` Leif Sahlberg
0 siblings, 0 replies; 4+ messages in thread
From: Leif Sahlberg @ 2017-09-20 3:31 UTC (permalink / raw)
To: Steve French; +Cc: linux-cifs
NFS does the same, well except for the fact that 'hard' is default in that land.
NFS:
Mount with 'hard' : mount shows ',hard'
Mount with 'soft' : mount shows ',soft'
Mount with default : mount shows ',hard'
----- Original Message -----
From: "Steve French" <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Ronnie Sahlberg" <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "linux-cifs" <linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Sent: Wednesday, 20 September, 2017 1:25:52 PM
Subject: Re: [PATCH] cifs: show 'soft' in the mount options for !hard mounts
What does NFS do - does it show both "soft" and "hard"?
On Tue, Sep 19, 2017 at 10:22 PM, Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Opinions on stable?
>
> On Sep 19, 2017 8:09 PM, "Ronnie Sahlberg" <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>>
>> Signed-off-by: Ronnie Sahlberg <lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>> fs/cifs/cifsfs.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
>> index 180b3356ff86..a864e6575309 100644
>> --- a/fs/cifs/cifsfs.c
>> +++ b/fs/cifs/cifsfs.c
>> @@ -461,6 +461,8 @@ cifs_show_options(struct seq_file *s, struct dentry
>> *root)
>> seq_puts(s, ",nocase");
>> if (tcon->retry)
>> seq_puts(s, ",hard");
>> + else
>> + seq_puts(s, ",soft");
>> if (tcon->use_persistent)
>> seq_puts(s, ",persistenthandles");
>> else if (tcon->use_resilient)
>> --
>> 2.13.3
>>
>
--
Thanks,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-20 3:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-20 3:09 [PATCH] cifs: show 'soft' in the mount options for !hard mounts Ronnie Sahlberg
[not found] ` <CAH2r5msLbzwzFvwosLpLJLeLNu4+3EEs=UTxZoOzyXeOWX6mjQ@mail.gmail.com>
[not found] ` <CAH2r5msLbzwzFvwosLpLJLeLNu4+3EEs=UTxZoOzyXeOWX6mjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-20 3:24 ` Leif Sahlberg
2017-09-20 3:25 ` Steve French
[not found] ` <CAH2r5mtW38uGGO5LPKyy=O8mzctgq0kLAWbBadzk+0ztvF6Org-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-20 3:31 ` Leif Sahlberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox