From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Steve French <smfrench@gmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Steve French <sfrench@samba.org>,
CIFS <linux-cifs@vger.kernel.org>,
samba-technical <samba-technical@lists.samba.org>,
LKML <linux-kernel@vger.kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH 1/2] cifs: remove unused status severity defines
Date: Thu, 14 Mar 2019 16:12:45 +0900 [thread overview]
Message-ID: <20190314071245.GA2001@jagdpanzerIV> (raw)
In-Reply-To: <CAH2r5msCs5ks3FUi_GhV2REsUR8t2h1=ybgLS6FyBEyka7Qb9g@mail.gmail.com>
On (03/14/19 02:04), Steve French wrote:
[..]
> #define STATUS_SEVERITY_SUCCESS __constant_cpu_to_le32(0x0000)
Does STATUS_SEVERITY_SUCCESS still use __constant_cpu_to_le32?
> -#define STATUS_SEVERITY_INFORMATIONAL __constanst_cpu_to_le32(0x0001)
> -#define STATUS_SEVERITY_WARNING __constanst_cpu_to_le32(0x0002)
> -#define STATUS_SEVERITY_ERROR __constanst_cpu_to_le32(0x0003)
> +#define STATUS_SEVERITY_INFORMATIONAL cpu_to_le32(0x0001)
> +#define STATUS_SEVERITY_WARNING cpu_to_le32(0x0002)
> +#define STATUS_SEVERITY_ERROR cpu_to_le32(0x0003)
Otherwise looks good.
-ss
next prev parent reply other threads:[~2019-03-14 7:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 6:17 [PATCH 1/2] cifs: remove unused status severity defines Sergey Senozhatsky
2019-03-14 6:54 ` Steve French
2019-03-14 7:04 ` Steve French
2019-03-14 7:12 ` Sergey Senozhatsky [this message]
2019-03-14 7:19 ` Steve French
2019-03-14 7:39 ` Sergey Senozhatsky
2019-03-14 8:03 ` Steve French
2019-03-14 7:08 ` Sergey Senozhatsky
[not found] ` <20190314061716.19892-2-sergey.senozhatsky@gmail.com>
2019-03-15 12:31 ` [PATCH 2/2] cifs: don't use __constant_cpu_to_le32() David Laight
2019-03-15 14:29 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314071245.GA2001@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox