From: David Laight <David.Laight@ACULAB.COM>
To: 'Sergey Senozhatsky' <sergey.senozhatsky.work@gmail.com>,
Steve French <sfrench@samba.org>
Cc: "linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
"samba-technical@lists.samba.org"
<samba-technical@lists.samba.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>
Subject: RE: [PATCH 2/2] cifs: don't use __constant_cpu_to_le32()
Date: Fri, 15 Mar 2019 12:31:22 +0000 [thread overview]
Message-ID: <757dbafbdadb45f6a3de728ecfd05c5d@AcuMS.aculab.com> (raw)
In-Reply-To: <20190314061716.19892-2-sergey.senozhatsky@gmail.com>
From: Sergey Senozhatsky
>
> cpu_to_le32() is capable enough to detect __builtin_constant_p()
> and to use an appropriate compile time ___constant_swahb32()
> function.
>
> So we can use cpu_to_le32() instead of __constant_cpu_to_le32().
Unless any code tries to use them as case statement labels.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2019-03-15 12:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 6:17 [PATCH 1/2] cifs: remove unused status severity defines Sergey Senozhatsky
2019-03-14 6:54 ` Steve French
2019-03-14 7:04 ` Steve French
2019-03-14 7:12 ` Sergey Senozhatsky
2019-03-14 7:19 ` Steve French
2019-03-14 7:39 ` Sergey Senozhatsky
2019-03-14 8:03 ` Steve French
2019-03-14 7:08 ` Sergey Senozhatsky
[not found] ` <20190314061716.19892-2-sergey.senozhatsky@gmail.com>
2019-03-15 12:31 ` David Laight [this message]
2019-03-15 14:29 ` [PATCH 2/2] cifs: don't use __constant_cpu_to_le32() Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=757dbafbdadb45f6a3de728ecfd05c5d@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox