* [PATCH cifs-utils] cldap_ping.c: add missing <sys/types.h> include
@ 2024-12-26 20:42 Thomas Petazzoni
2025-01-20 16:10 ` Paulo Alcantara
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2024-12-26 20:42 UTC (permalink / raw)
To: Pavel Shilovsky; +Cc: linux-cifs, Thomas Petazzoni
Fixes:
cldap_ping.c: In function ‘read_dns_string’:
cldap_ping.c:72:37: error: ‘u_char’ undeclared (first use in this function)
when building with the musl C library, but even with glibc u_char is
defined in <sys/types.h>, it happens to work with glibc <sys/types.h>
gets included by another header.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
cldap_ping.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/cldap_ping.c b/cldap_ping.c
index 9183b27..a603be3 100644
--- a/cldap_ping.c
+++ b/cldap_ping.c
@@ -20,6 +20,7 @@
#include <talloc.h>
#include <string.h>
#include <sys/socket.h>
+#include <sys/types.h>
#include <arpa/inet.h>
#include <unistd.h>
#include <resolv.h>
--
2.47.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH cifs-utils] cldap_ping.c: add missing <sys/types.h> include
2024-12-26 20:42 [PATCH cifs-utils] cldap_ping.c: add missing <sys/types.h> include Thomas Petazzoni
@ 2025-01-20 16:10 ` Paulo Alcantara
0 siblings, 0 replies; 2+ messages in thread
From: Paulo Alcantara @ 2025-01-20 16:10 UTC (permalink / raw)
To: Thomas Petazzoni, Pavel Shilovsky; +Cc: linux-cifs, Thomas Petazzoni
Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Fixes:
>
> cldap_ping.c: In function ‘read_dns_string’:
> cldap_ping.c:72:37: error: ‘u_char’ undeclared (first use in this function)
>
> when building with the musl C library, but even with glibc u_char is
> defined in <sys/types.h>, it happens to work with glibc <sys/types.h>
> gets included by another header.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> cldap_ping.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-20 16:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-26 20:42 [PATCH cifs-utils] cldap_ping.c: add missing <sys/types.h> include Thomas Petazzoni
2025-01-20 16:10 ` Paulo Alcantara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox