[PATCH v2 2/3] cifs: warn about deprecation of /proc/fs/cifs/OplockEnabled interface

[PATCH v2 2/3] cifs: warn about deprecation of /proc/fs/cifs/OplockEnabled interface

[Suresh Jayaraman]

The plan is to deprecate this interface by kernel version 3.4.

Changes since v1
   - add a '\n' to the printk.

Reported-by: Alexander Swen <alex-UE4+9DRHXtc@public.gmane.org>
Cc: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
---
 fs/cifs/cifs_debug.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
index 2fe3cf1..831fe13 100644
--- a/fs/cifs/cifs_debug.c
+++ b/fs/cifs/cifs_debug.c
@@ -526,6 +526,9 @@ static ssize_t cifs_oplock_proc_write(struct file *file,
 	char c;
 	int rc;
 
+	printk(KERN_WARNING "CIFS: The /proc/fs/cifs/OplockEnabled interface "
+	       "will be removed in kernel version 3.4. Please migrate to "
+	       "using the 'enable_oplocks' module parameter in cifs.ko.\n");
 	rc = get_user(c, buffer);
 	if (rc)
 		return rc;

Re: [PATCH v2 2/3] cifs: warn about deprecation of /proc/fs/cifs/OplockEnabled interface

[Steve French]

Shouldn't we note /sys/module/cifs/parameters/echo_retries in the
message and the readme (since changing at runtime, e.g. to work around
a server bug temporarily, is probably more common that at module
install time).  I will probably make a minor update to the readme to
note this if it is not in the patch, but not sure about the printk.

On Wed, Oct 12, 2011 at 1:21 AM, Suresh Jayaraman <sjayaraman-IBi9RG/b67k@public.gmane.org> wrote:
> The plan is to deprecate this interface by kernel version 3.4.
>
> Changes since v1
>   - add a '\n' to the printk.
>
> Reported-by: Alexander Swen <alex-UE4+9DRHXtc@public.gmane.org>
> Cc: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
> ---
>  fs/cifs/cifs_debug.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
> index 2fe3cf1..831fe13 100644
> --- a/fs/cifs/cifs_debug.c
> +++ b/fs/cifs/cifs_debug.c
> @@ -526,6 +526,9 @@ static ssize_t cifs_oplock_proc_write(struct file *file,
>        char c;
>        int rc;
>
> +       printk(KERN_WARNING "CIFS: The /proc/fs/cifs/OplockEnabled interface "
> +              "will be removed in kernel version 3.4. Please migrate to "
> +              "using the 'enable_oplocks' module parameter in cifs.ko.\n");
>        rc = get_user(c, buffer);
>        if (rc)
>                return rc;
>



-- 
Thanks,

Steve

Re: [PATCH v2 2/3] cifs: warn about deprecation of /proc/fs/cifs/OplockEnabled interface

[Steve French]

Minor clarification - the readme mentions

	/proc/module/cifs/parameters/<param>

i.e. echo "value" > /proc/module/cifs/parameters/<param>

but in my system they are under /sys/module/....  not /proc/module/....

On Wed, Oct 12, 2011 at 5:44 PM, Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Shouldn't we note /sys/module/cifs/parameters/echo_retries in the
> message and the readme (since changing at runtime, e.g. to work around
> a server bug temporarily, is probably more common that at module
> install time).  I will probably make a minor update to the readme to
> note this if it is not in the patch, but not sure about the printk.
>
> On Wed, Oct 12, 2011 at 1:21 AM, Suresh Jayaraman <sjayaraman-WDPRK7U/wSs@public.gmane.orgm> wrote:
>> The plan is to deprecate this interface by kernel version 3.4.
>>
>> Changes since v1
>>   - add a '\n' to the printk.
>>
>> Reported-by: Alexander Swen <alex-UE4+9DRHXtc@public.gmane.org>
>> Cc: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
>> ---
>>  fs/cifs/cifs_debug.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
>> index 2fe3cf1..831fe13 100644
>> --- a/fs/cifs/cifs_debug.c
>> +++ b/fs/cifs/cifs_debug.c
>> @@ -526,6 +526,9 @@ static ssize_t cifs_oplock_proc_write(struct file *file,
>>        char c;
>>        int rc;
>>
>> +       printk(KERN_WARNING "CIFS: The /proc/fs/cifs/OplockEnabled interface "
>> +              "will be removed in kernel version 3.4. Please migrate to "
>> +              "using the 'enable_oplocks' module parameter in cifs.ko.\n");
>>        rc = get_user(c, buffer);
>>        if (rc)
>>                return rc;
>>
>
>
>
> --
> Thanks,
>
> Steve
>



-- 
Thanks,

Steve

Re: [PATCH v2 2/3] cifs: warn about deprecation of /proc/fs/cifs/OplockEnabled interface

[Suresh Jayaraman]

On 10/13/2011 04:22 AM, Steve French wrote:
> Minor clarification - the readme mentions
> 
> 	/proc/module/cifs/parameters/<param>
> 
> i.e. echo "value" > /proc/module/cifs/parameters/<param>
> 
> but in my system they are under /sys/module/....  not /proc/module/....

Sorry about this.. It is meant to be /sys/module/.. only. It was a typo.
Thanks for fixing it.


-Suresh