[PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

[PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

[Mutharaju, Prasanna (P.)]

From: Prasanna Karthik <mkarthi3@visteon.com>

Remove unneeded variable used to store return value.
---
v3: Modified subject and changelog comments
---

Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
---
 drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/c=
lk-s3c2410-dclk.c
index e9eb935..ec6fb14 100644
--- a/drivers/clk/samsung/clk-s3c2410-dclk.c
+++ b/drivers/clk/samsung/clk-s3c2410-dclk.c
@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
 static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
 {
 	struct s3c24xx_clkout *clkout =3D to_s3c24xx_clkout(hw);
-	int ret =3D 0;
=20
 	s3c2410_modify_misccr((clkout->mask << clkout->shift),
 			      (index << clkout->shift));
=20
-	return ret;
+	return 0;
 }
=20
 static const struct clk_ops s3c24xx_clkout_ops =3D {
--=20
1.9.1

Re: [PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

[Krzysztof Kozlowski]

On 30.11.2015 16:52, Mutharaju, Prasanna (P.) wrote:
> From: Prasanna Karthik <mkarthi3@visteon.com>
> 
> Remove unneeded variable used to store return value.
> ---
> v3: Modified subject and changelog comments
> ---
> 
> Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>

... and now download the patch and try to apply it with "git am". What
is missing? :)

Best regards,
Krzysztof

> ---
>  drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/clk-s3c2410-dclk.c
> index e9eb935..ec6fb14 100644
> --- a/drivers/clk/samsung/clk-s3c2410-dclk.c
> +++ b/drivers/clk/samsung/clk-s3c2410-dclk.c
> @@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
>  static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
>  {
>  	struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw);
> -	int ret = 0;
>  
>  	s3c2410_modify_misccr((clkout->mask << clkout->shift),
>  			      (index << clkout->shift));
>  
> -	return ret;
> +	return 0;
>  }
>  
>  static const struct clk_ops s3c24xx_clkout_ops = {
> 

Re: [PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

[Uwe Kleine-König]

On Mon, Nov 30, 2015 at 07:52:22AM +0000, Mutharaju, Prasanna (P.) wrote:
> From: Prasanna Karthik <mkarthi3@visteon.com>
> 
> Remove unneeded variable used to store return value.
> ---
> v3: Modified subject and changelog comments
> ---
> 
> Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>

Everything after the first triple-dash doesn't make it into the git
history, so you are expected to write the S-o-b line above the list of
things changed since a previous submission.

Other than that the patch looks fine.

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

[Mutharaju, Prasanna (P.)]

Remove unneeded variable used to store return value.

Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>

---
v3: Modified subject and changelog comments
---
---
 drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/c=
lk-s3c2410-dclk.c
index e9eb935..ec6fb14 100644
--- a/drivers/clk/samsung/clk-s3c2410-dclk.c
+++ b/drivers/clk/samsung/clk-s3c2410-dclk.c
@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
 static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
 {
 	struct s3c24xx_clkout *clkout =3D to_s3c24xx_clkout(hw);
-	int ret =3D 0;
=20
 	s3c2410_modify_misccr((clkout->mask << clkout->shift),
 			      (index << clkout->shift));
=20
-	return ret;
+	return 0;
 }
=20
 static const struct clk_ops s3c24xx_clkout_ops =3D {
--=20
1.9.1

Re: [PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

[Mutharaju, Prasanna (P.)]

On Mon, Nov 30, 2015 at 09:15:43AM +0100, Uwe Kleine-K=F6nig wrote:
> On Mon, Nov 30, 2015 at 07:52:22AM +0000, Mutharaju, Prasanna (P.) wrote:
> > From: Prasanna Karthik <mkarthi3@visteon.com>
> >=20
> > Remove unneeded variable used to store return value.
> > ---
> > v3: Modified subject and changelog comments
> > ---
> >=20
> > Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
>=20
> Everything after the first triple-dash doesn't make it into the git
> history, so you are expected to write the S-o-b line above the list of
> things changed since a previous submission.

Thanks, I resent the patch again with S-o-b before changelog.=20
>=20
> Other than that the patch looks fine.
>=20
> Uwe
>=20
> --=20
> Pengutronix e.K.                           | Uwe Kleine-K=F6nig          =
  |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  =
|=

Re: [PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

[Krzysztof Kozlowski]

W dniu 30.11.2015 o 18:52, Mutharaju, Prasanna (P.) pisze:
> Remove unneeded variable used to store return value.
> 
> Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>

Previous issues fixed, thanks! But now you changed the From field and it
does not match exactly the Signed-off-by (email matches but name does
not). Please fix this - signed-off-by should be the same as "From" (in
previous versions it was ok...).

Best regards,
Krzysztof

> 
> ---
> v3: Modified subject and changelog comments
> ---
> ---
>  drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/clk-s3c2410-dclk.c
> index e9eb935..ec6fb14 100644
> --- a/drivers/clk/samsung/clk-s3c2410-dclk.c
> +++ b/drivers/clk/samsung/clk-s3c2410-dclk.c
> @@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
>  static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
>  {
>  	struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw);
> -	int ret = 0;
>  
>  	s3c2410_modify_misccr((clkout->mask << clkout->shift),
>  			      (index << clkout->shift));
>  
> -	return ret;
> +	return 0;
>  }
>  
>  static const struct clk_ops s3c24xx_clkout_ops = {
> 

[PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

[Mutharaju, Prasanna (P.)]

From: Prasanna Karthik <mkarthi3@visteon.com>

Remove unneeded variable used to store return value.

Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>

---
v3: Modified subject and changelog comments
---
---
 drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/c=
lk-s3c2410-dclk.c
index e9eb935..ec6fb14 100644
--- a/drivers/clk/samsung/clk-s3c2410-dclk.c
+++ b/drivers/clk/samsung/clk-s3c2410-dclk.c
@@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw)
 static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
 {
 	struct s3c24xx_clkout *clkout =3D to_s3c24xx_clkout(hw);
-	int ret =3D 0;
=20
 	s3c2410_modify_misccr((clkout->mask << clkout->shift),
 			      (index << clkout->shift));
=20
-	return ret;
+	return 0;
 }
=20
 static const struct clk_ops s3c24xx_clkout_ops =3D {
--=20
1.9.1

Re: [PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

[Krzysztof Kozlowski]

2015-11-30 19:08 GMT+09:00 Mutharaju, Prasanna (P.) <mkarthi3@visteon.com>:
> From: Prasanna Karthik <mkarthi3@visteon.com>
>
> Remove unneeded variable used to store return value.
>
> Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>

Thanks,

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Re: [PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

[Sylwester Nawrocki]

On 30/11/15 11:08, Mutharaju, Prasanna (P.) wrote:
> From: Prasanna Karthik <mkarthi3@visteon.com>
> 
> Remove unneeded variable used to store return value.
> 
> Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>

Patch applied, thanks.