[PATCH] clk: lpc32xx: do not prepare clock "0"

[PATCH] clk: lpc32xx: do not prepare clock "0"

[slemieux.tyco]

From: Sylvain Lemieux <slemieux@tycoint.com>

The following errors are display in the console during the power-on:
[    0.000000] lpc32xx_usb_clk_init: failed to register (null) clock: -12
[    0.000000] lpc32xx_clk_init: failed to register (null) clock: -12

There is no need to prepare clock "0"; the first clock used is 1;

Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
---
 drivers/clk/nxp/clk-lpc32xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c
index 10dd0fd..981ff0d 100644
--- a/drivers/clk/nxp/clk-lpc32xx.c
+++ b/drivers/clk/nxp/clk-lpc32xx.c
@@ -1515,7 +1515,7 @@ static void __init lpc32xx_clk_init(struct device_node *np)
 		return;
 	}
 
-	for (i = 0; i < LPC32XX_CLK_MAX; i++) {
+	for (i = 1; i < LPC32XX_CLK_MAX; i++) {
 		clk[i] = lpc32xx_clk_register(i);
 		if (IS_ERR(clk[i])) {
 			pr_err("failed to register %s clock: %ld\n",
@@ -1555,7 +1555,7 @@ static void __init lpc32xx_usb_clk_init(struct device_node *np)
 		return;
 	}
 
-	for (i = 0; i < LPC32XX_USB_CLK_MAX; i++) {
+	for (i = 1; i < LPC32XX_USB_CLK_MAX; i++) {
 		usb_clk[i] = lpc32xx_clk_register(i + LPC32XX_CLK_USB_OFFSET);
 		if (IS_ERR(usb_clk[i])) {
 			pr_err("failed to register %s clock: %ld\n",
-- 
1.8.3.1

Re: [PATCH] clk: lpc32xx: do not prepare clock "0"

[Stephen Boyd]

On 02/09, slemieux.tyco@gmail.com wrote:
> From: Sylvain Lemieux <slemieux@tycoint.com>
> 
> The following errors are display in the console during the power-on:
> [    0.000000] lpc32xx_usb_clk_init: failed to register (null) clock: -12
> [    0.000000] lpc32xx_clk_init: failed to register (null) clock: -12
> 
> There is no need to prepare clock "0"; the first clock used is 1;
> 
> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> ---

Do you mean register instead of prepare? Change looks ok
otherwise.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH] clk: lpc32xx: do not prepare clock "0"

[Sylvain Lemieux]

On Tue, 2016-02-09 at 11:03 -0800, Stephen Boyd wrote:
> On 02/09, slemieux.tyco@gmail.com wrote:
> > From: Sylvain Lemieux <slemieux@tycoint.com>
> > 
> > The following errors are display in the console during the power-on:
> > [    0.000000] lpc32xx_usb_clk_init: failed to register (null) clock: -12
> > [    0.000000] lpc32xx_clk_init: failed to register (null) clock: -12
> > 
> > There is no need to prepare clock "0"; the first clock used is 1;
> > 
> > Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> > ---
> 
> Do you mean register instead of prepare? Change looks ok
> otherwise.
> 
Should read register in the description;
I will submit a new version of the patch tomorrow.

Re: [PATCH] clk: lpc32xx: do not prepare clock "0"

[Vladimir Zapolskiy]

Hi Sylvain,

On 09.02.2016 22:11, Sylvain Lemieux wrote:
> On Tue, 2016-02-09 at 11:03 -0800, Stephen Boyd wrote:
>> On 02/09, slemieux.tyco@gmail.com wrote:
>>> From: Sylvain Lemieux <slemieux@tycoint.com>
>>>
>>> The following errors are display in the console during the power-on:
>>> [    0.000000] lpc32xx_usb_clk_init: failed to register (null) clock: -12
>>> [    0.000000] lpc32xx_clk_init: failed to register (null) clock: -12
>>>
>>> There is no need to prepare clock "0"; the first clock used is 1;
>>>
>>> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
>>> ---
>>
>> Do you mean register instead of prepare? Change looks ok
>> otherwise.
>>
> Should read register in the description;
> I will submit a new version of the patch tomorrow.
> 

thanks for catching this leftover after renumbering clocks starting from 1.

Feel free to add to v2

Acked-by: Vladimir Zapolskiy <vz@mleia.com>

--
With best wishes,
Vladimir

Re: [PATCH] clk: lpc32xx: do not prepare clock "0"

[Stephen Boyd]

On 02/10, Vladimir Zapolskiy wrote:
> Hi Sylvain,
> 
> On 09.02.2016 22:11, Sylvain Lemieux wrote:
> > On Tue, 2016-02-09 at 11:03 -0800, Stephen Boyd wrote:
> >> On 02/09, slemieux.tyco@gmail.com wrote:
> >>> From: Sylvain Lemieux <slemieux@tycoint.com>
> >>>
> >>> The following errors are display in the console during the power-on:
> >>> [    0.000000] lpc32xx_usb_clk_init: failed to register (null) clock: -12
> >>> [    0.000000] lpc32xx_clk_init: failed to register (null) clock: -12
> >>>
> >>> There is no need to prepare clock "0"; the first clock used is 1;
> >>>
> >>> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> >>> ---
> >>
> >> Do you mean register instead of prepare? Change looks ok
> >> otherwise.
> >>
> > Should read register in the description;
> > I will submit a new version of the patch tomorrow.
> > 
> 
> thanks for catching this leftover after renumbering clocks starting from 1.
> 
> Feel free to add to v2
> 
> Acked-by: Vladimir Zapolskiy <vz@mleia.com>
> 

I subbed register for prepare and added this ack and pushed to
clk-next.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project