* [PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK
@ 2021-10-06 19:00 Fabio Estevam
2021-10-06 19:13 ` Randy Dunlap
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2021-10-06 19:00 UTC (permalink / raw)
To: abel.vesa; +Cc: shawnguo, rdunlap, ping.bai, linux-clk, Fabio Estevam
Building CLK_IMX8ULP without selecting MXC_CLK causes the following
build errors:
ld: drivers/clk/imx/clk-imx8ulp.o: in function `imx8ulp_clk_cgc2_init':
clk-imx8ulp.c:(.text+0xd0): undefined reference to `imx_ccm_lock'
ld: clk-imx8ulp.c:(.text+0x14f): undefined reference to `imx_clk_hw_pllv4'
ld: clk-imx8ulp.c:(.text+0x15a): undefined reference to `imx_ccm_lock'
Avoid this problem by making CLK_IMX8ULP select MXC_CLK.
Fixes: c43a801a5789 ("clk: imx: Add clock driver for imx8ulp")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/clk/imx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
index b81d6437ed95..c08edbd04d22 100644
--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig
@@ -102,5 +102,6 @@ config CLK_IMX8QXP
config CLK_IMX8ULP
tristate "IMX8ULP CCM Clock Driver"
depends on ARCH_MXC || COMPILE_TEST
+ select MXC_CLK
help
Build the driver for i.MX8ULP CCM Clock Driver
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK
2021-10-06 19:00 [PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK Fabio Estevam
@ 2021-10-06 19:13 ` Randy Dunlap
2021-10-06 19:15 ` Abel Vesa
2021-10-06 19:21 ` Abel Vesa
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2021-10-06 19:13 UTC (permalink / raw)
To: Fabio Estevam, abel.vesa; +Cc: shawnguo, ping.bai, linux-clk
On 10/6/21 12:00 PM, Fabio Estevam wrote:
> Building CLK_IMX8ULP without selecting MXC_CLK causes the following
> build errors:
>
> ld: drivers/clk/imx/clk-imx8ulp.o: in function `imx8ulp_clk_cgc2_init':
> clk-imx8ulp.c:(.text+0xd0): undefined reference to `imx_ccm_lock'
> ld: clk-imx8ulp.c:(.text+0x14f): undefined reference to `imx_clk_hw_pllv4'
> ld: clk-imx8ulp.c:(.text+0x15a): undefined reference to `imx_ccm_lock'
>
> Avoid this problem by making CLK_IMX8ULP select MXC_CLK.
>
> Fixes: c43a801a5789 ("clk: imx: Add clock driver for imx8ulp")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> drivers/clk/imx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index b81d6437ed95..c08edbd04d22 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -102,5 +102,6 @@ config CLK_IMX8QXP
> config CLK_IMX8ULP
> tristate "IMX8ULP CCM Clock Driver"
> depends on ARCH_MXC || COMPILE_TEST
> + select MXC_CLK
> help
> Build the driver for i.MX8ULP CCM Clock Driver
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK
2021-10-06 19:00 [PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK Fabio Estevam
2021-10-06 19:13 ` Randy Dunlap
@ 2021-10-06 19:15 ` Abel Vesa
2021-10-06 19:21 ` Abel Vesa
2 siblings, 0 replies; 4+ messages in thread
From: Abel Vesa @ 2021-10-06 19:15 UTC (permalink / raw)
To: Fabio Estevam; +Cc: shawnguo, rdunlap, ping.bai, linux-clk
On 21-10-06 16:00:08, Fabio Estevam wrote:
> Building CLK_IMX8ULP without selecting MXC_CLK causes the following
> build errors:
>
> ld: drivers/clk/imx/clk-imx8ulp.o: in function `imx8ulp_clk_cgc2_init':
> clk-imx8ulp.c:(.text+0xd0): undefined reference to `imx_ccm_lock'
> ld: clk-imx8ulp.c:(.text+0x14f): undefined reference to `imx_clk_hw_pllv4'
> ld: clk-imx8ulp.c:(.text+0x15a): undefined reference to `imx_ccm_lock'
>
> Avoid this problem by making CLK_IMX8ULP select MXC_CLK.
>
> Fixes: c43a801a5789 ("clk: imx: Add clock driver for imx8ulp")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
Good catch, Randy.
Thanks for the fix, Fabio.
> ---
> drivers/clk/imx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index b81d6437ed95..c08edbd04d22 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -102,5 +102,6 @@ config CLK_IMX8QXP
> config CLK_IMX8ULP
> tristate "IMX8ULP CCM Clock Driver"
> depends on ARCH_MXC || COMPILE_TEST
> + select MXC_CLK
> help
> Build the driver for i.MX8ULP CCM Clock Driver
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK
2021-10-06 19:00 [PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK Fabio Estevam
2021-10-06 19:13 ` Randy Dunlap
2021-10-06 19:15 ` Abel Vesa
@ 2021-10-06 19:21 ` Abel Vesa
2 siblings, 0 replies; 4+ messages in thread
From: Abel Vesa @ 2021-10-06 19:21 UTC (permalink / raw)
To: Fabio Estevam; +Cc: shawnguo, rdunlap, ping.bai, linux-clk
On 21-10-06 16:00:08, Fabio Estevam wrote:
> Building CLK_IMX8ULP without selecting MXC_CLK causes the following
> build errors:
>
> ld: drivers/clk/imx/clk-imx8ulp.o: in function `imx8ulp_clk_cgc2_init':
> clk-imx8ulp.c:(.text+0xd0): undefined reference to `imx_ccm_lock'
> ld: clk-imx8ulp.c:(.text+0x14f): undefined reference to `imx_clk_hw_pllv4'
> ld: clk-imx8ulp.c:(.text+0x15a): undefined reference to `imx_ccm_lock'
>
> Avoid this problem by making CLK_IMX8ULP select MXC_CLK.
>
> Fixes: c43a801a5789 ("clk: imx: Add clock driver for imx8ulp")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied with Randy's ack and my R-b tag. Thanks.
> ---
> drivers/clk/imx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index b81d6437ed95..c08edbd04d22 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -102,5 +102,6 @@ config CLK_IMX8QXP
> config CLK_IMX8ULP
> tristate "IMX8ULP CCM Clock Driver"
> depends on ARCH_MXC || COMPILE_TEST
> + select MXC_CLK
> help
> Build the driver for i.MX8ULP CCM Clock Driver
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-06 19:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-06 19:00 [PATCH] clk: imx: Make CLK_IMX8ULP select MXC_CLK Fabio Estevam
2021-10-06 19:13 ` Randy Dunlap
2021-10-06 19:15 ` Abel Vesa
2021-10-06 19:21 ` Abel Vesa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox