* [PATCH v2 0/2] SDM670 RPMh Clocks
@ 2022-09-20 22:37 Richard Acayan
2022-09-20 22:37 ` [PATCH v2 1/2] dt-bindings: clock: add rpmhcc bindings for sdm670 Richard Acayan
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Richard Acayan @ 2022-09-20 22:37 UTC (permalink / raw)
To: linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Taniya Das,
linux-clk, devicetree, Richard Acayan
Changes since v1:
- fix broken link
- accumulate ack tag
This patch series adds clocks controlled by RPMh for Snapdragon 670.
.../devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 +
drivers/clk/qcom/clk-rpmh.c | 21 +++++++++++++++++++++
2 files changed, 22 insertions(+)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] dt-bindings: clock: add rpmhcc bindings for sdm670
2022-09-20 22:37 [PATCH v2 0/2] SDM670 RPMh Clocks Richard Acayan
@ 2022-09-20 22:37 ` Richard Acayan
2022-09-20 22:37 ` [PATCH v2 2/2] clk: qcom: rpmhcc: add sdm670 clocks Richard Acayan
2022-09-28 3:06 ` [PATCH v2 0/2] SDM670 RPMh Clocks Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Richard Acayan @ 2022-09-20 22:37 UTC (permalink / raw)
To: linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Taniya Das,
linux-clk, devicetree, Richard Acayan
The Snapdragon 670 uses the RPMh mailbox for some clocks. Document its
support.
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml b/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
index 8fcaf418f84a..437a34b930e3 100644
--- a/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
@@ -21,6 +21,7 @@ properties:
- qcom,sc7280-rpmh-clk
- qcom,sc8180x-rpmh-clk
- qcom,sc8280xp-rpmh-clk
+ - qcom,sdm670-rpmh-clk
- qcom,sdm845-rpmh-clk
- qcom,sdx55-rpmh-clk
- qcom,sdx65-rpmh-clk
--
2.37.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] clk: qcom: rpmhcc: add sdm670 clocks
2022-09-20 22:37 [PATCH v2 0/2] SDM670 RPMh Clocks Richard Acayan
2022-09-20 22:37 ` [PATCH v2 1/2] dt-bindings: clock: add rpmhcc bindings for sdm670 Richard Acayan
@ 2022-09-20 22:37 ` Richard Acayan
2022-09-21 7:19 ` Neil Armstrong
2022-09-28 3:06 ` [PATCH v2 0/2] SDM670 RPMh Clocks Bjorn Andersson
2 siblings, 1 reply; 5+ messages in thread
From: Richard Acayan @ 2022-09-20 22:37 UTC (permalink / raw)
To: linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Taniya Das,
linux-clk, devicetree, Richard Acayan
The Snapdragon 670 uses the RPMh mailbox for most of the clocks used in
SDM845 but omits two. Add clock data for SDM670 so the driver doesn't fail
to resolve a clock.
Link: https://android.googlesource.com/kernel/msm/+/443bd8d6e2cf54698234c752e6de97b4b8a528bd%5E%21/#F7
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
drivers/clk/qcom/clk-rpmh.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index c07cab6905cb..82d87a0602fe 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -382,6 +382,26 @@ static const struct clk_rpmh_desc clk_rpmh_sdm845 = {
.num_clks = ARRAY_SIZE(sdm845_rpmh_clocks),
};
+static struct clk_hw *sdm670_rpmh_clocks[] = {
+ [RPMH_CXO_CLK] = &sdm845_bi_tcxo.hw,
+ [RPMH_CXO_CLK_A] = &sdm845_bi_tcxo_ao.hw,
+ [RPMH_LN_BB_CLK2] = &sdm845_ln_bb_clk2.hw,
+ [RPMH_LN_BB_CLK2_A] = &sdm845_ln_bb_clk2_ao.hw,
+ [RPMH_LN_BB_CLK3] = &sdm845_ln_bb_clk3.hw,
+ [RPMH_LN_BB_CLK3_A] = &sdm845_ln_bb_clk3_ao.hw,
+ [RPMH_RF_CLK1] = &sdm845_rf_clk1.hw,
+ [RPMH_RF_CLK1_A] = &sdm845_rf_clk1_ao.hw,
+ [RPMH_RF_CLK2] = &sdm845_rf_clk2.hw,
+ [RPMH_RF_CLK2_A] = &sdm845_rf_clk2_ao.hw,
+ [RPMH_IPA_CLK] = &sdm845_ipa.hw,
+ [RPMH_CE_CLK] = &sdm845_ce.hw,
+};
+
+static const struct clk_rpmh_desc clk_rpmh_sdm670 = {
+ .clks = sdm670_rpmh_clocks,
+ .num_clks = ARRAY_SIZE(sdm670_rpmh_clocks),
+};
+
DEFINE_CLK_RPMH_VRM(sdx55, rf_clk1, rf_clk1_ao, "rfclkd1", 1);
DEFINE_CLK_RPMH_VRM(sdx55, rf_clk2, rf_clk2_ao, "rfclkd2", 1);
DEFINE_CLK_RPMH_BCM(sdx55, qpic_clk, "QP0");
@@ -715,6 +735,7 @@ static const struct of_device_id clk_rpmh_match_table[] = {
{ .compatible = "qcom,sc8180x-rpmh-clk", .data = &clk_rpmh_sc8180x},
{ .compatible = "qcom,sc8280xp-rpmh-clk", .data = &clk_rpmh_sc8280xp},
{ .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845},
+ { .compatible = "qcom,sdm670-rpmh-clk", .data = &clk_rpmh_sdm670},
{ .compatible = "qcom,sdx55-rpmh-clk", .data = &clk_rpmh_sdx55},
{ .compatible = "qcom,sdx65-rpmh-clk", .data = &clk_rpmh_sdx65},
{ .compatible = "qcom,sm6350-rpmh-clk", .data = &clk_rpmh_sm6350},
--
2.37.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] clk: qcom: rpmhcc: add sdm670 clocks
2022-09-20 22:37 ` [PATCH v2 2/2] clk: qcom: rpmhcc: add sdm670 clocks Richard Acayan
@ 2022-09-21 7:19 ` Neil Armstrong
0 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2022-09-21 7:19 UTC (permalink / raw)
To: Richard Acayan, linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Taniya Das,
linux-clk, devicetree
On 21/09/2022 00:37, Richard Acayan wrote:
> The Snapdragon 670 uses the RPMh mailbox for most of the clocks used in
> SDM845 but omits two. Add clock data for SDM670 so the driver doesn't fail
> to resolve a clock.
>
> Link: https://android.googlesource.com/kernel/msm/+/443bd8d6e2cf54698234c752e6de97b4b8a528bd%5E%21/#F7
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
> drivers/clk/qcom/clk-rpmh.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index c07cab6905cb..82d87a0602fe 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -382,6 +382,26 @@ static const struct clk_rpmh_desc clk_rpmh_sdm845 = {
> .num_clks = ARRAY_SIZE(sdm845_rpmh_clocks),
> };
>
> +static struct clk_hw *sdm670_rpmh_clocks[] = {
> + [RPMH_CXO_CLK] = &sdm845_bi_tcxo.hw,
> + [RPMH_CXO_CLK_A] = &sdm845_bi_tcxo_ao.hw,
> + [RPMH_LN_BB_CLK2] = &sdm845_ln_bb_clk2.hw,
> + [RPMH_LN_BB_CLK2_A] = &sdm845_ln_bb_clk2_ao.hw,
> + [RPMH_LN_BB_CLK3] = &sdm845_ln_bb_clk3.hw,
> + [RPMH_LN_BB_CLK3_A] = &sdm845_ln_bb_clk3_ao.hw,
> + [RPMH_RF_CLK1] = &sdm845_rf_clk1.hw,
> + [RPMH_RF_CLK1_A] = &sdm845_rf_clk1_ao.hw,
> + [RPMH_RF_CLK2] = &sdm845_rf_clk2.hw,
> + [RPMH_RF_CLK2_A] = &sdm845_rf_clk2_ao.hw,
> + [RPMH_IPA_CLK] = &sdm845_ipa.hw,
> + [RPMH_CE_CLK] = &sdm845_ce.hw,
> +};
> +
> +static const struct clk_rpmh_desc clk_rpmh_sdm670 = {
> + .clks = sdm670_rpmh_clocks,
> + .num_clks = ARRAY_SIZE(sdm670_rpmh_clocks),
> +};
> +
> DEFINE_CLK_RPMH_VRM(sdx55, rf_clk1, rf_clk1_ao, "rfclkd1", 1);
> DEFINE_CLK_RPMH_VRM(sdx55, rf_clk2, rf_clk2_ao, "rfclkd2", 1);
> DEFINE_CLK_RPMH_BCM(sdx55, qpic_clk, "QP0");
> @@ -715,6 +735,7 @@ static const struct of_device_id clk_rpmh_match_table[] = {
> { .compatible = "qcom,sc8180x-rpmh-clk", .data = &clk_rpmh_sc8180x},
> { .compatible = "qcom,sc8280xp-rpmh-clk", .data = &clk_rpmh_sc8280xp},
> { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845},
> + { .compatible = "qcom,sdm670-rpmh-clk", .data = &clk_rpmh_sdm670},
> { .compatible = "qcom,sdx55-rpmh-clk", .data = &clk_rpmh_sdx55},
> { .compatible = "qcom,sdx65-rpmh-clk", .data = &clk_rpmh_sdx65},
> { .compatible = "qcom,sm6350-rpmh-clk", .data = &clk_rpmh_sm6350},
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 0/2] SDM670 RPMh Clocks
2022-09-20 22:37 [PATCH v2 0/2] SDM670 RPMh Clocks Richard Acayan
2022-09-20 22:37 ` [PATCH v2 1/2] dt-bindings: clock: add rpmhcc bindings for sdm670 Richard Acayan
2022-09-20 22:37 ` [PATCH v2 2/2] clk: qcom: rpmhcc: add sdm670 clocks Richard Acayan
@ 2022-09-28 3:06 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2022-09-28 3:06 UTC (permalink / raw)
To: linux-arm-msm, mailingradian
Cc: robh+dt, devicetree, tdas, sboyd, linux-clk, konrad.dybcio,
mturquette, krzysztof.kozlowski+dt, agross
On Tue, 20 Sep 2022 18:37:32 -0400, Richard Acayan wrote:
> Changes since v1:
> - fix broken link
> - accumulate ack tag
>
> This patch series adds clocks controlled by RPMh for Snapdragon 670.
>
> .../devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 +
> drivers/clk/qcom/clk-rpmh.c | 21 +++++++++++++++++++++
> 2 files changed, 22 insertions(+)
>
> [...]
Applied, thanks!
[1/2] dt-bindings: clock: add rpmhcc bindings for sdm670
commit: c6648a402ced29ef826055583a96dcc85d9d3f55
[2/2] clk: qcom: rpmhcc: add sdm670 clocks
commit: 2ded040cedf830c698c04ee79d436bd23014811a
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-28 3:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-20 22:37 [PATCH v2 0/2] SDM670 RPMh Clocks Richard Acayan
2022-09-20 22:37 ` [PATCH v2 1/2] dt-bindings: clock: add rpmhcc bindings for sdm670 Richard Acayan
2022-09-20 22:37 ` [PATCH v2 2/2] clk: qcom: rpmhcc: add sdm670 clocks Richard Acayan
2022-09-21 7:19 ` Neil Armstrong
2022-09-28 3:06 ` [PATCH v2 0/2] SDM670 RPMh Clocks Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox