* [PATCH 4/4] dt-bindings: clock: Add reset controller bindings for Unisoc's UMS512.
@ 2023-12-15 8:10 Zhifeng Tang
2023-12-16 12:26 ` Conor Dooley
0 siblings, 1 reply; 2+ messages in thread
From: Zhifeng Tang @ 2023-12-15 8:10 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Orson Zhai, Baolin Wang, Chunyan Zhang
Cc: linux-clk, devicetree, linux-kernel, Zhifeng Tang, Wenming Wu
Add Reset Controller bindings to clock bindings for Unisoc's UMS512.
Signed-off-by: Zhifeng Tang <zhifeng.tang@unisoc.com>
---
Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml b/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml
index 43d2b6c31357..6b0892d637fe 100644
--- a/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml
+++ b/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml
@@ -34,6 +34,9 @@ properties:
"#clock-cells":
const: 1
+ "#reset-cells":
+ const: 1
+
clocks:
minItems: 1
maxItems: 4
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 4/4] dt-bindings: clock: Add reset controller bindings for Unisoc's UMS512.
2023-12-15 8:10 [PATCH 4/4] dt-bindings: clock: Add reset controller bindings for Unisoc's UMS512 Zhifeng Tang
@ 2023-12-16 12:26 ` Conor Dooley
0 siblings, 0 replies; 2+ messages in thread
From: Conor Dooley @ 2023-12-16 12:26 UTC (permalink / raw)
To: Zhifeng Tang
Cc: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Orson Zhai, Baolin Wang, Chunyan Zhang, linux-clk,
devicetree, linux-kernel, Zhifeng Tang, Wenming Wu
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
On Fri, Dec 15, 2023 at 04:10:03PM +0800, Zhifeng Tang wrote:
> Add Reset Controller bindings to clock bindings for Unisoc's UMS512.
This is what the diff is doing, but there's no justification for why
this is the case. I _assume_ that the clock controller register block
also contains reset bits for some of these peripherals, but the commit
message needs to say that.
Cheers,
Conor.
>
> Signed-off-by: Zhifeng Tang <zhifeng.tang@unisoc.com>
> ---
> Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml b/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml
> index 43d2b6c31357..6b0892d637fe 100644
> --- a/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml
> +++ b/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml
> @@ -34,6 +34,9 @@ properties:
> "#clock-cells":
> const: 1
>
> + "#reset-cells":
> + const: 1
> +
> clocks:
> minItems: 1
> maxItems: 4
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-16 12:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-15 8:10 [PATCH 4/4] dt-bindings: clock: Add reset controller bindings for Unisoc's UMS512 Zhifeng Tang
2023-12-16 12:26 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox