From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Taniya Das <quic_tdas@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
Alex Elder <elder@linaro.org>
Subject: Re: [PATCH 10/16] clk: qcom: smd-rpm: rename some msm8974 active-only clocks
Date: Mon, 5 Dec 2022 12:25:34 +0100 [thread overview]
Message-ID: <46e9fe2a-bd91-d49e-68e5-e555d4112378@linaro.org> (raw)
In-Reply-To: <20221203175808.859067-11-dmitry.baryshkov@linaro.org>
On 03/12/2022 18:58, Dmitry Baryshkov wrote:
> Rename msm8974_diff_a_clk, msm8974_div_a_clk1 and msm8974_div_a_clk2 to
> move the _a suffix to the end of the name. This follows the patter used
> by other active-only clocks and thus makes it possible to simplify clock
> definitions.
> This changes the userspace-visible names for this clocks.
Hopefully this won't break NASA's Mars drone ;)
More seriously, I don't see a usecase where any of these clocks would be
controlled from userspace, not with the mainline kernel at least - we
never know what crazy vendors do downstream..
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> drivers/clk/qcom/clk-smd-rpm.c | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
> index 761a5b0b4b94..cb47d69889fb 100644
> --- a/drivers/clk/qcom/clk-smd-rpm.c
> +++ b/drivers/clk/qcom/clk-smd-rpm.c
> @@ -474,9 +474,9 @@ DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(msm8974, cxo_a0, cxo_a0_a, 4, 19200000);
> DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(msm8974, cxo_a1, cxo_a1_a, 5, 19200000);
> DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(msm8974, cxo_a2, cxo_a2_a, 6, 19200000);
>
> -DEFINE_CLK_SMD_RPM_XO_BUFFER(msm8974, diff_clk, diff_a_clk, 7, 19200000);
> -DEFINE_CLK_SMD_RPM_XO_BUFFER(msm8974, div_clk1, div_a_clk1, 11, 19200000);
> -DEFINE_CLK_SMD_RPM_XO_BUFFER(msm8974, div_clk2, div_a_clk2, 12, 19200000);
> +DEFINE_CLK_SMD_RPM_XO_BUFFER(msm8974, diff_clk, diff_clk_a, 7, 19200000);
> +DEFINE_CLK_SMD_RPM_XO_BUFFER(msm8974, div_clk1, div_clk1_a, 11, 19200000);
> +DEFINE_CLK_SMD_RPM_XO_BUFFER(msm8974, div_clk2, div_clk2_a, 12, 19200000);
> DEFINE_CLK_SMD_RPM_XO_BUFFER(msm8992, div_clk3, div_clk3_a, 13, 19200000);
>
> static struct clk_smd_rpm *msm8909_clks[] = {
> @@ -607,11 +607,11 @@ static struct clk_smd_rpm *msm8974_clks[] = {
> [RPM_SMD_CXO_A2] = &msm8974_cxo_a2,
> [RPM_SMD_CXO_A2_A] = &msm8974_cxo_a2_a,
> [RPM_SMD_DIFF_CLK] = &msm8974_diff_clk,
> - [RPM_SMD_DIFF_A_CLK] = &msm8974_diff_a_clk,
> + [RPM_SMD_DIFF_A_CLK] = &msm8974_diff_clk_a,
> [RPM_SMD_DIV_CLK1] = &msm8974_div_clk1,
> - [RPM_SMD_DIV_A_CLK1] = &msm8974_div_a_clk1,
> + [RPM_SMD_DIV_A_CLK1] = &msm8974_div_clk1_a,
> [RPM_SMD_DIV_CLK2] = &msm8974_div_clk2,
> - [RPM_SMD_DIV_A_CLK2] = &msm8974_div_a_clk2,
> + [RPM_SMD_DIV_A_CLK2] = &msm8974_div_clk2_a,
> [RPM_SMD_CXO_D0_PIN] = &msm8974_cxo_d0_pin,
> [RPM_SMD_CXO_D0_A_PIN] = &msm8974_cxo_d0_a_pin,
> [RPM_SMD_CXO_D1_PIN] = &msm8974_cxo_d1_pin,
> @@ -653,7 +653,7 @@ static struct clk_smd_rpm *msm8976_clks[] = {
> [RPM_SMD_BB_CLK2_PIN] = &msm8916_bb_clk2_pin,
> [RPM_SMD_BB_CLK2_A_PIN] = &msm8916_bb_clk2_a_pin,
> [RPM_SMD_DIV_CLK2] = &msm8974_div_clk2,
> - [RPM_SMD_DIV_A_CLK2] = &msm8974_div_a_clk2,
> + [RPM_SMD_DIV_A_CLK2] = &msm8974_div_clk2_a,
> [RPM_SMD_IPA_CLK] = &msm8976_ipa_clk,
> [RPM_SMD_IPA_A_CLK] = &msm8976_ipa_a_clk,
> };
> @@ -687,9 +687,9 @@ static struct clk_smd_rpm *msm8992_clks[] = {
> [RPM_SMD_BB_CLK2_PIN] = &msm8916_bb_clk2_pin,
> [RPM_SMD_BB_CLK2_A_PIN] = &msm8916_bb_clk2_a_pin,
> [RPM_SMD_DIV_CLK1] = &msm8974_div_clk1,
> - [RPM_SMD_DIV_A_CLK1] = &msm8974_div_a_clk1,
> + [RPM_SMD_DIV_A_CLK1] = &msm8974_div_clk1_a,
> [RPM_SMD_DIV_CLK2] = &msm8974_div_clk2,
> - [RPM_SMD_DIV_A_CLK2] = &msm8974_div_a_clk2,
> + [RPM_SMD_DIV_A_CLK2] = &msm8974_div_clk2_a,
> [RPM_SMD_DIV_CLK3] = &msm8992_div_clk3,
> [RPM_SMD_DIV_A_CLK3] = &msm8992_div_clk3_a,
> [RPM_SMD_IPA_CLK] = &msm8976_ipa_clk,
> @@ -745,9 +745,9 @@ static struct clk_smd_rpm *msm8994_clks[] = {
> [RPM_SMD_BB_CLK2_PIN] = &msm8916_bb_clk2_pin,
> [RPM_SMD_BB_CLK2_A_PIN] = &msm8916_bb_clk2_a_pin,
> [RPM_SMD_DIV_CLK1] = &msm8974_div_clk1,
> - [RPM_SMD_DIV_A_CLK1] = &msm8974_div_a_clk1,
> + [RPM_SMD_DIV_A_CLK1] = &msm8974_div_clk1_a,
> [RPM_SMD_DIV_CLK2] = &msm8974_div_clk2,
> - [RPM_SMD_DIV_A_CLK2] = &msm8974_div_a_clk2,
> + [RPM_SMD_DIV_A_CLK2] = &msm8974_div_clk2_a,
> [RPM_SMD_DIV_CLK3] = &msm8992_div_clk3,
> [RPM_SMD_DIV_A_CLK3] = &msm8992_div_clk3_a,
> [RPM_SMD_IPA_CLK] = &msm8976_ipa_clk,
> @@ -813,9 +813,9 @@ static struct clk_smd_rpm *msm8996_clks[] = {
> [RPM_SMD_LN_BB_CLK] = &qcs404_ln_bb_clk,
> [RPM_SMD_LN_BB_A_CLK] = &qcs404_ln_bb_clk_a,
> [RPM_SMD_DIV_CLK1] = &msm8974_div_clk1,
> - [RPM_SMD_DIV_A_CLK1] = &msm8974_div_a_clk1,
> + [RPM_SMD_DIV_A_CLK1] = &msm8974_div_clk1_a,
> [RPM_SMD_DIV_CLK2] = &msm8974_div_clk2,
> - [RPM_SMD_DIV_A_CLK2] = &msm8974_div_a_clk2,
> + [RPM_SMD_DIV_A_CLK2] = &msm8974_div_clk2_a,
> [RPM_SMD_DIV_CLK3] = &msm8992_div_clk3,
> [RPM_SMD_DIV_A_CLK3] = &msm8992_div_clk3_a,
> [RPM_SMD_BB_CLK1_PIN] = &msm8916_bb_clk1_pin,
> @@ -875,9 +875,9 @@ static struct clk_smd_rpm *msm8998_clks[] = {
> [RPM_SMD_CE1_CLK] = &msm8992_ce1_clk,
> [RPM_SMD_CE1_A_CLK] = &msm8992_ce1_a_clk,
> [RPM_SMD_DIV_CLK1] = &msm8974_div_clk1,
> - [RPM_SMD_DIV_A_CLK1] = &msm8974_div_a_clk1,
> + [RPM_SMD_DIV_A_CLK1] = &msm8974_div_clk1_a,
> [RPM_SMD_DIV_CLK2] = &msm8974_div_clk2,
> - [RPM_SMD_DIV_A_CLK2] = &msm8974_div_a_clk2,
> + [RPM_SMD_DIV_A_CLK2] = &msm8974_div_clk2_a,
> [RPM_SMD_DIV_CLK3] = &msm8992_div_clk3,
> [RPM_SMD_DIV_A_CLK3] = &msm8992_div_clk3_a,
> [RPM_SMD_IPA_CLK] = &msm8976_ipa_clk,
> @@ -945,7 +945,7 @@ static struct clk_smd_rpm *sdm660_clks[] = {
> [RPM_SMD_RF_CLK1] = &msm8916_rf_clk1,
> [RPM_SMD_RF_CLK1_A] = &msm8916_rf_clk1_a,
> [RPM_SMD_DIV_CLK1] = &msm8974_div_clk1,
> - [RPM_SMD_DIV_A_CLK1] = &msm8974_div_a_clk1,
> + [RPM_SMD_DIV_A_CLK1] = &msm8974_div_clk1_a,
> [RPM_SMD_LN_BB_CLK] = &msm8998_ln_bb_clk1,
> [RPM_SMD_LN_BB_A_CLK] = &msm8998_ln_bb_clk1_a,
> [RPM_SMD_LN_BB_CLK2] = &msm8998_ln_bb_clk2,
> @@ -1013,7 +1013,7 @@ static struct clk_smd_rpm *msm8953_clks[] = {
> [RPM_SMD_RF_CLK3] = &qcs404_ln_bb_clk,
> [RPM_SMD_RF_CLK3_A] = &qcs404_ln_bb_clk_a,
> [RPM_SMD_DIV_CLK2] = &msm8974_div_clk2,
> - [RPM_SMD_DIV_A_CLK2] = &msm8974_div_a_clk2,
> + [RPM_SMD_DIV_A_CLK2] = &msm8974_div_clk2_a,
> [RPM_SMD_BB_CLK1_PIN] = &msm8916_bb_clk1_pin,
> [RPM_SMD_BB_CLK1_A_PIN] = &msm8916_bb_clk1_a_pin,
> [RPM_SMD_BB_CLK2_PIN] = &msm8916_bb_clk2_pin,
next prev parent reply other threads:[~2022-12-05 11:25 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 17:57 [PATCH 00/16] clk: qcom: smd-rpm: drop platform names Dmitry Baryshkov
2022-12-03 17:57 ` [PATCH 01/16] clk: qcom: smd-rpm: remove duplication between sm6375 and sm6125 clocks Dmitry Baryshkov
2022-12-05 11:13 ` Konrad Dybcio
2022-12-05 17:04 ` Alex Elder
2022-12-03 17:57 ` [PATCH 02/16] clk: qcom: smd-rpm: enable pin-controlled ln_bb_clk clocks on qcs404 Dmitry Baryshkov
2022-12-05 11:14 ` Konrad Dybcio
2022-12-05 17:04 ` Alex Elder
2022-12-03 17:57 ` [PATCH 03/16] clk: qcom: smd-rpm: remove duplication between qcs404 and qcm2290 clocks Dmitry Baryshkov
2022-12-05 11:15 ` Konrad Dybcio
2022-12-05 17:04 ` Alex Elder
2022-12-06 23:18 ` Dmitry Baryshkov
2022-12-03 17:57 ` [PATCH 04/16] clk: qcom: smd-rpm: add missing ln_bb_clkN clocks Dmitry Baryshkov
2022-12-05 11:17 ` Konrad Dybcio
2022-12-05 17:04 ` Alex Elder
2022-12-06 23:19 ` Dmitry Baryshkov
2022-12-03 17:57 ` [PATCH 05/16] clk: qcom: smd-rpm: use msm8998_ln_bb_clk2 for qcm2290 SoC Dmitry Baryshkov
2022-12-05 11:18 ` Konrad Dybcio
2022-12-05 17:04 ` Alex Elder
2022-12-03 17:57 ` [PATCH 06/16] clk: qcom: smd-rpm: rename msm8992_ln_bb_* clocks to qcs404_ln_bb_* Dmitry Baryshkov
2022-12-05 11:19 ` Konrad Dybcio
2022-12-05 17:04 ` Alex Elder
2022-12-06 23:26 ` Dmitry Baryshkov
2022-12-06 23:26 ` Dmitry Baryshkov
2022-12-03 17:57 ` [PATCH 07/16] clk: qcom: smd-rpm: add XO_BUFFER clock for each XO_BUFFER_PINCTRL clock Dmitry Baryshkov
2022-12-05 11:20 ` Konrad Dybcio
2022-12-05 17:04 ` Alex Elder
2022-12-03 17:58 ` [PATCH 08/16] clk: qcom: smd-rpm: drop the rpm_status_id field Dmitry Baryshkov
2022-12-05 11:21 ` Konrad Dybcio
2022-12-05 17:04 ` Alex Elder
2022-12-05 21:38 ` Dmitry Baryshkov
2022-12-05 21:54 ` Alex Elder
2022-12-03 17:58 ` [PATCH 09/16] clk: qcom: smd-rpm: move clock definitions together Dmitry Baryshkov
2022-12-05 11:23 ` Konrad Dybcio
2022-12-05 17:04 ` Alex Elder
2022-12-03 17:58 ` [PATCH 10/16] clk: qcom: smd-rpm: rename some msm8974 active-only clocks Dmitry Baryshkov
2022-12-05 11:25 ` Konrad Dybcio [this message]
2022-12-05 17:05 ` Alex Elder
2022-12-05 21:40 ` Dmitry Baryshkov
2022-12-03 17:58 ` [PATCH 11/16] clk: qcom: smd-rpm: simplify XO_BUFFER clocks definitions Dmitry Baryshkov
2022-12-05 11:27 ` Konrad Dybcio
2022-12-05 17:05 ` Alex Elder
2022-12-06 23:30 ` Dmitry Baryshkov
2022-12-03 17:58 ` [PATCH 12/16] clk: qcom: smd-rpm: simplify SMD_RPM/_BRANCH/_QDSS clock definitions Dmitry Baryshkov
2022-12-05 11:28 ` Konrad Dybcio
2022-12-05 17:05 ` Alex Elder
2022-12-03 17:58 ` [PATCH 13/16] clk: qcom: smd-rpm: rename SMD_RPM_BRANCH clock symbols Dmitry Baryshkov
2022-12-05 11:30 ` Konrad Dybcio
2022-12-05 17:05 ` Alex Elder
2022-12-03 17:58 ` [PATCH 14/16] clk: qcom: smd-rpm: rename the qcm2290 rf_clk3 clocks Dmitry Baryshkov
2022-12-05 11:31 ` Konrad Dybcio
2022-12-05 17:05 ` Alex Elder
2022-12-03 17:58 ` [PATCH 15/16] clk: qcom: smd-rpm: rename SMD_RPM_BUS clocks Dmitry Baryshkov
2022-12-05 11:34 ` Konrad Dybcio
2022-12-05 17:05 ` Alex Elder
2022-12-05 21:42 ` Dmitry Baryshkov
2022-12-03 17:58 ` [PATCH 16/16] clk: qcom: smd-rpm: remove usage of platform name Dmitry Baryshkov
2022-12-05 11:35 ` Konrad Dybcio
2022-12-05 17:05 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46e9fe2a-bd91-d49e-68e5-e555d4112378@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=elder@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox