public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Barnabás Czémán" <barnabas.czeman@mainlining.org>,
	"Taniya Das" <taniya.das@oss.qualcomm.com>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Adam Skladowski" <a_skl39@protonmail.com>,
	"Sireesh Kodali" <sireeshkodali@protonmail.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lanik <daniilt971@gmail.com>
Subject: Re: [PATCH 2/4] clk: qcom: gcc: Add support for Global Clock controller found on MSM8940
Date: Mon, 17 Nov 2025 13:17:48 +0100	[thread overview]
Message-ID: <8faa0c8e-6f21-4025-bbdf-d4ec18eb7628@oss.qualcomm.com> (raw)
In-Reply-To: <5C7A10CF-910E-448A-8BFD-F2A46782D3B9@mainlining.org>

On 11/17/25 9:51 AM, Barnabás Czémán wrote:
> 
> 
> On 17 November 2025 09:03:53 CET, Taniya Das <taniya.das@oss.qualcomm.com> wrote:
>>
>>
>> On 11/17/2025 3:05 AM, Barnabás Czémán wrote:
>>>  
>>> +static struct clk_branch gcc_ipa_tbu_clk = {
>>> +	.halt_reg = 0x120a0,
>>> +	.halt_check = BRANCH_VOTED,
>>> +	.clkr = {
>>> +		.enable_reg = 0x4500c,
>>> +		.enable_mask = BIT(16),
>>> +		.hw.init = &(struct clk_init_data){
>>> +			.name = "gcc_ipa_tbu_clk",
>>> +			.ops = &clk_branch2_ops,
>>> +		},
>>> +	},
>>> +};
>>> +
>>
>> Is the TBU clock used on 8940 by a SMMU driver?
> As far as I know no MSM8940 is using same smmu driver and bindings like MSM8937.

On msm8939, the clock needed to be turned on for the GPU SMMU

See 5bc1cf1466f6 ("iommu/qcom: add optional 'tbu' clock for TLB invalidate")

Konrad

  reply	other threads:[~2025-11-17 12:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-16 21:35 [PATCH 0/4] Add Global Clock Controller for MSM8940 and SDM439 Barnabás Czémán
2025-11-16 21:35 ` [PATCH 1/4] dt-bindings: clock: qcom: Add MSM8940 Global Clock Controller Barnabás Czémán
2025-11-17  7:17   ` Krzysztof Kozlowski
2025-11-16 21:35 ` [PATCH 2/4] clk: qcom: gcc: Add support for Global Clock controller found on MSM8940 Barnabás Czémán
2025-11-17  8:03   ` Taniya Das
2025-11-17  8:51     ` Barnabás Czémán
2025-11-17 12:17       ` Konrad Dybcio [this message]
2025-11-17 14:02         ` barnabas.czeman
2025-11-17 14:17           ` Konrad Dybcio
2025-11-30 14:50             ` barnabas.czeman
2025-12-01 12:26               ` Konrad Dybcio
2025-12-02 13:40                 ` barnabas.czeman
2025-12-02 14:36                   ` Konrad Dybcio
2025-11-16 21:35 ` [PATCH 3/4] dt-bindings: clock: qcom: Add SDM439 Global Clock Controller Barnabás Czémán
2025-11-17  7:18   ` Krzysztof Kozlowski
2025-11-16 21:35 ` [PATCH 4/4] clk: qcom: gcc: Add support for Global Clock controller found on SDM439 Barnabás Czémán
2025-11-17 12:40   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8faa0c8e-6f21-4025-bbdf-d4ec18eb7628@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=a_skl39@protonmail.com \
    --cc=andersson@kernel.org \
    --cc=barnabas.czeman@mainlining.org \
    --cc=conor+dt@kernel.org \
    --cc=daniilt971@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sireeshkodali@protonmail.com \
    --cc=taniya.das@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox