From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Barnabás Czémán" <barnabas.czeman@mainlining.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Adam Skladowski" <a_skl39@protonmail.com>,
"Sireesh Kodali" <sireeshkodali@protonmail.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Lanik <daniilt971@gmail.com>
Subject: Re: [PATCH 4/4] clk: qcom: gcc: Add support for Global Clock controller found on SDM439
Date: Mon, 17 Nov 2025 13:40:29 +0100 [thread overview]
Message-ID: <ee2123ee-c500-4db6-bc9a-2e5fcbeb8ae6@oss.qualcomm.com> (raw)
In-Reply-To: <20251116-gcc-msm8940-sdm439-v1-4-7c0dc89c922c@mainlining.org>
On 11/16/25 10:35 PM, Barnabás Czémán wrote:
> From: Lanik <daniilt971@gmail.com>
>
> Modify existing MSM8917 driver to support SDM439 SoC. SDM439 SoC has the
> same changes as MSM8937 SoC, but with different gpll3 vco rate and
> different GFX3D clock frequency table.
>
> Signed-off-by: Lanik <daniilt971@gmail.com>
This doesn't seem like a proper full name, please fix up your git
config
[...]
> +static void sdm439_clock_override(void)
> +{
> + /*
> + * Set below clocks for use specific sdm439 parent map.
> + */
> + vcodec0_clk_src.parent_map = gcc_cpp_map;
> + vcodec0_clk_src.clkr.hw.init = &vcodec0_clk_src_init_msm8937;
> +
> + /*
> + * Set below clocks for use specific sdm439 freq table.
> + */
These comments are rather self-explanatory, you can drop them
Konrad
prev parent reply other threads:[~2025-11-17 12:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-16 21:35 [PATCH 0/4] Add Global Clock Controller for MSM8940 and SDM439 Barnabás Czémán
2025-11-16 21:35 ` [PATCH 1/4] dt-bindings: clock: qcom: Add MSM8940 Global Clock Controller Barnabás Czémán
2025-11-17 7:17 ` Krzysztof Kozlowski
2025-11-16 21:35 ` [PATCH 2/4] clk: qcom: gcc: Add support for Global Clock controller found on MSM8940 Barnabás Czémán
2025-11-17 8:03 ` Taniya Das
2025-11-17 8:51 ` Barnabás Czémán
2025-11-17 12:17 ` Konrad Dybcio
2025-11-17 14:02 ` barnabas.czeman
2025-11-17 14:17 ` Konrad Dybcio
2025-11-30 14:50 ` barnabas.czeman
2025-12-01 12:26 ` Konrad Dybcio
2025-12-02 13:40 ` barnabas.czeman
2025-12-02 14:36 ` Konrad Dybcio
2025-11-16 21:35 ` [PATCH 3/4] dt-bindings: clock: qcom: Add SDM439 Global Clock Controller Barnabás Czémán
2025-11-17 7:18 ` Krzysztof Kozlowski
2025-11-16 21:35 ` [PATCH 4/4] clk: qcom: gcc: Add support for Global Clock controller found on SDM439 Barnabás Czémán
2025-11-17 12:40 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee2123ee-c500-4db6-bc9a-2e5fcbeb8ae6@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=a_skl39@protonmail.com \
--cc=andersson@kernel.org \
--cc=barnabas.czeman@mainlining.org \
--cc=conor+dt@kernel.org \
--cc=daniilt971@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sireeshkodali@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox