* [PATCH 1/5] clk: qcom: dispcc-glymur: Fix DSI byte clock rate setting
2026-03-04 13:48 [PATCH 0/5] DSI byte clock setting fixup Konrad Dybcio
@ 2026-03-04 13:48 ` Konrad Dybcio
2026-03-04 14:26 ` Dmitry Baryshkov
2026-03-05 6:12 ` Taniya Das
2026-03-04 13:48 ` [PATCH 2/5] clk: qcom: dispcc-kaanapali: " Konrad Dybcio
` (4 subsequent siblings)
5 siblings, 2 replies; 17+ messages in thread
From: Konrad Dybcio @ 2026-03-04 13:48 UTC (permalink / raw)
To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Taniya Das,
Dmitry Baryshkov, Luca Weiss, Dmitry Baryshkov, Ajit Pandey,
Taniya Das, Jagadeesh Kona
Cc: linux-arm-msm, linux-clk, linux-kernel, Konrad Dybcio
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
The clock tree for byte_clk_src is as follows:
┌──────byte0_clk_src─────┐
│ │
byte0_clk byte0_div_clk_src
│
byte0_intf_clk
If both of its direct children have CLK_SET_RATE_PARENT with different
requests, byte0_clk_src (and its parent) will be reconfigured. In this
case, byte0_intf should strictly follow the rate of byte0_clk (with
some adjustments based on PHY mode).
Remove CLK_SET_RATE_PARENT from byte0_div_clk_src to avoid this issue.
Fixes: b4d15211c408 ("clk: qcom: dispcc-glymur: Add support for Display Clock Controller")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
drivers/clk/qcom/dispcc-glymur.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/clk/qcom/dispcc-glymur.c b/drivers/clk/qcom/dispcc-glymur.c
index 94053452e871..a8c3cbf591d1 100644
--- a/drivers/clk/qcom/dispcc-glymur.c
+++ b/drivers/clk/qcom/dispcc-glymur.c
@@ -747,7 +747,6 @@ static struct clk_regmap_div disp_cc_mdss_byte0_div_clk_src = {
&disp_cc_mdss_byte0_clk_src.clkr.hw,
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
.ops = &clk_regmap_div_ops,
},
};
@@ -762,7 +761,6 @@ static struct clk_regmap_div disp_cc_mdss_byte1_div_clk_src = {
&disp_cc_mdss_byte1_clk_src.clkr.hw,
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
.ops = &clk_regmap_div_ops,
},
};
--
2.53.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 1/5] clk: qcom: dispcc-glymur: Fix DSI byte clock rate setting
2026-03-04 13:48 ` [PATCH 1/5] clk: qcom: dispcc-glymur: Fix DSI byte clock rate setting Konrad Dybcio
@ 2026-03-04 14:26 ` Dmitry Baryshkov
2026-03-05 6:12 ` Taniya Das
1 sibling, 0 replies; 17+ messages in thread
From: Dmitry Baryshkov @ 2026-03-04 14:26 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Michael Turquette, Stephen Boyd, Taniya Das,
Luca Weiss, Dmitry Baryshkov, Ajit Pandey, Taniya Das,
Jagadeesh Kona, linux-arm-msm, linux-clk, linux-kernel,
Konrad Dybcio
On Wed, Mar 04, 2026 at 02:48:27PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> The clock tree for byte_clk_src is as follows:
>
> ┌──────byte0_clk_src─────┐
> │ │
> byte0_clk byte0_div_clk_src
> │
> byte0_intf_clk
>
> If both of its direct children have CLK_SET_RATE_PARENT with different
> requests, byte0_clk_src (and its parent) will be reconfigured. In this
> case, byte0_intf should strictly follow the rate of byte0_clk (with
> some adjustments based on PHY mode).
>
> Remove CLK_SET_RATE_PARENT from byte0_div_clk_src to avoid this issue.
>
> Fixes: b4d15211c408 ("clk: qcom: dispcc-glymur: Add support for Display Clock Controller")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> drivers/clk/qcom/dispcc-glymur.c | 2 --
> 1 file changed, 2 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 1/5] clk: qcom: dispcc-glymur: Fix DSI byte clock rate setting
2026-03-04 13:48 ` [PATCH 1/5] clk: qcom: dispcc-glymur: Fix DSI byte clock rate setting Konrad Dybcio
2026-03-04 14:26 ` Dmitry Baryshkov
@ 2026-03-05 6:12 ` Taniya Das
1 sibling, 0 replies; 17+ messages in thread
From: Taniya Das @ 2026-03-05 6:12 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Michael Turquette, Stephen Boyd,
Dmitry Baryshkov, Luca Weiss, Dmitry Baryshkov, Ajit Pandey,
Taniya Das, Jagadeesh Kona
Cc: linux-arm-msm, linux-clk, linux-kernel, Konrad Dybcio
> diff --git a/drivers/clk/qcom/dispcc-glymur.c b/drivers/clk/qcom/dispcc-glymur.c
> index 94053452e871..a8c3cbf591d1 100644
> --- a/drivers/clk/qcom/dispcc-glymur.c
> +++ b/drivers/clk/qcom/dispcc-glymur.c
> @@ -747,7 +747,6 @@ static struct clk_regmap_div disp_cc_mdss_byte0_div_clk_src = {
> &disp_cc_mdss_byte0_clk_src.clkr.hw,
> },
> .num_parents = 1,
> - .flags = CLK_SET_RATE_PARENT,
> .ops = &clk_regmap_div_ops,
> },
> };
> @@ -762,7 +761,6 @@ static struct clk_regmap_div disp_cc_mdss_byte1_div_clk_src = {
> &disp_cc_mdss_byte1_clk_src.clkr.hw,
> },
> .num_parents = 1,
> - .flags = CLK_SET_RATE_PARENT,
> .ops = &clk_regmap_div_ops,
> },
> };
>
Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>
--
Thanks,
Taniya Das
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 2/5] clk: qcom: dispcc-kaanapali: Fix DSI byte clock rate setting
2026-03-04 13:48 [PATCH 0/5] DSI byte clock setting fixup Konrad Dybcio
2026-03-04 13:48 ` [PATCH 1/5] clk: qcom: dispcc-glymur: Fix DSI byte clock rate setting Konrad Dybcio
@ 2026-03-04 13:48 ` Konrad Dybcio
2026-03-04 14:27 ` Dmitry Baryshkov
2026-03-05 6:13 ` Taniya Das
2026-03-04 13:48 ` [PATCH 3/5] clk: qcom: dispcc-milos: " Konrad Dybcio
` (3 subsequent siblings)
5 siblings, 2 replies; 17+ messages in thread
From: Konrad Dybcio @ 2026-03-04 13:48 UTC (permalink / raw)
To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Taniya Das,
Dmitry Baryshkov, Luca Weiss, Dmitry Baryshkov, Ajit Pandey,
Taniya Das, Jagadeesh Kona
Cc: linux-arm-msm, linux-clk, linux-kernel, Konrad Dybcio
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
The clock tree for byte_clk_src is as follows:
┌──────byte0_clk_src─────┐
│ │
byte0_clk byte0_div_clk_src
│
byte0_intf_clk
If both of its direct children have CLK_SET_RATE_PARENT with different
requests, byte0_clk_src (and its parent) will be reconfigured. In this
case, byte0_intf should strictly follow the rate of byte0_clk (with
some adjustments based on PHY mode).
Remove CLK_SET_RATE_PARENT from byte0_div_clk_src to avoid this issue.
Fixes: 6c6750b7061c ("clk: qcom: dispcc: Add support for display clock controller Kaanapali")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
drivers/clk/qcom/dispcc-kaanapali.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/clk/qcom/dispcc-kaanapali.c b/drivers/clk/qcom/dispcc-kaanapali.c
index baae2ec1f72a..c1578cd07041 100644
--- a/drivers/clk/qcom/dispcc-kaanapali.c
+++ b/drivers/clk/qcom/dispcc-kaanapali.c
@@ -800,7 +800,6 @@ static struct clk_regmap_div disp_cc_mdss_byte0_div_clk_src = {
&disp_cc_mdss_byte0_clk_src.clkr.hw,
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
.ops = &clk_regmap_div_ops,
},
};
@@ -815,7 +814,6 @@ static struct clk_regmap_div disp_cc_mdss_byte1_div_clk_src = {
&disp_cc_mdss_byte1_clk_src.clkr.hw,
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
.ops = &clk_regmap_div_ops,
},
};
--
2.53.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 2/5] clk: qcom: dispcc-kaanapali: Fix DSI byte clock rate setting
2026-03-04 13:48 ` [PATCH 2/5] clk: qcom: dispcc-kaanapali: " Konrad Dybcio
@ 2026-03-04 14:27 ` Dmitry Baryshkov
2026-03-05 6:13 ` Taniya Das
1 sibling, 0 replies; 17+ messages in thread
From: Dmitry Baryshkov @ 2026-03-04 14:27 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Michael Turquette, Stephen Boyd, Taniya Das,
Luca Weiss, Dmitry Baryshkov, Ajit Pandey, Taniya Das,
Jagadeesh Kona, linux-arm-msm, linux-clk, linux-kernel,
Konrad Dybcio
On Wed, Mar 04, 2026 at 02:48:28PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> The clock tree for byte_clk_src is as follows:
>
> ┌──────byte0_clk_src─────┐
> │ │
> byte0_clk byte0_div_clk_src
> │
> byte0_intf_clk
>
> If both of its direct children have CLK_SET_RATE_PARENT with different
> requests, byte0_clk_src (and its parent) will be reconfigured. In this
> case, byte0_intf should strictly follow the rate of byte0_clk (with
> some adjustments based on PHY mode).
>
> Remove CLK_SET_RATE_PARENT from byte0_div_clk_src to avoid this issue.
>
> Fixes: 6c6750b7061c ("clk: qcom: dispcc: Add support for display clock controller Kaanapali")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> drivers/clk/qcom/dispcc-kaanapali.c | 2 --
> 1 file changed, 2 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 2/5] clk: qcom: dispcc-kaanapali: Fix DSI byte clock rate setting
2026-03-04 13:48 ` [PATCH 2/5] clk: qcom: dispcc-kaanapali: " Konrad Dybcio
2026-03-04 14:27 ` Dmitry Baryshkov
@ 2026-03-05 6:13 ` Taniya Das
1 sibling, 0 replies; 17+ messages in thread
From: Taniya Das @ 2026-03-05 6:13 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Michael Turquette, Stephen Boyd,
Dmitry Baryshkov, Luca Weiss, Dmitry Baryshkov, Ajit Pandey,
Taniya Das, Jagadeesh Kona
Cc: linux-arm-msm, linux-clk, linux-kernel, Konrad Dybcio
On 3/4/2026 7:18 PM, Konrad Dybcio wrote:
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/dispcc-kaanapali.c b/drivers/clk/qcom/dispcc-kaanapali.c
> index baae2ec1f72a..c1578cd07041 100644
> --- a/drivers/clk/qcom/dispcc-kaanapali.c
> +++ b/drivers/clk/qcom/dispcc-kaanapali.c
> @@ -800,7 +800,6 @@ static struct clk_regmap_div disp_cc_mdss_byte0_div_clk_src = {
> &disp_cc_mdss_byte0_clk_src.clkr.hw,
> },
> .num_parents = 1,
> - .flags = CLK_SET_RATE_PARENT,
> .ops = &clk_regmap_div_ops,
> },
> };
> @@ -815,7 +814,6 @@ static struct clk_regmap_div disp_cc_mdss_byte1_div_clk_src = {
> &disp_cc_mdss_byte1_clk_src.clkr.hw,
> },
> .num_parents = 1,
> - .flags = CLK_SET_RATE_PARENT,
> .ops = &clk_regmap_div_ops,
> },
> };
Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>
--
Thanks,
Taniya Das
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 3/5] clk: qcom: dispcc-milos: Fix DSI byte clock rate setting
2026-03-04 13:48 [PATCH 0/5] DSI byte clock setting fixup Konrad Dybcio
2026-03-04 13:48 ` [PATCH 1/5] clk: qcom: dispcc-glymur: Fix DSI byte clock rate setting Konrad Dybcio
2026-03-04 13:48 ` [PATCH 2/5] clk: qcom: dispcc-kaanapali: " Konrad Dybcio
@ 2026-03-04 13:48 ` Konrad Dybcio
2026-03-04 14:27 ` Dmitry Baryshkov
2026-03-05 6:16 ` Taniya Das
2026-03-04 13:48 ` [PATCH 4/5] clk: qcom: dispcc-sm4450: " Konrad Dybcio
` (2 subsequent siblings)
5 siblings, 2 replies; 17+ messages in thread
From: Konrad Dybcio @ 2026-03-04 13:48 UTC (permalink / raw)
To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Taniya Das,
Dmitry Baryshkov, Luca Weiss, Dmitry Baryshkov, Ajit Pandey,
Taniya Das, Jagadeesh Kona
Cc: linux-arm-msm, linux-clk, linux-kernel, Konrad Dybcio
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
The clock tree for byte_clk_src is as follows:
┌──────byte0_clk_src─────┐
│ │
byte0_clk byte0_div_clk_src
│
byte0_intf_clk
If both of its direct children have CLK_SET_RATE_PARENT with different
requests, byte0_clk_src (and its parent) will be reconfigured. In this
case, byte0_intf should strictly follow the rate of byte0_clk (with
some adjustments based on PHY mode).
Remove CLK_SET_RATE_PARENT from byte0_div_clk_src to avoid this issue.
Fixes: f40b5217dce1 ("clk: qcom: Add Display Clock controller (DISPCC) driver for Milos")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
drivers/clk/qcom/dispcc-milos.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/qcom/dispcc-milos.c b/drivers/clk/qcom/dispcc-milos.c
index 95b6dd89d9ae..339cb1c63ba7 100644
--- a/drivers/clk/qcom/dispcc-milos.c
+++ b/drivers/clk/qcom/dispcc-milos.c
@@ -394,7 +394,6 @@ static struct clk_regmap_div disp_cc_mdss_byte0_div_clk_src = {
&disp_cc_mdss_byte0_clk_src.clkr.hw,
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
.ops = &clk_regmap_div_ops,
},
};
--
2.53.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 3/5] clk: qcom: dispcc-milos: Fix DSI byte clock rate setting
2026-03-04 13:48 ` [PATCH 3/5] clk: qcom: dispcc-milos: " Konrad Dybcio
@ 2026-03-04 14:27 ` Dmitry Baryshkov
2026-03-05 6:16 ` Taniya Das
1 sibling, 0 replies; 17+ messages in thread
From: Dmitry Baryshkov @ 2026-03-04 14:27 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Michael Turquette, Stephen Boyd, Taniya Das,
Luca Weiss, Dmitry Baryshkov, Ajit Pandey, Taniya Das,
Jagadeesh Kona, linux-arm-msm, linux-clk, linux-kernel,
Konrad Dybcio
On Wed, Mar 04, 2026 at 02:48:29PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> The clock tree for byte_clk_src is as follows:
>
> ┌──────byte0_clk_src─────┐
> │ │
> byte0_clk byte0_div_clk_src
> │
> byte0_intf_clk
>
> If both of its direct children have CLK_SET_RATE_PARENT with different
> requests, byte0_clk_src (and its parent) will be reconfigured. In this
> case, byte0_intf should strictly follow the rate of byte0_clk (with
> some adjustments based on PHY mode).
>
> Remove CLK_SET_RATE_PARENT from byte0_div_clk_src to avoid this issue.
>
> Fixes: f40b5217dce1 ("clk: qcom: Add Display Clock controller (DISPCC) driver for Milos")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> drivers/clk/qcom/dispcc-milos.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 3/5] clk: qcom: dispcc-milos: Fix DSI byte clock rate setting
2026-03-04 13:48 ` [PATCH 3/5] clk: qcom: dispcc-milos: " Konrad Dybcio
2026-03-04 14:27 ` Dmitry Baryshkov
@ 2026-03-05 6:16 ` Taniya Das
1 sibling, 0 replies; 17+ messages in thread
From: Taniya Das @ 2026-03-05 6:16 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Michael Turquette, Stephen Boyd,
Dmitry Baryshkov, Luca Weiss, Dmitry Baryshkov, Ajit Pandey,
Taniya Das, Jagadeesh Kona
Cc: linux-arm-msm, linux-clk, linux-kernel, Konrad Dybcio
On 3/4/2026 7:18 PM, Konrad Dybcio wrote:
> The clock tree for byte_clk_src is as follows:
>
> ┌──────byte0_clk_src─────┐
> │ │
> byte0_clk byte0_div_clk_src
> │
> byte0_intf_clk
>
> If both of its direct children have CLK_SET_RATE_PARENT with different
> requests, byte0_clk_src (and its parent) will be reconfigured. In this
> case, byte0_intf should strictly follow the rate of byte0_clk (with
> some adjustments based on PHY mode).
>
> Remove CLK_SET_RATE_PARENT from byte0_div_clk_src to avoid this issue.
>
> Fixes: f40b5217dce1 ("clk: qcom: Add Display Clock controller (DISPCC) driver for Milos")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>
--
Thanks,
Taniya Das
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 4/5] clk: qcom: dispcc-sm4450: Fix DSI byte clock rate setting
2026-03-04 13:48 [PATCH 0/5] DSI byte clock setting fixup Konrad Dybcio
` (2 preceding siblings ...)
2026-03-04 13:48 ` [PATCH 3/5] clk: qcom: dispcc-milos: " Konrad Dybcio
@ 2026-03-04 13:48 ` Konrad Dybcio
2026-03-04 14:27 ` Dmitry Baryshkov
2026-03-05 6:14 ` Taniya Das
2026-03-04 13:48 ` [PATCH 5/5] clk: qcom: dispcc[01]-sa8775p: " Konrad Dybcio
2026-03-10 2:45 ` [PATCH 0/5] DSI byte clock setting fixup Bjorn Andersson
5 siblings, 2 replies; 17+ messages in thread
From: Konrad Dybcio @ 2026-03-04 13:48 UTC (permalink / raw)
To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Taniya Das,
Dmitry Baryshkov, Luca Weiss, Dmitry Baryshkov, Ajit Pandey,
Taniya Das, Jagadeesh Kona
Cc: linux-arm-msm, linux-clk, linux-kernel, Konrad Dybcio
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
The clock tree for byte_clk_src is as follows:
┌──────byte0_clk_src─────┐
│ │
byte0_clk byte0_div_clk_src
│
byte0_intf_clk
If both of its direct children have CLK_SET_RATE_PARENT with different
requests, byte0_clk_src (and its parent) will be reconfigured. In this
case, byte0_intf should strictly follow the rate of byte0_clk (with
some adjustments based on PHY mode).
Remove CLK_SET_RATE_PARENT from byte0_div_clk_src to avoid this issue.
Fixes: 76f05f1ec766 ("clk: qcom: Add DISPCC driver support for SM4450")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
drivers/clk/qcom/dispcc-sm4450.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/qcom/dispcc-sm4450.c b/drivers/clk/qcom/dispcc-sm4450.c
index e8752d01c8e6..2fdacc26df69 100644
--- a/drivers/clk/qcom/dispcc-sm4450.c
+++ b/drivers/clk/qcom/dispcc-sm4450.c
@@ -335,7 +335,6 @@ static struct clk_regmap_div disp_cc_mdss_byte0_div_clk_src = {
&disp_cc_mdss_byte0_clk_src.clkr.hw,
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
.ops = &clk_regmap_div_ops,
},
};
--
2.53.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 4/5] clk: qcom: dispcc-sm4450: Fix DSI byte clock rate setting
2026-03-04 13:48 ` [PATCH 4/5] clk: qcom: dispcc-sm4450: " Konrad Dybcio
@ 2026-03-04 14:27 ` Dmitry Baryshkov
2026-03-05 6:14 ` Taniya Das
1 sibling, 0 replies; 17+ messages in thread
From: Dmitry Baryshkov @ 2026-03-04 14:27 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Michael Turquette, Stephen Boyd, Taniya Das,
Luca Weiss, Dmitry Baryshkov, Ajit Pandey, Taniya Das,
Jagadeesh Kona, linux-arm-msm, linux-clk, linux-kernel,
Konrad Dybcio
On Wed, Mar 04, 2026 at 02:48:30PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> The clock tree for byte_clk_src is as follows:
>
> ┌──────byte0_clk_src─────┐
> │ │
> byte0_clk byte0_div_clk_src
> │
> byte0_intf_clk
>
> If both of its direct children have CLK_SET_RATE_PARENT with different
> requests, byte0_clk_src (and its parent) will be reconfigured. In this
> case, byte0_intf should strictly follow the rate of byte0_clk (with
> some adjustments based on PHY mode).
>
> Remove CLK_SET_RATE_PARENT from byte0_div_clk_src to avoid this issue.
>
> Fixes: 76f05f1ec766 ("clk: qcom: Add DISPCC driver support for SM4450")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> drivers/clk/qcom/dispcc-sm4450.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 4/5] clk: qcom: dispcc-sm4450: Fix DSI byte clock rate setting
2026-03-04 13:48 ` [PATCH 4/5] clk: qcom: dispcc-sm4450: " Konrad Dybcio
2026-03-04 14:27 ` Dmitry Baryshkov
@ 2026-03-05 6:14 ` Taniya Das
1 sibling, 0 replies; 17+ messages in thread
From: Taniya Das @ 2026-03-05 6:14 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Michael Turquette, Stephen Boyd,
Dmitry Baryshkov, Luca Weiss, Dmitry Baryshkov, Ajit Pandey,
Taniya Das, Jagadeesh Kona
Cc: linux-arm-msm, linux-clk, linux-kernel, Konrad Dybcio
On 3/4/2026 7:18 PM, Konrad Dybcio wrote:
> The clock tree for byte_clk_src is as follows:
>
> ┌──────byte0_clk_src─────┐
> │ │
> byte0_clk byte0_div_clk_src
> │
> byte0_intf_clk
>
> If both of its direct children have CLK_SET_RATE_PARENT with different
> requests, byte0_clk_src (and its parent) will be reconfigured. In this
> case, byte0_intf should strictly follow the rate of byte0_clk (with
> some adjustments based on PHY mode).
>
> Remove CLK_SET_RATE_PARENT from byte0_div_clk_src to avoid this issue.
>
> Fixes: 76f05f1ec766 ("clk: qcom: Add DISPCC driver support for SM4450")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>
--
Thanks,
Taniya Das
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 5/5] clk: qcom: dispcc[01]-sa8775p: Fix DSI byte clock rate setting
2026-03-04 13:48 [PATCH 0/5] DSI byte clock setting fixup Konrad Dybcio
` (3 preceding siblings ...)
2026-03-04 13:48 ` [PATCH 4/5] clk: qcom: dispcc-sm4450: " Konrad Dybcio
@ 2026-03-04 13:48 ` Konrad Dybcio
2026-03-04 14:27 ` Dmitry Baryshkov
2026-03-05 6:13 ` Taniya Das
2026-03-10 2:45 ` [PATCH 0/5] DSI byte clock setting fixup Bjorn Andersson
5 siblings, 2 replies; 17+ messages in thread
From: Konrad Dybcio @ 2026-03-04 13:48 UTC (permalink / raw)
To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Taniya Das,
Dmitry Baryshkov, Luca Weiss, Dmitry Baryshkov, Ajit Pandey,
Taniya Das, Jagadeesh Kona
Cc: linux-arm-msm, linux-clk, linux-kernel, Konrad Dybcio
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
The clock tree for byte_clk_src is as follows:
┌──────byte0_clk_src─────┐
│ │
byte0_clk byte0_div_clk_src
│
byte0_intf_clk
If both of its direct children have CLK_SET_RATE_PARENT with different
requests, byte0_clk_src (and its parent) will be reconfigured. In this
case, byte0_intf should strictly follow the rate of byte0_clk (with
some adjustments based on PHY mode).
Remove CLK_SET_RATE_PARENT from byte0_div_clk_src to avoid this issue.
Fixes: e700bfd2f976 ("clk: qcom: Add support for Display clock Controllers on SA8775P")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
drivers/clk/qcom/dispcc0-sa8775p.c | 2 --
drivers/clk/qcom/dispcc1-sa8775p.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/clk/qcom/dispcc0-sa8775p.c b/drivers/clk/qcom/dispcc0-sa8775p.c
index aeda9cf4bfee..b248fa970587 100644
--- a/drivers/clk/qcom/dispcc0-sa8775p.c
+++ b/drivers/clk/qcom/dispcc0-sa8775p.c
@@ -591,7 +591,6 @@ static struct clk_regmap_div mdss_0_disp_cc_mdss_byte0_div_clk_src = {
&mdss_0_disp_cc_mdss_byte0_clk_src.clkr.hw,
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
.ops = &clk_regmap_div_ops,
},
};
@@ -606,7 +605,6 @@ static struct clk_regmap_div mdss_0_disp_cc_mdss_byte1_div_clk_src = {
&mdss_0_disp_cc_mdss_byte1_clk_src.clkr.hw,
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
.ops = &clk_regmap_div_ops,
},
};
diff --git a/drivers/clk/qcom/dispcc1-sa8775p.c b/drivers/clk/qcom/dispcc1-sa8775p.c
index cd55d1c11902..9882edbb79f9 100644
--- a/drivers/clk/qcom/dispcc1-sa8775p.c
+++ b/drivers/clk/qcom/dispcc1-sa8775p.c
@@ -591,7 +591,6 @@ static struct clk_regmap_div mdss_1_disp_cc_mdss_byte0_div_clk_src = {
&mdss_1_disp_cc_mdss_byte0_clk_src.clkr.hw,
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
.ops = &clk_regmap_div_ops,
},
};
@@ -606,7 +605,6 @@ static struct clk_regmap_div mdss_1_disp_cc_mdss_byte1_div_clk_src = {
&mdss_1_disp_cc_mdss_byte1_clk_src.clkr.hw,
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT,
.ops = &clk_regmap_div_ops,
},
};
--
2.53.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 5/5] clk: qcom: dispcc[01]-sa8775p: Fix DSI byte clock rate setting
2026-03-04 13:48 ` [PATCH 5/5] clk: qcom: dispcc[01]-sa8775p: " Konrad Dybcio
@ 2026-03-04 14:27 ` Dmitry Baryshkov
2026-03-05 6:13 ` Taniya Das
1 sibling, 0 replies; 17+ messages in thread
From: Dmitry Baryshkov @ 2026-03-04 14:27 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, Michael Turquette, Stephen Boyd, Taniya Das,
Luca Weiss, Dmitry Baryshkov, Ajit Pandey, Taniya Das,
Jagadeesh Kona, linux-arm-msm, linux-clk, linux-kernel,
Konrad Dybcio
On Wed, Mar 04, 2026 at 02:48:31PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> The clock tree for byte_clk_src is as follows:
>
> ┌──────byte0_clk_src─────┐
> │ │
> byte0_clk byte0_div_clk_src
> │
> byte0_intf_clk
>
> If both of its direct children have CLK_SET_RATE_PARENT with different
> requests, byte0_clk_src (and its parent) will be reconfigured. In this
> case, byte0_intf should strictly follow the rate of byte0_clk (with
> some adjustments based on PHY mode).
>
> Remove CLK_SET_RATE_PARENT from byte0_div_clk_src to avoid this issue.
>
> Fixes: e700bfd2f976 ("clk: qcom: Add support for Display clock Controllers on SA8775P")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> drivers/clk/qcom/dispcc0-sa8775p.c | 2 --
> drivers/clk/qcom/dispcc1-sa8775p.c | 2 --
> 2 files changed, 4 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 5/5] clk: qcom: dispcc[01]-sa8775p: Fix DSI byte clock rate setting
2026-03-04 13:48 ` [PATCH 5/5] clk: qcom: dispcc[01]-sa8775p: " Konrad Dybcio
2026-03-04 14:27 ` Dmitry Baryshkov
@ 2026-03-05 6:13 ` Taniya Das
1 sibling, 0 replies; 17+ messages in thread
From: Taniya Das @ 2026-03-05 6:13 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Michael Turquette, Stephen Boyd,
Dmitry Baryshkov, Luca Weiss, Dmitry Baryshkov, Ajit Pandey,
Taniya Das, Jagadeesh Kona
Cc: linux-arm-msm, linux-clk, linux-kernel, Konrad Dybcio
On 3/4/2026 7:18 PM, Konrad Dybcio wrote:
> The clock tree for byte_clk_src is as follows:
>
> ┌──────byte0_clk_src─────┐
> │ │
> byte0_clk byte0_div_clk_src
> │
> byte0_intf_clk
>
> If both of its direct children have CLK_SET_RATE_PARENT with different
> requests, byte0_clk_src (and its parent) will be reconfigured. In this
> case, byte0_intf should strictly follow the rate of byte0_clk (with
> some adjustments based on PHY mode).
>
> Remove CLK_SET_RATE_PARENT from byte0_div_clk_src to avoid this issue.
>
> Fixes: e700bfd2f976 ("clk: qcom: Add support for Display clock Controllers on SA8775P")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> drivers/clk/qcom/dispcc0-sa8775p.c | 2 --
> drivers/clk/qcom/dispcc1-sa8775p.c | 2 --
> 2 files changed, 4 deletions(-)
Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>
--
Thanks,
Taniya Das
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 0/5] DSI byte clock setting fixup
2026-03-04 13:48 [PATCH 0/5] DSI byte clock setting fixup Konrad Dybcio
` (4 preceding siblings ...)
2026-03-04 13:48 ` [PATCH 5/5] clk: qcom: dispcc[01]-sa8775p: " Konrad Dybcio
@ 2026-03-10 2:45 ` Bjorn Andersson
5 siblings, 0 replies; 17+ messages in thread
From: Bjorn Andersson @ 2026-03-10 2:45 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Taniya Das, Dmitry Baryshkov,
Luca Weiss, Dmitry Baryshkov, Ajit Pandey, Taniya Das,
Jagadeesh Kona, Konrad Dybcio
Cc: linux-arm-msm, linux-clk, linux-kernel, Konrad Dybcio
On Wed, 04 Mar 2026 14:48:26 +0100, Konrad Dybcio wrote:
> There's a conflict between the byte and byte_intf_div2 clocks trying to
> set_rate on their common parent. The latter should follow the rate of
> the former in one way or another anyway, so the fix here is to prevent
> the latter from ratesetting the upstream PLL.
>
> This series does just that.
>
> [...]
Applied, thanks!
[1/5] clk: qcom: dispcc-glymur: Fix DSI byte clock rate setting
commit: 98ea9eda030587601db56425efcd32263d853591
[2/5] clk: qcom: dispcc-kaanapali: Fix DSI byte clock rate setting
commit: e892f4e3f3d558ce5d7595dca7cce2bd170a19fa
[3/5] clk: qcom: dispcc-milos: Fix DSI byte clock rate setting
commit: dd5b76257b4048151006620c9895e2f5f0d997eb
[4/5] clk: qcom: dispcc-sm4450: Fix DSI byte clock rate setting
commit: 7bc48fcdf9e77bf68ef04af015d50df2a9acac00
[5/5] clk: qcom: dispcc[01]-sa8775p: Fix DSI byte clock rate setting
commit: 2851b6c6a42e22c243aa4cd606a49e2b9acfb6d6
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 17+ messages in thread