From: Markus Elfring <Markus.Elfring@web.de>
To: Carlos Bilbao <carlos.bilbao.osdev@gmail.com>,
Michael Roth <michael.roth@amd.com>,
kvm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-coco@lists.linux.dev
Cc: LKML <linux-kernel@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>
Subject: Re: KVM: SEV: Fix unused variable in guest request handling
Date: Mon, 20 May 2024 16:16:24 +0200 [thread overview]
Message-ID: <6da2ddfb-02f3-43a7-89f4-60d1613dd5a4@web.de> (raw)
In-Reply-To: <cfdf1ee1-41a3-46f1-9a71-ad09894ee931@gmail.com>
>>> The variable 'sev' is assigned, but never used. Remove it.
>> Would it be a bit nicer to use the word “Omit” instead of “Fix”
>> in the summary phrase?
>
>
> I can find many instances of "Fix unused variable" in the history of the
> kernel:
…
> but not a single "Omit unused variable" commit.
Some implementation details were fixed somehow because of a warning or error message.
You would probably like to point the desire out in your summary phrase
to get rid of another bit of redundant source code.
Were any analysis tools involved in the discovery of corresponding change possibilities?
Regards,
Markus
prev parent reply other threads:[~2024-05-20 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 18:19 [PATCH] KVM: SEV: Fix unused variable in guest request handling Michael Roth
2024-05-18 15:29 ` Carlos Bilbao
2024-05-19 5:50 ` Markus Elfring
2024-05-20 13:49 ` Carlos Bilbao
2024-05-20 14:16 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6da2ddfb-02f3-43a7-89f4-60d1613dd5a4@web.de \
--to=markus.elfring@web.de \
--cc=carlos.bilbao.osdev@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox