From: Carlos Bilbao <carlos.bilbao.osdev@gmail.com>
To: Michael Roth <michael.roth@amd.com>, kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
linux-coco@lists.linux.dev,
Sean Christopherson <seanjc@google.com>
Subject: Re: [PATCH] KVM: SEV: Fix unused variable in guest request handling
Date: Sat, 18 May 2024 10:29:03 -0500 [thread overview]
Message-ID: <83b2db44-c7bc-49af-8634-d349b91dfab0@gmail.com> (raw)
In-Reply-To: <20240513181928.720979-1-michael.roth@amd.com>
On 5/13/24 13:19, Michael Roth wrote:
> The variable 'sev' is assigned, but never used. Remove it.
>
> Fixes: 449ead2d1edb ("KVM: SEV: Provide support for SNP_GUEST_REQUEST NAE event")
> Signed-off-by: Michael Roth <michael.roth@amd.com>
Reviewed-by: Carlos Bilbao <carlos.bilbao.osdev@gmail.com>
> ---
> arch/x86/kvm/svm/sev.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index 59c0d89a4d52..6cf665c410b2 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -3965,14 +3965,11 @@ static int __snp_handle_guest_req(struct kvm *kvm, gpa_t req_gpa, gpa_t resp_gpa
> sev_ret_code *fw_err)
> {
> struct sev_data_snp_guest_request data = {0};
> - struct kvm_sev_info *sev;
> int ret;
>
> if (!sev_snp_guest(kvm))
> return -EINVAL;
>
> - sev = &to_kvm_svm(kvm)->sev_info;
> -
> ret = snp_setup_guest_buf(kvm, &data, req_gpa, resp_gpa);
> if (ret)
> return ret;
next prev parent reply other threads:[~2024-05-18 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 18:19 [PATCH] KVM: SEV: Fix unused variable in guest request handling Michael Roth
2024-05-18 15:29 ` Carlos Bilbao [this message]
2024-05-19 5:50 ` Markus Elfring
2024-05-20 13:49 ` Carlos Bilbao
2024-05-20 14:16 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83b2db44-c7bc-49af-8634-d349b91dfab0@gmail.com \
--to=carlos.bilbao.osdev@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox