Linux Confidential Computing Development
 help / color / mirror / Atom feed
From: Carlos Bilbao <carlos.bilbao.osdev@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>,
	Michael Roth <michael.roth@amd.com>,
	kvm@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-coco@lists.linux.dev
Cc: LKML <linux-kernel@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>
Subject: Re: [PATCH] KVM: SEV: Fix unused variable in guest request handling
Date: Mon, 20 May 2024 08:49:00 -0500	[thread overview]
Message-ID: <cfdf1ee1-41a3-46f1-9a71-ad09894ee931@gmail.com> (raw)
In-Reply-To: <76413d53-4572-4a38-baff-8b01f6179c8e@web.de>

Hey Markus,

On 5/19/24 12:50 AM, Markus Elfring wrote:
>> The variable 'sev' is assigned, but never used. Remove it.
> Would it be a bit nicer to use the word “Omit” instead of “Fix”
> in the summary phrase?


I can find many instances of "Fix unused variable" in the history of the
kernel:

ubsan: fix unused variable warning in test module
x86/resctrl: Fix unused variable warning in cache_alloc_hsw_probe()
octeontx2-pf: Fix unused variable build error
etc...

but not a single "Omit unused variable" commit.


>
> Regards,
> Markus


Thanks,
Carlos


  reply	other threads:[~2024-05-20 13:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-13 18:19 [PATCH] KVM: SEV: Fix unused variable in guest request handling Michael Roth
2024-05-18 15:29 ` Carlos Bilbao
2024-05-19  5:50 ` Markus Elfring
2024-05-20 13:49   ` Carlos Bilbao [this message]
2024-05-20 14:16     ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfdf1ee1-41a3-46f1-9a71-ad09894ee931@gmail.com \
    --to=carlos.bilbao.osdev@gmail.com \
    --cc=Markus.Elfring@web.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox