* [PATCH -next] crypto: algif_rng - fix sparse non static symbol warning
@ 2015-01-14 1:14 weiyj_lk
2015-01-14 3:11 ` Stephan Mueller
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: weiyj_lk @ 2015-01-14 1:14 UTC (permalink / raw)
To: Herbert Xu, Stephan Mueller; +Cc: Wei Yongjun, linux-crypto
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fixes the following sparse warnings:
crypto/algif_rng.c:185:13: warning:
symbol 'rng_exit' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
crypto/algif_rng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/algif_rng.c b/crypto/algif_rng.c
index 91c06f5..67f612c 100644
--- a/crypto/algif_rng.c
+++ b/crypto/algif_rng.c
@@ -182,7 +182,7 @@ static int __init rng_init(void)
return af_alg_register_type(&algif_type_rng);
}
-void __exit rng_exit(void)
+static void __exit rng_exit(void)
{
int err = af_alg_unregister_type(&algif_type_rng);
BUG_ON(err);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] crypto: algif_rng - fix sparse non static symbol warning
2015-01-14 1:14 [PATCH -next] crypto: algif_rng - fix sparse non static symbol warning weiyj_lk
@ 2015-01-14 3:11 ` Stephan Mueller
2015-01-14 9:43 ` Neil Horman
2015-01-14 11:00 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Stephan Mueller @ 2015-01-14 3:11 UTC (permalink / raw)
To: weiyj_lk; +Cc: Herbert Xu, Wei Yongjun, linux-crypto
Am Mittwoch, 14. Januar 2015, 09:14:41 schrieb weiyj_lk@163.com:
Hi,
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warnings:
>
> crypto/algif_rng.c:185:13: warning:
> symbol 'rng_exit' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Stephan Mueller <smueller@chronox.de>
> ---
> crypto/algif_rng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/algif_rng.c b/crypto/algif_rng.c
> index 91c06f5..67f612c 100644
> --- a/crypto/algif_rng.c
> +++ b/crypto/algif_rng.c
> @@ -182,7 +182,7 @@ static int __init rng_init(void)
> return af_alg_register_type(&algif_type_rng);
> }
>
> -void __exit rng_exit(void)
> +static void __exit rng_exit(void)
> {
> int err = af_alg_unregister_type(&algif_type_rng);
> BUG_ON(err);
--
Ciao
Stephan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] crypto: algif_rng - fix sparse non static symbol warning
2015-01-14 1:14 [PATCH -next] crypto: algif_rng - fix sparse non static symbol warning weiyj_lk
2015-01-14 3:11 ` Stephan Mueller
@ 2015-01-14 9:43 ` Neil Horman
2015-01-14 11:00 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Neil Horman @ 2015-01-14 9:43 UTC (permalink / raw)
To: weiyj_lk; +Cc: Herbert Xu, Stephan Mueller, Wei Yongjun, linux-crypto
On Wed, Jan 14, 2015 at 09:14:41AM +0800, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warnings:
>
> crypto/algif_rng.c:185:13: warning:
> symbol 'rng_exit' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
> ---
> crypto/algif_rng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/algif_rng.c b/crypto/algif_rng.c
> index 91c06f5..67f612c 100644
> --- a/crypto/algif_rng.c
> +++ b/crypto/algif_rng.c
> @@ -182,7 +182,7 @@ static int __init rng_init(void)
> return af_alg_register_type(&algif_type_rng);
> }
>
> -void __exit rng_exit(void)
> +static void __exit rng_exit(void)
> {
> int err = af_alg_unregister_type(&algif_type_rng);
> BUG_ON(err);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] crypto: algif_rng - fix sparse non static symbol warning
2015-01-14 1:14 [PATCH -next] crypto: algif_rng - fix sparse non static symbol warning weiyj_lk
2015-01-14 3:11 ` Stephan Mueller
2015-01-14 9:43 ` Neil Horman
@ 2015-01-14 11:00 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2015-01-14 11:00 UTC (permalink / raw)
To: weiyj_lk; +Cc: Stephan Mueller, Wei Yongjun, linux-crypto
On Wed, Jan 14, 2015 at 09:14:41AM +0800, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warnings:
>
> crypto/algif_rng.c:185:13: warning:
> symbol 'rng_exit' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-14 11:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-14 1:14 [PATCH -next] crypto: algif_rng - fix sparse non static symbol warning weiyj_lk
2015-01-14 3:11 ` Stephan Mueller
2015-01-14 9:43 ` Neil Horman
2015-01-14 11:00 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox