Linux cryptographic layer development
 help / color / mirror / Atom feed
* [PATCH] crypto: amcc - restore CRYPTO_AES dependency
@ 2019-10-27 15:47 Christian Lamparter
  2019-10-28  6:07 ` Ard Biesheuvel
  2019-11-01  6:13 ` Herbert Xu
  0 siblings, 2 replies; 3+ messages in thread
From: Christian Lamparter @ 2019-10-27 15:47 UTC (permalink / raw)
  To: linux-crypto; +Cc: Ard Biesheuvel

This patch restores the CRYPTO_AES dependency. This is
necessary since some of the crypto4xx driver provided
modes need functioning software fallbacks for
AES-CTR/CCM and GCM.

Fixes: da3e7a9715ea ("crypto: amcc - switch to AES library for GCM key derivation")
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
---
 drivers/crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 23d3fd97f678..06c8e3e1c48a 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -332,6 +332,7 @@ config CRYPTO_DEV_PPC4XX
 	depends on PPC && 4xx
 	select CRYPTO_HASH
 	select CRYPTO_AEAD
+	select CRYPTO_AES
 	select CRYPTO_LIB_AES
 	select CRYPTO_CCM
 	select CRYPTO_CTR
-- 
2.24.0.rc1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: amcc - restore CRYPTO_AES dependency
  2019-10-27 15:47 [PATCH] crypto: amcc - restore CRYPTO_AES dependency Christian Lamparter
@ 2019-10-28  6:07 ` Ard Biesheuvel
  2019-11-01  6:13 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2019-10-28  6:07 UTC (permalink / raw)
  To: Christian Lamparter; +Cc: open list:HARDWARE RANDOM NUMBER GENERATOR CORE

On Sun, 27 Oct 2019 at 16:47, Christian Lamparter <chunkeey@gmail.com> wrote:
>
> This patch restores the CRYPTO_AES dependency. This is
> necessary since some of the crypto4xx driver provided
> modes need functioning software fallbacks for
> AES-CTR/CCM and GCM.
>
> Fixes: da3e7a9715ea ("crypto: amcc - switch to AES library for GCM key derivation")
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  drivers/crypto/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index 23d3fd97f678..06c8e3e1c48a 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -332,6 +332,7 @@ config CRYPTO_DEV_PPC4XX
>         depends on PPC && 4xx
>         select CRYPTO_HASH
>         select CRYPTO_AEAD
> +       select CRYPTO_AES
>         select CRYPTO_LIB_AES
>         select CRYPTO_CCM
>         select CRYPTO_CTR
> --
> 2.24.0.rc1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: amcc - restore CRYPTO_AES dependency
  2019-10-27 15:47 [PATCH] crypto: amcc - restore CRYPTO_AES dependency Christian Lamparter
  2019-10-28  6:07 ` Ard Biesheuvel
@ 2019-11-01  6:13 ` Herbert Xu
  1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2019-11-01  6:13 UTC (permalink / raw)
  To: Christian Lamparter; +Cc: linux-crypto, ard.biesheuvel

Christian Lamparter <chunkeey@gmail.com> wrote:
> This patch restores the CRYPTO_AES dependency. This is
> necessary since some of the crypto4xx driver provided
> modes need functioning software fallbacks for
> AES-CTR/CCM and GCM.
> 
> Fixes: da3e7a9715ea ("crypto: amcc - switch to AES library for GCM key derivation")
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
> ---
> drivers/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-01  6:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-27 15:47 [PATCH] crypto: amcc - restore CRYPTO_AES dependency Christian Lamparter
2019-10-28  6:07 ` Ard Biesheuvel
2019-11-01  6:13 ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox