From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: "Horia Geantă" <horia.geanta@nxp.com>,
"Aymen Sghaier" <aymen.sghaier@nxp.com>,
"Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>,
"Iuliana Prodan" <iuliana.prodan@nxp.com>
Subject: Re: [PATCH] crypto: caam - Remove broken arc4 support
Date: Thu, 2 Jul 2020 17:45:33 +1000 [thread overview]
Message-ID: <20200702074533.GC4253@gondor.apana.org.au> (raw)
In-Reply-To: <CAMj1kXGvMe_A_iQ43Pmygg9xaAM-RLy=_M=v+eg--8xNmv9P+w@mail.gmail.com>
On Thu, Jul 02, 2020 at 09:40:42AM +0200, Ard Biesheuvel wrote:
>
> I suppose you are looking into this for chaining algif_skipcher
> requests, right? So in that case, the ARC4 state should really be
> treated as an IV, which is owned by the caller, and not stored in
> either the TFM or the skcipher request object.
Yes I have considered this approach previously but it's just too
messy. What I'm trying to do now is to allow the state to be stored
in the request object. When combined with the proposed REQ_MORE
flag, this should be sufficient. It evens works on XTS.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-07-02 7:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 4:36 [PATCH] crypto: caam - Remove broken arc4 support Herbert Xu
2020-07-02 7:27 ` Ard Biesheuvel
2020-07-02 7:32 ` Ard Biesheuvel
2020-07-02 7:40 ` Ard Biesheuvel
2020-07-02 7:45 ` Herbert Xu [this message]
2020-07-02 7:51 ` Ard Biesheuvel
2020-07-02 7:56 ` Herbert Xu
2020-07-02 8:00 ` Herbert Xu
2020-07-02 8:12 ` Ard Biesheuvel
2020-07-02 7:41 ` Herbert Xu
2020-07-02 7:40 ` Herbert Xu
2020-07-05 19:11 ` Horia Geantă
2020-07-06 13:42 ` Ard Biesheuvel
2020-07-08 16:24 ` Horia Geantă
2020-07-09 0:47 ` Herbert Xu
2020-07-09 8:53 ` Horia Geantă
2020-07-09 9:42 ` Ard Biesheuvel
2020-07-16 8:09 ` Horia Geantă
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702074533.GC4253@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=aymen.sghaier@nxp.com \
--cc=horia.geanta@nxp.com \
--cc=iuliana.prodan@nxp.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox