From: "Horia Geantă" <horia.geanta@nxp.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Aymen Sghaier <aymen.sghaier@nxp.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Cc: Iuliana Prodan <iuliana.prodan@nxp.com>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH] crypto: caam - Remove broken arc4 support
Date: Sun, 5 Jul 2020 22:11:06 +0300 [thread overview]
Message-ID: <31734e86-951a-6063-942a-1d62abeb5490@nxp.com> (raw)
In-Reply-To: <20200702043648.GA21823@gondor.apana.org.au>
On 7/2/2020 7:36 AM, Herbert Xu wrote:
> The arc4 algorithm requires storing state in the request context
> in order to allow more than one encrypt/decrypt operation. As this
> driver does not seem to do that, it means that using it for more
> than one operation is broken.
>
The fact that smth. is broken doesn't necessarily means it has to be removed.
Looking at the HW capabilities, I am sure the implementation could be
modified to save/restore the internal state to/from the request context.
Anyhow I would like to know if only the correctness is being debated,
or this patch should be dealt with in the larger context of
removing crypto API based ecb(arc4) altogether:
[RFC PATCH 0/7] crypto: get rid of ecb(arc4)
https://lore.kernel.org/linux-crypto/20200702101947.682-1-ardb@kernel.org/
Thanks,
Horia
next prev parent reply other threads:[~2020-07-05 19:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 4:36 [PATCH] crypto: caam - Remove broken arc4 support Herbert Xu
2020-07-02 7:27 ` Ard Biesheuvel
2020-07-02 7:32 ` Ard Biesheuvel
2020-07-02 7:40 ` Ard Biesheuvel
2020-07-02 7:45 ` Herbert Xu
2020-07-02 7:51 ` Ard Biesheuvel
2020-07-02 7:56 ` Herbert Xu
2020-07-02 8:00 ` Herbert Xu
2020-07-02 8:12 ` Ard Biesheuvel
2020-07-02 7:41 ` Herbert Xu
2020-07-02 7:40 ` Herbert Xu
2020-07-05 19:11 ` Horia Geantă [this message]
2020-07-06 13:42 ` Ard Biesheuvel
2020-07-08 16:24 ` Horia Geantă
2020-07-09 0:47 ` Herbert Xu
2020-07-09 8:53 ` Horia Geantă
2020-07-09 9:42 ` Ard Biesheuvel
2020-07-16 8:09 ` Horia Geantă
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31734e86-951a-6063-942a-1d62abeb5490@nxp.com \
--to=horia.geanta@nxp.com \
--cc=ardb@kernel.org \
--cc=aymen.sghaier@nxp.com \
--cc=herbert@gondor.apana.org.au \
--cc=iuliana.prodan@nxp.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox