From: "Horia Geantă" <horia.geanta@nxp.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Aymen Sghaier <aymen.sghaier@nxp.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Cc: Iuliana Prodan <iuliana.prodan@nxp.com>
Subject: Re: [PATCH] crypto: caam - Remove broken arc4 support
Date: Thu, 16 Jul 2020 11:09:08 +0300 [thread overview]
Message-ID: <6b810baf-9eb7-ddc3-de7e-14078ae160e0@nxp.com> (raw)
In-Reply-To: <20200702043648.GA21823@gondor.apana.org.au>
On 7/2/2020 7:36 AM, Herbert Xu wrote:
> The arc4 algorithm requires storing state in the request context
> in order to allow more than one encrypt/decrypt operation. As this
> driver does not seem to do that, it means that using it for more
> than one operation is broken.
>
> Fixes: eaed71a44ad9 ("crypto: caam - add ecb(*) support")
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Given the circumstances, it's not feasible to fix arc4 in caam.
Link: https://lore.kernel.org/linux-crypto/CAMj1kXGvMe_A_iQ43Pmygg9xaAM-RLy=_M=v+eg--8xNmv9P+w@mail.gmail.com
Link: https://lore.kernel.org/linux-crypto/20200702101947.682-1-ardb@kernel.org
Acked-by: Horia Geantă <horia.geanta@nxp.com>
Horia
prev parent reply other threads:[~2020-07-16 8:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 4:36 [PATCH] crypto: caam - Remove broken arc4 support Herbert Xu
2020-07-02 7:27 ` Ard Biesheuvel
2020-07-02 7:32 ` Ard Biesheuvel
2020-07-02 7:40 ` Ard Biesheuvel
2020-07-02 7:45 ` Herbert Xu
2020-07-02 7:51 ` Ard Biesheuvel
2020-07-02 7:56 ` Herbert Xu
2020-07-02 8:00 ` Herbert Xu
2020-07-02 8:12 ` Ard Biesheuvel
2020-07-02 7:41 ` Herbert Xu
2020-07-02 7:40 ` Herbert Xu
2020-07-05 19:11 ` Horia Geantă
2020-07-06 13:42 ` Ard Biesheuvel
2020-07-08 16:24 ` Horia Geantă
2020-07-09 0:47 ` Herbert Xu
2020-07-09 8:53 ` Horia Geantă
2020-07-09 9:42 ` Ard Biesheuvel
2020-07-16 8:09 ` Horia Geantă [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b810baf-9eb7-ddc3-de7e-14078ae160e0@nxp.com \
--to=horia.geanta@nxp.com \
--cc=aymen.sghaier@nxp.com \
--cc=herbert@gondor.apana.org.au \
--cc=iuliana.prodan@nxp.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox