* [PATCH] lib/mpi: Add the return value check of kcalloc()
@ 2021-12-30 7:03 Zizhuang Deng
2021-12-30 7:26 ` Tianjia Zhang
2022-01-07 3:33 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Zizhuang Deng @ 2021-12-30 7:03 UTC (permalink / raw)
To: tianjia.zhang, herbert; +Cc: linux-kernel, linux-crypto, Zizhuang Deng
Add the return value check of kcalloc() to avoid potential
NULL ptr dereference.
Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com>
---
lib/mpi/mpi-mod.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
index 47bc59edd4ff..54fcc01564d9 100644
--- a/lib/mpi/mpi-mod.c
+++ b/lib/mpi/mpi-mod.c
@@ -40,6 +40,8 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
mpi_normalize(m);
ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
+ if (!ctx)
+ return NULL;
if (copy) {
ctx->m = mpi_copy(m);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] lib/mpi: Add the return value check of kcalloc()
2021-12-30 7:03 [PATCH] lib/mpi: Add the return value check of kcalloc() Zizhuang Deng
@ 2021-12-30 7:26 ` Tianjia Zhang
2022-01-07 3:33 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Tianjia Zhang @ 2021-12-30 7:26 UTC (permalink / raw)
To: Zizhuang Deng, herbert; +Cc: linux-kernel, linux-crypto
On 12/30/21 3:03 PM, Zizhuang Deng wrote:
> Add the return value check of kcalloc() to avoid potential
> NULL ptr dereference.
>
> Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com>
> ---
Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Best regards,
Tianjia
> lib/mpi/mpi-mod.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
> index 47bc59edd4ff..54fcc01564d9 100644
> --- a/lib/mpi/mpi-mod.c
> +++ b/lib/mpi/mpi-mod.c
> @@ -40,6 +40,8 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
>
> mpi_normalize(m);
> ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
> + if (!ctx)
> + return NULL;
>
> if (copy) {
> ctx->m = mpi_copy(m);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] lib/mpi: Add the return value check of kcalloc()
2021-12-30 7:03 [PATCH] lib/mpi: Add the return value check of kcalloc() Zizhuang Deng
2021-12-30 7:26 ` Tianjia Zhang
@ 2022-01-07 3:33 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2022-01-07 3:33 UTC (permalink / raw)
To: Zizhuang Deng; +Cc: tianjia.zhang, linux-kernel, linux-crypto
On Thu, Dec 30, 2021 at 03:03:31PM +0800, Zizhuang Deng wrote:
> Add the return value check of kcalloc() to avoid potential
> NULL ptr dereference.
>
> Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com>
> ---
> lib/mpi/mpi-mod.c | 2 ++
> 1 file changed, 2 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-07 3:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-30 7:03 [PATCH] lib/mpi: Add the return value check of kcalloc() Zizhuang Deng
2021-12-30 7:26 ` Tianjia Zhang
2022-01-07 3:33 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox