* [herbert-cryptodev-2.6:master 21/22] drivers/tty/serial/amba-pl011.c:379:30: error: implicit declaration of function 'phys_to_page'; did you mean 'pfn_to_page'?
@ 2023-05-19 11:33 kernel test robot
2023-05-19 12:39 ` Jia Jie Ho
0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2023-05-19 11:33 UTC (permalink / raw)
To: Jia Jie Ho; +Cc: oe-kbuild-all, linux-crypto, Herbert Xu, Huan Feng
Hi Jia,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head: 7883d1b28a2b0e62edcacea22de6b36a1918b15a
commit: 42ef0e944b0119e9987819af0a5a04d32d5e5edf [21/22] crypto: starfive - Add crypto engine support
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230519/202305191929.Eq4OVZ6D-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=42ef0e944b0119e9987819af0a5a04d32d5e5edf
git remote add herbert-cryptodev-2.6 https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
git fetch --no-tags herbert-cryptodev-2.6 master
git checkout 42ef0e944b0119e9987819af0a5a04d32d5e5edf
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/tty/serial/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305191929.Eq4OVZ6D-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
drivers/tty/serial/amba-pl011.c: In function 'pl011_sgbuf_init':
>> drivers/tty/serial/amba-pl011.c:379:30: error: implicit declaration of function 'phys_to_page'; did you mean 'pfn_to_page'? [-Werror=implicit-function-declaration]
379 | sg_set_page(&sg->sg, phys_to_page(dma_addr),
| ^~~~~~~~~~~~
| pfn_to_page
>> drivers/tty/serial/amba-pl011.c:379:30: warning: passing argument 2 of 'sg_set_page' makes pointer from integer without a cast [-Wint-conversion]
379 | sg_set_page(&sg->sg, phys_to_page(dma_addr),
| ^~~~~~~~~~~~~~~~~~~~~~
| |
| int
In file included from include/linux/kfifo.h:42,
from include/linux/tty_port.h:5,
from include/linux/tty.h:12,
from drivers/tty/serial/amba-pl011.c:25:
include/linux/scatterlist.h:136:69: note: expected 'struct page *' but argument is of type 'int'
136 | static inline void sg_set_page(struct scatterlist *sg, struct page *page,
| ~~~~~~~~~~~~~^~~~
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for DMADEVICES
Depends on [n]: HAS_DMA [=n]
Selected by [m]:
- CRYPTO_DEV_JH7110 [=m] && CRYPTO [=y] && CRYPTO_HW [=y] && (SOC_STARFIVE || COMPILE_TEST [=y])
vim +379 drivers/tty/serial/amba-pl011.c
68b65f7305e54b drivers/serial/amba-pl011.c Russell King 2010-12-22 367
ead76f329f777c drivers/tty/serial/amba-pl011.c Linus Walleij 2011-02-24 368 static int pl011_sgbuf_init(struct dma_chan *chan, struct pl011_sgbuf *sg,
ead76f329f777c drivers/tty/serial/amba-pl011.c Linus Walleij 2011-02-24 369 enum dma_data_direction dir)
ead76f329f777c drivers/tty/serial/amba-pl011.c Linus Walleij 2011-02-24 370 {
cb06ff102e2d79 drivers/tty/serial/amba-pl011.c Chanho Min 2013-03-27 371 dma_addr_t dma_addr;
cb06ff102e2d79 drivers/tty/serial/amba-pl011.c Chanho Min 2013-03-27 372
cb06ff102e2d79 drivers/tty/serial/amba-pl011.c Chanho Min 2013-03-27 373 sg->buf = dma_alloc_coherent(chan->device->dev,
cb06ff102e2d79 drivers/tty/serial/amba-pl011.c Chanho Min 2013-03-27 374 PL011_DMA_BUFFER_SIZE, &dma_addr, GFP_KERNEL);
ead76f329f777c drivers/tty/serial/amba-pl011.c Linus Walleij 2011-02-24 375 if (!sg->buf)
ead76f329f777c drivers/tty/serial/amba-pl011.c Linus Walleij 2011-02-24 376 return -ENOMEM;
ead76f329f777c drivers/tty/serial/amba-pl011.c Linus Walleij 2011-02-24 377
cb06ff102e2d79 drivers/tty/serial/amba-pl011.c Chanho Min 2013-03-27 378 sg_init_table(&sg->sg, 1);
cb06ff102e2d79 drivers/tty/serial/amba-pl011.c Chanho Min 2013-03-27 @379 sg_set_page(&sg->sg, phys_to_page(dma_addr),
cb06ff102e2d79 drivers/tty/serial/amba-pl011.c Chanho Min 2013-03-27 380 PL011_DMA_BUFFER_SIZE, offset_in_page(dma_addr));
cb06ff102e2d79 drivers/tty/serial/amba-pl011.c Chanho Min 2013-03-27 381 sg_dma_address(&sg->sg) = dma_addr;
c64be9231e0893 drivers/tty/serial/amba-pl011.c Andrew Jackson 2014-11-07 382 sg_dma_len(&sg->sg) = PL011_DMA_BUFFER_SIZE;
ead76f329f777c drivers/tty/serial/amba-pl011.c Linus Walleij 2011-02-24 383
ead76f329f777c drivers/tty/serial/amba-pl011.c Linus Walleij 2011-02-24 384 return 0;
ead76f329f777c drivers/tty/serial/amba-pl011.c Linus Walleij 2011-02-24 385 }
ead76f329f777c drivers/tty/serial/amba-pl011.c Linus Walleij 2011-02-24 386
:::::: The code at line 379 was first introduced by commit
:::::: cb06ff102e2d79a82cf780aa5e6947b2e0529ac0 ARM: PL011: Add support for Rx DMA buffer polling.
:::::: TO: Chanho Min <chanho.min@lge.com>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [herbert-cryptodev-2.6:master 21/22] drivers/tty/serial/amba-pl011.c:379:30: error: implicit declaration of function 'phys_to_page'; did you mean 'pfn_to_page'?
2023-05-19 11:33 [herbert-cryptodev-2.6:master 21/22] drivers/tty/serial/amba-pl011.c:379:30: error: implicit declaration of function 'phys_to_page'; did you mean 'pfn_to_page'? kernel test robot
@ 2023-05-19 12:39 ` Jia Jie Ho
2023-05-19 12:44 ` Herbert Xu
0 siblings, 1 reply; 5+ messages in thread
From: Jia Jie Ho @ 2023-05-19 12:39 UTC (permalink / raw)
To: Herbert Xu; +Cc: linux-crypto
On 19/5/2023 7:33 pm, kernel test robot wrote:
> Hi Jia,
>
> First bad commit (maybe != root cause):
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head: 7883d1b28a2b0e62edcacea22de6b36a1918b15a
> commit: 42ef0e944b0119e9987819af0a5a04d32d5e5edf [21/22] crypto: starfive - Add crypto engine support
> config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230519/202305191929.Eq4OVZ6D-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=42ef0e944b0119e9987819af0a5a04d32d5e5edf
> git remote add herbert-cryptodev-2.6 https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
> git fetch --no-tags herbert-cryptodev-2.6 master
> git checkout 42ef0e944b0119e9987819af0a5a04d32d5e5edf
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/tty/serial/
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202305191929.Eq4OVZ6D-lkp@intel.com/
>
> All error/warnings (new ones prefixed by >>):
>
> drivers/tty/serial/amba-pl011.c: In function 'pl011_sgbuf_init':
>>> drivers/tty/serial/amba-pl011.c:379:30: error: implicit declaration of function 'phys_to_page'; did you mean 'pfn_to_page'? [-Werror=implicit-function-declaration]
> 379 | sg_set_page(&sg->sg, phys_to_page(dma_addr),
> | ^~~~~~~~~~~~
> | pfn_to_page
>>> drivers/tty/serial/amba-pl011.c:379:30: warning: passing argument 2 of 'sg_set_page' makes pointer from integer without a cast [-Wint-conversion]
> 379 | sg_set_page(&sg->sg, phys_to_page(dma_addr),
> | ^~~~~~~~~~~~~~~~~~~~~~
> | |
> | int
> In file included from include/linux/kfifo.h:42,
> from include/linux/tty_port.h:5,
> from include/linux/tty.h:12,
> from drivers/tty/serial/amba-pl011.c:25:
> include/linux/scatterlist.h:136:69: note: expected 'struct page *' but argument is of type 'int'
> 136 | static inline void sg_set_page(struct scatterlist *sg, struct page *page,
> | ~~~~~~~~~~~~~^~~~
> cc1: some warnings being treated as errors
>
> Kconfig warnings: (for reference only)
> WARNING: unmet direct dependencies detected for DMADEVICES
> Depends on [n]: HAS_DMA [=n]
> Selected by [m]:
> - CRYPTO_DEV_JH7110 [=m] && CRYPTO [=y] && CRYPTO_HW [=y] && (SOC_STARFIVE || COMPILE_TEST [=y])
>
Hi Herbert,
Should I submit a new patch to select HAS_DMA in my Kconfig?
Thanks,
Jia Jie
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [herbert-cryptodev-2.6:master 21/22] drivers/tty/serial/amba-pl011.c:379:30: error: implicit declaration of function 'phys_to_page'; did you mean 'pfn_to_page'?
2023-05-19 12:39 ` Jia Jie Ho
@ 2023-05-19 12:44 ` Herbert Xu
2023-05-19 12:50 ` Jia Jie Ho
0 siblings, 1 reply; 5+ messages in thread
From: Herbert Xu @ 2023-05-19 12:44 UTC (permalink / raw)
To: Jia Jie Ho; +Cc: linux-crypto
On Fri, May 19, 2023 at 08:39:26PM +0800, Jia Jie Ho wrote:
>
> Should I submit a new patch to select HAS_DMA in my Kconfig?
No you should change the select to a dependency. Nobody else
selects it.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [herbert-cryptodev-2.6:master 21/22] drivers/tty/serial/amba-pl011.c:379:30: error: implicit declaration of function 'phys_to_page'; did you mean 'pfn_to_page'?
2023-05-19 12:44 ` Herbert Xu
@ 2023-05-19 12:50 ` Jia Jie Ho
2023-05-19 12:54 ` Herbert Xu
0 siblings, 1 reply; 5+ messages in thread
From: Jia Jie Ho @ 2023-05-19 12:50 UTC (permalink / raw)
To: Herbert Xu; +Cc: linux-crypto
On 19/5/2023 8:44 pm, Herbert Xu wrote:
> On Fri, May 19, 2023 at 08:39:26PM +0800, Jia Jie Ho wrote:
>>
>> Should I submit a new patch to select HAS_DMA in my Kconfig?
>
> No you should change the select to a dependency. Nobody else
> selects it.
>
Sure, should I submit new patch series again or just a new patch with this change?
Thanks
Jia Jie
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [herbert-cryptodev-2.6:master 21/22] drivers/tty/serial/amba-pl011.c:379:30: error: implicit declaration of function 'phys_to_page'; did you mean 'pfn_to_page'?
2023-05-19 12:50 ` Jia Jie Ho
@ 2023-05-19 12:54 ` Herbert Xu
0 siblings, 0 replies; 5+ messages in thread
From: Herbert Xu @ 2023-05-19 12:54 UTC (permalink / raw)
To: Jia Jie Ho; +Cc: linux-crypto
On Fri, May 19, 2023 at 08:50:23PM +0800, Jia Jie Ho wrote:
>
> Sure, should I submit new patch series again or just a new patch with this change?
Once your patch has been applied you should always send an
incremental patch.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-19 12:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-19 11:33 [herbert-cryptodev-2.6:master 21/22] drivers/tty/serial/amba-pl011.c:379:30: error: implicit declaration of function 'phys_to_page'; did you mean 'pfn_to_page'? kernel test robot
2023-05-19 12:39 ` Jia Jie Ho
2023-05-19 12:44 ` Herbert Xu
2023-05-19 12:50 ` Jia Jie Ho
2023-05-19 12:54 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox