From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] crypto: scatterwalk - Change scatterwalk_next calling convention
Date: Wed, 5 Mar 2025 19:10:05 -0800 [thread overview]
Message-ID: <20250306031005.GB1592@sol.localdomain> (raw)
In-Reply-To: <Z8kOABHrceBW7EiK@gondor.apana.org.au>
On Thu, Mar 06, 2025 at 10:52:48AM +0800, Herbert Xu wrote:
> Rather than returning the address and storing the length into an
> argument pointer, add an address field to the walk struct and use
> that to store the address. The length is returned directly.
>
> Change the done functions to use this stored address instead of
> getting them from the caller.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Why? All the callers keep track of the address anyway. I don't see a need to
bloat the scatter_walk structure beyond a simple (sg, offset) pair.
- Eric
next prev parent reply other threads:[~2025-03-06 3:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 2:52 [PATCH] crypto: scatterwalk - Change scatterwalk_next calling convention Herbert Xu
2025-03-06 3:10 ` Eric Biggers [this message]
2025-03-06 3:18 ` Herbert Xu
2025-03-06 3:36 ` Eric Biggers
2025-03-06 3:40 ` Herbert Xu
2025-03-06 3:59 ` Eric Biggers
2025-03-06 6:07 ` [PATCH] crypto: skcipher - Elinimate duplicate virt.addr field Herbert Xu
2025-03-06 17:29 ` Eric Biggers
2025-03-07 3:04 ` Herbert Xu
2025-03-06 17:34 ` [PATCH] crypto: scatterwalk - Change scatterwalk_next calling convention Eric Biggers
2025-03-07 3:05 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306031005.GB1592@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox