From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] crypto: skcipher - Elinimate duplicate virt.addr field
Date: Fri, 7 Mar 2025 11:04:51 +0800 [thread overview]
Message-ID: <Z8piU4Sy3ErUlXPP@gondor.apana.org.au> (raw)
In-Reply-To: <20250306172942.GF1796@sol.localdomain>
On Thu, Mar 06, 2025 at 09:29:42AM -0800, Eric Biggers wrote:
>
> Those unions are ugly, but I guess this is good enough. Please also delete the
> /* XXX */ comments, fix the typo in the title, and resend this as a real patch.
I'm going to keep the XXX comments, which is more about the fact
that we're mixing skcipher_map/unmap with skcipher_next and
skcipher_done_src/dst.
But I will add a new comment to skcipher_walk to make the virt
fields the official way of accessing the pointer. That way the
user is guaranteed to not change it from under us.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-03-07 3:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 2:52 [PATCH] crypto: scatterwalk - Change scatterwalk_next calling convention Herbert Xu
2025-03-06 3:10 ` Eric Biggers
2025-03-06 3:18 ` Herbert Xu
2025-03-06 3:36 ` Eric Biggers
2025-03-06 3:40 ` Herbert Xu
2025-03-06 3:59 ` Eric Biggers
2025-03-06 6:07 ` [PATCH] crypto: skcipher - Elinimate duplicate virt.addr field Herbert Xu
2025-03-06 17:29 ` Eric Biggers
2025-03-07 3:04 ` Herbert Xu [this message]
2025-03-06 17:34 ` [PATCH] crypto: scatterwalk - Change scatterwalk_next calling convention Eric Biggers
2025-03-07 3:05 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8piU4Sy3ErUlXPP@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox