From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] crypto: scatterwalk - Change scatterwalk_next calling convention
Date: Thu, 6 Mar 2025 11:18:15 +0800 [thread overview]
Message-ID: <Z8kT90qXaTo15271@gondor.apana.org.au> (raw)
In-Reply-To: <20250306031005.GB1592@sol.localdomain>
On Wed, Mar 05, 2025 at 07:10:05PM -0800, Eric Biggers wrote:
>
> Why? All the callers keep track of the address anyway. I don't see a need to
> bloat the scatter_walk structure beyond a simple (sg, offset) pair.
Because the existing convention is error-prone and relies on
the caller keeping the mapped pointer intact.
But I will consider your objection about bloating the struct.
The places that I've changed are simply storing the object on
the stack anyway, so there is no actual bloat.
Do you have a usage scenario where this struct is embedded into
something bigger and bloat is a real concern?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-03-06 3:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 2:52 [PATCH] crypto: scatterwalk - Change scatterwalk_next calling convention Herbert Xu
2025-03-06 3:10 ` Eric Biggers
2025-03-06 3:18 ` Herbert Xu [this message]
2025-03-06 3:36 ` Eric Biggers
2025-03-06 3:40 ` Herbert Xu
2025-03-06 3:59 ` Eric Biggers
2025-03-06 6:07 ` [PATCH] crypto: skcipher - Elinimate duplicate virt.addr field Herbert Xu
2025-03-06 17:29 ` Eric Biggers
2025-03-07 3:04 ` Herbert Xu
2025-03-06 17:34 ` [PATCH] crypto: scatterwalk - Change scatterwalk_next calling convention Eric Biggers
2025-03-07 3:05 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8kT90qXaTo15271@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox