[PATCH v1 0/2] Add trng driver to JHB100

[PATCH v1 0/2] Add trng driver to JHB100

[lianfeng.ouyang]

From: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>

for jhb100, While IP assert async reset, it may generate glitch
and propagate to downstream IP. In order to solve RDC issue,
conduct clock gating before asserting reset to prevent generating glitch.

Lianfeng Ouyang (2):
  dt-bindings: Add bindings for StarFive JHB100 SoC trng controller.
  hwrng: starfive: Update clk and reset sequence

 .../bindings/rng/starfive,jh7110-trng.yaml     |  2 +-
 MAINTAINERS                                    |  2 +-
 drivers/char/hw_random/jh7110-trng.c           | 18 ++++++++++++++++--
 3 files changed, 18 insertions(+), 4 deletions(-)

--
2.43.0

[PATCH v1 1/2] dt-bindings: Add bindings for StarFive JHB100 SoC trng controller.

[lianfeng.ouyang]

From: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>

Signed-off-by: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
---
 Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
index 4639247e9e51..11346d77b2f6 100644
--- a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
+++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
@@ -13,8 +13,8 @@ properties:
   compatible:
     oneOf:
       - items:
-          - const: starfive,jh8100-trng
           - const: starfive,jh7110-trng
+          - const: starfive,jhb100-trng
       - const: starfive,jh7110-trng
 
   reg:
-- 
2.43.0

[PATCH v1 2/2] hwrng: starfive: Update clk and reset sequence

[lianfeng.ouyang]

From: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>

for jhb100, While IP assert async reset, it may generate glitch
and propagate to downstream IP. In order to solve RDC issue,
conduct clock gating before asserting reset to prevent generating glitch.

Jia Jie Ho has resigned

Signed-off-by: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
---
 MAINTAINERS                          |  2 +-
 drivers/char/hw_random/jh7110-trng.c | 18 ++++++++++++++++--
 2 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index d3a6b3f6b6a0..729b20ecc697 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -25280,7 +25280,7 @@ F:	Documentation/devicetree/bindings/perf/starfive,jh8100-starlink-pmu.yaml
 F:	drivers/perf/starfive_starlink_pmu.c

 STARFIVE TRNG DRIVER
-M:	Jia Jie Ho <jiajie.ho@starfivetech.com>
+M:	Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
 S:	Supported
 F:	Documentation/devicetree/bindings/rng/starfive*
 F:	drivers/char/hw_random/jh7110-trng.c
diff --git a/drivers/char/hw_random/jh7110-trng.c b/drivers/char/hw_random/jh7110-trng.c
index 9776f4daa044..f5eb434c94f5 100644
--- a/drivers/char/hw_random/jh7110-trng.c
+++ b/drivers/char/hw_random/jh7110-trng.c
@@ -234,12 +234,18 @@ static irqreturn_t starfive_trng_irq(int irq, void *priv)
 static void starfive_trng_cleanup(struct hwrng *rng)
 {
 	struct starfive_trng *trng = to_trng(rng);
+	bool is_jhb100 = device_is_compatible(trng->dev, "starfive,jhb100-trng");

 	writel(0, trng->base + STARFIVE_CTRL);

-	reset_control_assert(trng->rst);
+	if (!is_jhb100)
+		reset_control_assert(trng->rst);
+
 	clk_disable_unprepare(trng->hclk);
 	clk_disable_unprepare(trng->ahb);
+
+	if (is_jhb100)
+		reset_control_assert(trng->rst);
 }

 static int starfive_trng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
@@ -337,12 +343,19 @@ static int starfive_trng_probe(struct platform_device *pdev)

 	ret = devm_hwrng_register(&pdev->dev, &trng->rng);
 	if (ret) {
+		bool is_jhb100 = device_is_compatible(trng->dev, "starfive,jhb100-trng");
+
 		pm_runtime_disable(&pdev->dev);

-		reset_control_assert(trng->rst);
+		if (!is_jhb100)
+			reset_control_assert(trng->rst);
+
 		clk_disable_unprepare(trng->ahb);
 		clk_disable_unprepare(trng->hclk);

+		if (is_jhb100)
+			reset_control_assert(trng->rst);
+
 		return dev_err_probe(&pdev->dev, ret, "Failed to register hwrng\n");
 	}

@@ -378,6 +391,7 @@ static const struct dev_pm_ops starfive_trng_pm_ops = {

 static const struct of_device_id trng_dt_ids[] __maybe_unused = {
 	{ .compatible = "starfive,jh7110-trng" },
+	{ .compatible = "starfive,jhb100-trng" },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, trng_dt_ids);
--
2.43.0

Re: [PATCH v1 1/2] dt-bindings: Add bindings for StarFive JHB100 SoC trng controller.

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

On Tue, May 12, 2026 at 02:24:03PM +0800, lianfeng.ouyang wrote:
> From: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
> 
> Signed-off-by: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
> ---
>  Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> index 4639247e9e51..11346d77b2f6 100644
> --- a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> +++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> @@ -13,8 +13,8 @@ properties:
>    compatible:
>      oneOf:
>        - items:
> -          - const: starfive,jh8100-trng
>            - const: starfive,jh7110-trng
> +          - const: starfive,jhb100-trng

You need to add a commit message here explaining why removing the jh8100
is okay.
pw-bot: changes-requested

>        - const: starfive,jh7110-trng
>  
>    reg:
> -- 
> 2.43.0
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v1 1/2] dt-bindings: Add bindings for StarFive JHB100 SoC trng controller.

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

On Tue, May 12, 2026 at 06:15:07PM +0100, Conor Dooley wrote:
> On Tue, May 12, 2026 at 02:24:03PM +0800, lianfeng.ouyang wrote:
> > From: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
> > 
> > Signed-off-by: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
> > ---
> >  Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> > index 4639247e9e51..11346d77b2f6 100644
> > --- a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> > +++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> > @@ -13,8 +13,8 @@ properties:
> >    compatible:
> >      oneOf:
> >        - items:
> > -          - const: starfive,jh8100-trng
> >            - const: starfive,jh7110-trng
> > +          - const: starfive,jhb100-trng
> 
> You need to add a commit message here explaining why removing the jh8100
> is okay.
> pw-bot: changes-requested

Additionally, given the driver changes, it looks like using a jh7110
fallback is invalid anyway.

> 
> >        - const: starfive,jh7110-trng
> >  
> >    reg:
> > -- 
> > 2.43.0
> > 
> > 



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]